Associative array two variable comparison :update table error

Question

Hi,
i am using associative array to update the version number of table
-i declare two associative array to compare the column from two table (temp,main tables)values in loop
-if id's of both variable(for temp and main table) are equal and column of either of table not matching then it should update the version no of temp table
-if id's not equal i.e record only exists temp table then update null version number annd increment it by 1
-following is the structure and procedure --it shows the matching and non matching records but for the update statement it not giving expected output i.e it updates all records irrespective of the condition provided
-i tried to put condition in update as well as in the  if statement but it updates all record
....suggestion and help highly appreciate. thankx in advance !!!
/*--table structure and data--*/
CREATE TABLE "TEMP_TABLE"
   ( "ID" NUMBER NOT NULL ENABLE,
  "COL1" VARCHAR2(20 BYTE),
  "COL2" VARCHAR2(20 BYTE),
  "VERSION" NUMBER
   INSERT INTO TEMP_TABLE VALUES (101,'A','B',NULL);
   INSERT INTO TEMP_TABLE VALUES (102,'x','y',NULL);
   INSERT INTO TEMP_TABLE VALUES (103,'r','t',NULL);
   CREATE TABLE "MAIN_TABLE"
   ( "ID" NUMBER NOT NULL ENABLE,
  "COL1" VARCHAR2(20 BYTE),
  "COL2" VARCHAR2(20 BYTE),
  "VERSION" NUMBER
   INSERT INTO MAIN_TABLE VALUES (101,'A','B',1);
/*------update version procedure----------*/
DECLARE
  TYPE T_tmp_table IS TABLE OF tmp_table %ROWTYPE INDEX BY PLS_INTEGER;
  TYPE T_main_table IS TABLE OF main_table%ROWTYPE INDEX BY PLS_INTEGER;
  l_tmp_table T_tmp_table;
  l_main_table T_main_table;
  BEGIN
    SELECT * BULK COLLECT INTO l_tmp_table FROM tmp_table;
    SELECT * BULK COLLECT INTO l_main_table FROM main_table;
    FOR i IN 1 .. l_tmp_table.count
    LOOP
      FOR j IN 1 .. l_main_table.count
     LOOP
  if(l_tmp_table(i).ID = l_main_table(j).ID AND l_tmp_table(i).VERSION IS NULL) then     
  ---this first if loop updates temp table version irrespective of l_tmp_table.ID=l_main_table.ID orl_tmp_table. ID<>l_main_table.ID  .it display proper matching and non-matching records.
   dbms_output.put_line('matching ids from tmp and main are :'||l_tmp_table(i).ID||'  '||l_main_table(j).ID);
   UPDATE tmp_table SET VERSION = l_tmp_table(i).version +1;
   --where l_tmp_table(i).ID = l_main_table(j).ID     --
   end if;
  if (l_tmp_table(i).ID <> l_main_table(j).ID) then
   dbms_output.put_line('non matching ids from tmp and main are :'||l_tmp_table(i).ID||'  '||l_main_table(j).ID);
   UPDATE tmp_table SET VERSION = l_tmp_table(i).version +1;
   --where l_tmp_table(i).ID <> l_main_table(j).ID    
    end if;
          END LOOP;
          END LOOP;
    EXCEPTION
    WHEN OTHERS THEN
    DBMS_OUTPUT.PUT_LINE('OTHER');
END;

Answer 1

Hello user8937641
I think there is a problem with the logic of your SQL-Code.
But maybe in this formatted structure you can see where your problem is. -> I can not say it because I do not know what is the requirement.
I hope it helps...
/*------update version procedure----------*/
DECLARE
  TYPE T_tmp_table IS TABLE OF tmp_table %ROWTYPE INDEX BY PLS_INTEGER;
  TYPE T_main_table IS TABLE OF main_table%ROWTYPE INDEX BY PLS_INTEGER;
  l_tmp_table T_tmp_table;
  l_main_table T_main_table;
  BEGIN
    SELECT * BULK COLLECT INTO l_tmp_table FROM tmp_table;
    SELECT * BULK COLLECT INTO l_main_table FROM main_table;
    FOR i IN 1 .. l_tmp_table.count
    LOOP
      FOR j IN 1 .. l_main_table.count
      LOOP
        IF     l_tmp_table(i).ID = l_main_table(j).ID
           AND l_tmp_table(i).VERSION IS NULL
         THEN
             ---this first if loop updates temp table version irrespective of l_tmp_table.ID=l_main_table.ID orl_tmp_table. ID<>l_main_table.ID  .it display proper matching and non-matching records.
             dbms_output.put_line('matching ids from tmp and main are :'||l_tmp_table(i).ID||'  '||l_main_table(j).ID);
             UPDATE tmp_table
                SET version = l_tmp_table(i).version +1;
              WHERE id = l_tmp_table(i).ID
        END IF;
        IF l_tmp_table(i).ID <> l_main_table(j).ID
         THEN
           dbms_output.put_line('non matching ids from tmp and main are :'||l_tmp_table(i).ID||'  '||l_main_table(j).ID);
           -- Maybe you do not need this update:
           UPDATE tmp_table
              SET version = l_tmp_table(i).version +1;
            WHERE id =  l_tmp_table(i).ID
        END IF;
        COMMIT;
       END LOOP;
    END LOOP;
  EXCEPTION WHEN OTHERS THEN
    DBMS_OUTPUT.PUT_LINE('Error at Executing the PLSQL-Block - ' || SQLERRM);
END;