Can you help me with mouse pressed method please?

Question

hi
can you help me with my problem please, player label doesn't show up in the applet and the draw string method it doesn't draw any strings like X or O for the game I don't know what is the problem maybe it is with MousePressed method which is in Board class. I tried to write the code of the location many times I'm not sure if the problem comes from there.
there is no error in my code, but it doesn't work.
this is class Board which has the mouseListener
class Board extends JPanel  implements MouseListener, MouseMotionListener
    private JLabel playerlabel; 
     private boolean play;
     private boolean start;
    private int turn; 
    private Square squares[][];
  private Player myplayer[][];
     public Board()
          setBackground( Color.WHITE );
          playerlabel = new JLabel( "X player first" );
          //playerlabel.setLayout(null);
     //     playerlabel.setLocation(500,500);
          add( playerlabel );
          play = true;
          turn = 1;
         squares = new Square[3][3];
         myplayer = new Player[3][3];
         int x = 40;
          int y = 40;
          for (int i=0; i<3; i++){
               x = 40;
               for (int j=0; j<3; j++){
                    Square s = new Square( x,y );
                    squares[i][j] = s;
                    x +=50;
               y +=50;
            this.addMouseListener(this);
        this.addMouseMotionListener(this);
      public void mouseClicked( MouseEvent event ){}
      public void mouseMoved( MouseEvent event ){}
      public void mouseEntered( MouseEvent event ){}
      public void mouseExited( MouseEvent event ){}
      public void mousePressed( MouseEvent event )
      {int xPos = event.getX();
              int yPos = event.getY();
                if(play && turn ==1){
                for (int i=0; i<3; i++){
                    for (int j=0; j<3; j++){
                         int x = squares[i][j].getX();
                         int y = squares[i][j].getY();
                         if(xPos> x && xPos<x+40&& yPos> y && yPos<y+40){
                              if( squares[i][j].getOccupied() ==0 ){
                                   String ptext;
                                   ptext = "X";
                                   Player p = new Player(x, y,ptext);
                                   myplayer[i][j] = p;
                                   squares[i][j].setOccupied(1);
                                   playerlabel.setText( "O Player Turn" );
                                   turn = 2;
                                   repaint();
                                   Win();
                              else{
                                   turn = 2;
                                   playerlabel.setText( "O Player Turn" );
                                   repaint();
          if ( play && turn ==2 )
for (int i=0; i<3; i++){
                    for (int j=0; j<3; j++){
                         int x = squares[i][j].getX();
                         int y = squares[i][j].getY();
                         if(xPos> x && xPos<x+40&& yPos> y && yPos<y+40){
                              if( squares[i][j].getOccupied() ==0 ){
                                   String ptext;
                                   ptext = "O";
                                   Player p = new Player(x, y,ptext);
                                   myplayer[i][j] = p;
                                   squares[i][j].setOccupied(2);
                                   playerlabel.setText( "X Player Turn" );
                                   turn = 1;
                                   repaint();
                                   Win();
                              else{
                                   turn = 1;
                                   playerlabel.setText( "X Player Turn" );
                                   repaint();
      public void mouseReleased( MouseEvent event )
      public void mouseDragged( MouseEvent event )
     public void Win(){
          if(squares[0][0].getOccupied() == squares[0][1].getOccupied() &&squares[0][1].getOccupied()==squares[0][2].getOccupied() &&squares[0][2].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
          else if (squares[1][0].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[1][2].getOccupied() &&squares[1][2].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
          else      if(squares[2][0].getOccupied() == squares[2][1].getOccupied() &&squares[2][1].getOccupied()==squares[2][2].getOccupied() &&squares[2][2].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
               if(squares[0][0].getOccupied() == squares[0][1].getOccupied() &&squares[0][1].getOccupied()==squares[0][2].getOccupied() &&squares[0][2].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
          else if (squares[1][0].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[1][2].getOccupied() &&squares[1][2].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
          else      if(squares[2][0].getOccupied() == squares[2][1].getOccupied() &&squares[2][1].getOccupied()==squares[2][2].getOccupied() &&squares[2][2].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
          //Vertically win
           if (squares[0][0].getOccupied() == squares[1][0].getOccupied() &&squares[1][0].getOccupied()==squares[2][0].getOccupied() &&squares[2][0].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
          else if (squares[0][1].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[2][1].getOccupied() &&squares[2][1].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
          else      if(squares[0][2].getOccupied() == squares[1][2].getOccupied() &&squares[1][2].getOccupied()==squares[2][2].getOccupied() &&squares[2][2].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
           if (squares[0][0].getOccupied() == squares[1][0].getOccupied() &&squares[1][0].getOccupied()==squares[2][0].getOccupied() &&squares[2][0].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
          else if (squares[0][1].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[2][1].getOccupied() &&squares[2][1].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
          else      if(squares[0][2].getOccupied() == squares[1][2].getOccupied() &&squares[1][2].getOccupied()==squares[2][2].getOccupied() &&squares[2][2].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
          //Diagonal win
                if (squares[0][0].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[2][2].getOccupied() &&squares[2][2].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
          else if (squares[0][2].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[2][0].getOccupied() &&squares[2][0].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
           if (squares[0][0].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[2][2].getOccupied() &&squares[2][2].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
          else if (squares[0][2].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[2][0].getOccupied() &&squares[2][0].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
     }//end win
public void setTurn(int t)
          turn = t;
          playerlabel.setText( "X Player Plays First" );
     public void paintComponent( Graphics g )
           super.paintComponent( g );
           this.setBackground( Color.WHITE );
          for (int i=0; i<3; i++){
               for (int j=0; j<3; j++){
                    g.setColor( Color.BLACK );
                     g.drawRect( squares[i][j].getX(), squares[i][j].getY(), 50, 50 );     
           for (int i=0; i<3; i++){
               for (int j=0; j<3; j++){
                     myplayer[i][j].draw(g);     
        //End of paintComponent   
}and this is the whole code of my program.
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import java.util.*;
class Player{
     private int xCoordinate;
     private int yCoordinate;
    private String playerText;
  public   Player(int x, int y, String t)
        playerText = t;
        xCoordinate = x;
        yCoordinate = y;
    public void draw(Graphics g)
           g.drawString(playerText,  xCoordinate, yCoordinate);
     public void SetText(String t)
     { playerText = t;
}//end player
class Square
     private int x;
     private int y;
     private int occupied;
     public Square(int x1, int y1)
          x = x1;
          y= y1;
          occupied = 0;
     public void setX(int x1)
          x = x1;
     public int getX()
          return x;
     public void setY(int y1)
          y = y1;
     public int getY()
          return y;
     public void setOccupied(int o)
          occupied = o;
     public int getOccupied()
          return occupied;
public class TicTac extends JApplet implements ActionListener
{ private JPanel panel;
     private JButton newgame;
     private Board B;
     public void init()
          B = new Board();
          add( B, BorderLayout.CENTER );
          panel = new JPanel();
           newgame = new JButton( "New Game" );
           panel.add( newgame);
           add( panel, BorderLayout.SOUTH );
           newgame.addActionListener(this);
          public void actionPerformed( ActionEvent ev)
           {     Object source = ev.getSource();
     if (source == newgame)
                {remove(B);
               repaint();
          B = new Board();
               add( B, BorderLayout.CENTER );
     B.setTurn(1);
               repaint();
               validate();
        }//end class TicTac
class Board extends JPanel  implements MouseListener, MouseMotionListener
    private JLabel playerlabel; 
     private boolean play;
     private boolean start;
    private int turn; 
    private Square squares[][];
  private Player myplayer[][];
     public Board()
          setBackground( Color.WHITE );
          playerlabel = new JLabel( "X player first" );
          //playerlabel.setLayout(null);
     //     playerlabel.setLocation(500,500);
          add( playerlabel );
          play = true;
          turn = 1;
         squares = new Square[3][3];
         myplayer = new Player[3][3];
         int x = 40;
          int y = 40;
          for (int i=0; i<3; i++){
               x = 40;
               for (int j=0; j<3; j++){
                    Square s = new Square( x,y );
                    squares[i][j] = s;
                    x +=50;
               y +=50;
            this.addMouseListener(this);
        this.addMouseMotionListener(this);
      public void mouseClicked( MouseEvent event ){}
      public void mouseMoved( MouseEvent event ){}
      public void mouseEntered( MouseEvent event ){}
      public void mouseExited( MouseEvent event ){}
      public void mousePressed( MouseEvent event )
      {int xPos = event.getX();
              int yPos = event.getY();
                if(play && turn ==1){
                for (int i=0; i<3; i++){
                    for (int j=0; j<3; j++){
                         int x = squares[i][j].getX();
                         int y = squares[i][j].getY();
                         if(xPos> x && xPos<x+40&& yPos> y && yPos<y+40){
                              if( squares[i][j].getOccupied() ==0 ){
                                   String ptext;
                                   ptext = "X";
                                   Player p = new Player(x, y,ptext);
                                   myplayer[i][j] = p;
                                   squares[i][j].setOccupied(1);
                                   playerlabel.setText( "O Player Turn" );
                                   turn = 2;
                                   repaint();
                                   Win();
                              else{
                                   turn = 2;
                                   playerlabel.setText( "O Player Turn" );
                                   repaint();
          if ( play && turn ==2 )
for (int i=0; i<3; i++){
                    for (int j=0; j<3; j++){
                         int x = squares[i][j].getX();
                         int y = squares[i][j].getY();
                         if(xPos> x && xPos<x+40&& yPos> y && yPos<y+40){
                              if( squares[i][j].getOccupied() ==0 ){
                                   String ptext;
                                   ptext = "O";
                                   Player p = new Player(x, y,ptext);
                                   myplayer[i][j] = p;
                                   squares[i][j].setOccupied(2);
                                   playerlabel.setText( "X Player Turn" );
                                   turn = 1;
                                   repaint();
                                   Win();
                              else{
                                   turn = 1;
                                   playerlabel.setText( "X Player Turn" );
                                   repaint();
      public void mouseReleased( MouseEvent event )
      public void mouseDragged( MouseEvent event )
     public void Win(){
          if(squares[0][0].getOccupied() == squares[0][1].getOccupied() &&squares[0][1].getOccupied()==squares[0][2].getOccupied() &&squares[0][2].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
          else if (squares[1][0].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[1][2].getOccupied() &&squares[1][2].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
          else      if(squares[2][0].getOccupied() == squares[2][1].getOccupied() &&squares[2][1].getOccupied()==squares[2][2].getOccupied() &&squares[2][2].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
               if(squares[0][0].getOccupied() == squares[0][1].getOccupied() &&squares[0][1].getOccupied()==squares[0][2].getOccupied() &&squares[0][2].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
          else if (squares[1][0].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[1][2].getOccupied() &&squares[1][2].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
          else      if(squares[2][0].getOccupied() == squares[2][1].getOccupied() &&squares[2][1].getOccupied()==squares[2][2].getOccupied() &&squares[2][2].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
          //Vertically win
           if (squares[0][0].getOccupied() == squares[1][0].getOccupied() &&squares[1][0].getOccupied()==squares[2][0].getOccupied() &&squares[2][0].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
          else if (squares[0][1].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[2][1].getOccupied() &&squares[2][1].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
          else      if(squares[0][2].getOccupied() == squares[1][2].getOccupied() &&squares[1][2].getOccupied()==squares[2][2].getOccupied() &&squares[2][2].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
           if (squares[0][0].getOccupied() == squares[1][0].getOccupied() &&squares[1][0].getOccupied()==squares[2][0].getOccupied() &&squares[2][0].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
          else if (squares[0][1].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[2][1].getOccupied() &&squares[2][1].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
          else      if(squares[0][2].getOccupied() == squares[1][2].getOccupied() &&squares[1][2].getOccupied()==squares[2][2].getOccupied() &&squares[2][2].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
          //Diagonal win
                if (squares[0][0].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[2][2].getOccupied() &&squares[2][2].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
          else if (squares[0][2].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[2][0].getOccupied() &&squares[2][0].getOccupied() == 1)
          {playerlabel.setText("Player 1 X WON THE GAME!");
          play =false;          }
           if (squares[0][0].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[2][2].getOccupied() &&squares[2][2].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
          else if (squares[0][2].getOccupied() == squares[1][1].getOccupied() &&squares[1][1].getOccupied()==squares[2][0].getOccupied() &&squares[2][0].getOccupied() == 2)
          {playerlabel.setText("Player 2 O WON THE GAME!");
          play =false;          }
     }//end win
public void setTurn(int t)
          turn = t;
          playerlabel.setText( "X Player Plays First" );
     public void paintComponent( Graphics g )
           super.paintComponent( g );
           this.setBackground( Color.WHITE );
          for (int i=0; i<3; i++){
               for (int j=0; j<3; j++){
                    g.setColor( Color.BLACK );
                     g.drawRect( squares[i][j].getX(), squares[i][j].getY(), 50, 50 );     
           for (int i=0; i<3; i++){
               for (int j=0; j<3; j++){
                     myplayer[i][j].draw(g);     
        //End of paintComponent   
        Edited by: mshadows on May 18, 2008 7:53 AM

Answer 1

I was playing with this a little bit and came up with this game model, something that I'm sure can be improved upon greatly:
TttXO.java
an enum to encapsulate X vs O. I could use a boolean here since it has 2 states, but this seems more intuitive to me
package dy08.m05.ttt;
* tic tac toe encapsulation of X vs O
* @author Pete
public enum TttXO
    X, O
}TttCell.java
encapsulates an individual cell in the tictactoe grid.
package dy08.m05.ttt;
* Tic Tac Toe Game cell
* can be occupied or not
* can hold TttXO X or O or null 
* @author Pete
public class TttCell
    private boolean occupied = false;
    private TttXO xo = null;
    public TttCell()
     * sets a Square for either x or o
     * @param TttXO
     * @return true if successful, false if already occupied
    public boolean setXO(TttXO xo)
        if (occupied)
            return false;
        else
            occupied = true;
            this.xo = xo;
            return true;
    public void reset()
        occupied = false;
        xo = null;
    public boolean isOccupied()
        return occupied;
    public TttXO getXO()
        return xo;
    // used to test and debug the class
    public String toString()
        if (occupied)
            return xo.toString();
        else
            return "-";
package dy08.m05.ttt;
* Tic Tac Toe game model
* @author Pete
public class TttGameModel
    private TttCell[][] cellGrid = new TttCell[3][3];
    private boolean xTurn = true;
    private boolean win = false;
    public TttGameModel()
        for (int i = 0; i < cellGrid.length; i++)
            for (int j = 0; j < cellGrid.length; j++)
cellGrid[i][j] = new TttCell();
public void reset()
xTurn = true;
win = false;
for (int i = 0; i < cellGrid.length; i++)
for (int j = 0; j < cellGrid[i].length; j++)
cellGrid[i][j].reset();
public boolean isXTurn()
return xTurn;
public boolean isWin()
return win;
* @param row
* @param col
* @return true if valid move, false if game already over or cell occupied
public boolean takeTurn(int col, int row)
TttXO currentXO = TttXO.O;
TttCell cell = cellGrid[row][col];
if (win)
return false;
if (cell.isOccupied())
return false;
if (xTurn)
currentXO = TttXO.X;
cell.setXO(currentXO);
win = checkWin(col, row, currentXO);
xTurn = !xTurn; // toggle xturn
return true;
public boolean checkWin(int col, int row, TttXO xo)
boolean win = false;
// first rows and columns
boolean temp = true;
for (int i = 0; i < 3; i++)
temp &= cellGrid[row][i].getXO() == xo;
win |= temp;
temp = true;
for (int i = 0; i < 3; i++)
temp &= cellGrid[i][col].getXO() == xo;
win |= temp;
if (row == col) // if slash diagonal
temp = true;
for (int i = 0; i < 3; i++)
temp &= cellGrid[i][i].getXO() == xo;
win |= temp;
if (row + col == 2) // if backslash diagonal
temp = true;
for (int i = 0; i < 3; i++)
temp &= cellGrid[i][2 - i].getXO() == xo;
win |= temp;
return win;
// used to test and debug the class
public String toString()
StringBuilder sb = new StringBuilder();
for (int i = 0; i < cellGrid.length; i++)
for (int j = 0; j < cellGrid[i].length; j++)
sb.append(cellGrid[i][j] + " ");
sb.append("\n");
if (win)
sb.append("win! Game over");
else
sb.append("No winner yet");
return sb.toString();
// test the class
public static void main(String[] args)
TttGameModel model = new TttGameModel();
checkMove(model, 0, 0);
checkMove(model, 1, 0);
checkMove(model, 1, 1);
checkMove(model, 2, 0);
checkMove(model, 1, 0); // bad move
checkMove(model, 2, 2);
// to test the class
private static void checkMove(TttGameModel model, int i, int j)
System.out.println("OK move: " + model.takeTurn(i, j));
System.out.println(model + "\n");