Database connection is not closing in the database pool

Question

Hi,
i am using tomcat 6.0 and mysql 5.0 database server
and implementing the DBCP in my application
and my context.xml is this
<Resource name="jdbc/racecourse" auth="Container" type="javax.sql.DataSource"
factory="org.apache.tomcat.dbcp.dbcp.BasicDataSourceFactory"
maxActive="200" maxIdle="10" maxWait="1000" removeAbandoned="true" removeAbandonedTimeout="300" logAbandoned="true"
username="betting" password="race" driverClassName="com.mysql.jdbc.Driver"
url="jdbc:mysql://localhost:3306/betting?autoReconnect=true"
description="race"/>
My problem is the connections in the mysql server are becoming idle instead of closing . due to this i am getting connection error 
please help me how to slove this error
try { DataSource ds = null;     Context context = new InitialContext(); Context envCtx = (Context) context.lookup("java:comp/env"); ds =  (DataSource)envCtx.lookup("jdbc/racecourse"); if (ds != null) { cons = ds.getConnection(); } String query3="select max(meetingdate) from meeting"; Statement st3= cons.createStatement(); ResultSet rs3=st3.executeQuery(query3); String srno45=""; while(rs3.next()) {   srno45=rs3.getString(1); } String query="select callcount from callcounter where dateofrace='"+srno45+"'"; Statement stat = cons.createStatement(); ResultSet rs =stat.executeQuery(query); String a=""; int i=1; String cc1="1"; while(rs.next()) { a=rs.getString(1); i=Integer.parseInt(a); //Integer b=new Integer(i); i++; cc1=Integer.toString(i); } session.setAttribute("b123",cc1); String query1="update callcounter set callcount='"+cc1+"' where dateofrace='"+srno45+"'"; Statement stat1 = cons.createStatement(); stat1.executeUpdate(query1); cons.close(); } catch(Exception e) { out.println("saleaction"+e); } finally { try {           if (cons != null)             cons.close();         } catch (SQLException e3) { System.out.println("saleaction"+e3); } } }

Answer 1

i am declaring on the top of the try block
connection cons=null;
try
          DataSource ds = null;
           Context context = new InitialContext();
            Context envCtx = (Context) context.lookup("java:comp/env");
            ds =  (DataSource)envCtx.lookup("jdbc/racecourse");
           if (ds != null)
                     cons = ds.getConnection();
           String query3="select max(meetingdate) from meeting";
           Statement st3= cons.createStatement();
           ResultSet rs3=st3.executeQuery(query3);
           String srno45="";
           while(rs3.next())
            srno45=rs3.getString(1);
          String query="select callcount from callcounter where dateofrace='"+srno45+"'";
          Statement stat = cons.createStatement();
           ResultSet rs =stat.executeQuery(query);
          String a="";
          int i=1;
          String cc1="1";               
               while(rs.next())
                a=rs.getString(1);
                i=Integer.parseInt(a);
                //Integer b=new Integer(i);
                i++;
                cc1=Integer.toString(i);
               session.setAttribute("b123",cc1);
               String query1="update callcounter set callcount='"+cc1+"' where dateofrace='"+srno45+"'";
          Statement stat1 = cons.createStatement();
          stat1.executeUpdate(query1);
          cons.close();
          catch(Exception e)
          out.println("saleaction"+e);
     finally
          try {
          if (cons != null)
            cons.close();
        } catch (SQLException e3)
               System.out.println("saleaction"+e3);
     }