Function Does Not Return any value .

Question

Hi ,
I am wrtting the below funtion without using any cursor to return any message if the value enters by parameters
does not match with the value reterived by the function select statement or it does not reterive any value that
for the parameters entered .
E.g:
CREATE OR REPLACE FUNCTION TEST_DNAME
(p_empno IN NUMBER,p_deptno IN NUMBER)
RETURN VARCHAR2
IS
v_dname varchar2(50);
v_empno varchar2(50);
V_err varchar2(100);
v_cnt NUMBER := 0;
BEGIN
SELECT d.dname,e.empno
INTO v_dname ,v_empno
FROM scott.emp e , scott.dept d
WHERE e.empno=p_empno
AND d.deptno=p_deptno;
--RETURN v_dname;
IF p_empno IS NOT NULL AND p_deptno IS NOT NULL
THEN IF v_dname is NULL THEN
v_err :='Not Valid';
RETURN v_err;END IF;
ELSIF p_empno IS NOT NULL AND p_deptno IS NOT NULL
THEN IF v_dname is NOT NULL THEN
RETURN v_dname; END IF;
ELSE
RETURN v_dname;
END IF;
END;
Sql Statement
SELECT TEST_DNAME(1234,30) FROM dual
AND IF I enter a valid combination of parameter then I get the below error :
e.g:
SQL> SELECT TEST_DNAME(7369,20) FROM dual
2 .
SQL> /
SELECT TEST_DNAME(7369,20) FROM dual
ERROR at line 1:
ORA-06503: PL/SQL: Function returned without value
ORA-06512: at "SCOTT.TEST_DNAME", line 24
Where I am missing .
Thanks,

Answer 1

Format you code properly and look at it:
CREATE OR REPLACE
   FUNCTION TEST_DNAME(
                       p_empno IN NUMBER,
                       p_deptno IN NUMBER
    RETURN VARCHAR2
    IS
        v_dname varchar2(50);
        v_empno varchar2(50);
        V_err varchar2(100);
        v_cnt NUMBER := 0;
    BEGIN
        SELECT  d.dname,
                e.empno
          INTO  v_dname,
                v_empno
          FROM  scott.emp e,
                scott.dept d
          WHERE e.deptno=d.deptno
            AND e.empno=p_empno
            AND d.deptno=p_deptno;
        --RETURN v_dname;
        IF p_empno IS NOT NULL AND p_deptno IS NOT NULL
          THEN
            IF v_dname is NULL
              THEN
                v_err :='Not Valid';
                RETURN v_err;
            END IF;
        ELSIF p_empno IS NOT NULL AND p_deptno IS NOT NULL
          THEN
            IF v_dname is NOT NULL
              THEN
                RETURN v_dname;
            END IF;
         ELSE
           RETURN v_dname;
       END IF;
END;
/Both p_empno and p_deptno in
SELECT TEST_DNAME(7369,20) FROM dualare not null. So SELECT will fetch some v_dname and v_empno. Since p_empno and p_deptno iare not null your code will go inside outer IF stmt and will execute its THEN branch. That branch consist of nothing but inner IF statement. And since v_dname is NOT NULL it will bypass that inner IF and exit the outer IF. And there is no RETURN stmt after that outer IF. As a result you get what you get - ORA-06503. Also, both if and elsif in your code check same set of conditions which makes no sense.
SY.