Help with scheduling Process Flows in Workflow in 10gR2

Dear All
I am after some help with the scheduling of process flows (PF) in Workflow in OWB 10gR2. I am trying to set up some PF’s to handle the refresh of some staging tables from various source systems. I have created a separate Process Flow Module for each source systems, mainly just to keep them separate and organised. I have a number of mappings which all run fine if execute manually or linked directly to a schedule/job. The problem I am encountering is when I try to run process flows from schedules. I have created process flows ok and have run them manually and they complete fine so I know that the content of the PF is ok. After linking and deploying the jobs I can never get all the process flows to run from the various schedules. What appears to happen is that the first PF works ok and any other PF that are within the same Process Flow Module/packages also runs ok even if its running off as different schedules. However PF’s under the other Process Flow Module fail with the following error
CC_DAILY_0400
Description :
Runtime User : OWBRT_USER
Started : 2006-08-31 04:00:00.0
Status      Log
Error      ORA-20002: 3114: Activity 'PACK_1/CC_DAILY_0400' is not a process.
ORA-06512: at "OWF_MGR.WF_ENGINE", line 3920
ORA-06512: at line 1
Following this error the PF will not even run manually! If I then stop the schedule and either drop or replace this failed PF thus redeploying, the PF then runs fine manually and if the restart the schedule it runs ok the next evening. My problem is that this then appears to impact on the other PF’s which all though have not been touched and ran ok the previous evening they then fail the following evening with the same error
WS_DAILY_2400
Description :
Runtime User : OWBRT_USER
Started : 2006-09-01 00:00:01.0
Status      Log
Error      ORA-20002: 3114: Activity 'PACK_1/WS_DAILY_2400' is not a process.
ORA-06512: at "OWF_MGR.WF_ENGINE", line 3920
ORA-06512: at line 1
ORA-20002: 3114: Activity is not a process.
I basically can not get both sets to run even though they are on separate modules and separate schedules.Has anyone any idea as to what could be wrong or if I am setting something up in a strange way which would cause these symptoms.
All help or advice greatly appreciated
Regards Kevin

Dear All
I am after some help with the scheduling of process flows (PF) in Workflow in OWB 10gR2. I am trying to set up some PF’s to handle the refresh of some staging tables from various source systems. I have created a separate Process Flow Module for each source systems, mainly just to keep them separate and organised. I have a number of mappings which all run fine if execute manually or linked directly to a schedule/job. The problem I am encountering is when I try to run process flows from schedules. I have created process flows ok and have run them manually and they complete fine so I know that the content of the PF is ok. After linking and deploying the jobs I can never get all the process flows to run from the various schedules. What appears to happen is that the first PF works ok and any other PF that are within the same Process Flow Module/packages also runs ok even if its running off as different schedules. However PF’s under the other Process Flow Module fail with the following error
CC_DAILY_0400
Description :
Runtime User : OWBRT_USER
Started : 2006-08-31 04:00:00.0
Status      Log
Error      ORA-20002: 3114: Activity 'PACK_1/CC_DAILY_0400' is not a process.
ORA-06512: at "OWF_MGR.WF_ENGINE", line 3920
ORA-06512: at line 1
Following this error the PF will not even run manually! If I then stop the schedule and either drop or replace this failed PF thus redeploying, the PF then runs fine manually and if the restart the schedule it runs ok the next evening. My problem is that this then appears to impact on the other PF’s which all though have not been touched and ran ok the previous evening they then fail the following evening with the same error
WS_DAILY_2400
Description :
Runtime User : OWBRT_USER
Started : 2006-09-01 00:00:01.0
Status      Log
Error      ORA-20002: 3114: Activity 'PACK_1/WS_DAILY_2400' is not a process.
ORA-06512: at "OWF_MGR.WF_ENGINE", line 3920
ORA-06512: at line 1
ORA-20002: 3114: Activity is not a process.
I basically can not get both sets to run even though they are on separate modules and separate schedules.Has anyone any idea as to what could be wrong or if I am setting something up in a strange way which would cause these symptoms.
All help or advice greatly appreciated
Regards Kevin

Similar Messages

  • Scheduled process flows are not running automaticaly-OWB database clonning

    What I did:
    1.     Cloned the entire OWB repository database from live (bidb01.bh.xyz.com) server to new (green1.bh.xyz.com) server.
    ******     Source     New
    Physical Hostname     bidb01.bh.xyz.com     green1.bh.xyz.com
    DB Logical Hostname     xyzbidb      bidb-lh
    Service Name     BIPROD     BIPROD
    Listener Port     1521     1521
    Oracle Home of RDBMS     /app/oracle/home/product/10.2.0     /orabidb/oracle/product/10.2.0
    Oracle Home of OWB     /app/oracle/home/product/10.2.0/owb /orabidb/oracle/product/10.2.0/owb
    2.     Followed the Metalink Note 434272.1 (How To Update Warehouse Builder After A Database Cloning)
    Issue:
    Before doing the step-2, every time we put the new database up the normal process flows which run every day (10 AM, 1 AM , 2 AM , 2 PM, etc.) got executed on the production environment and hung the original processes that are being run on the production environment.
    After following the note 434272, scheduled process flows in production is working fine but in the new server it is not at all working.
    Could anyone please help me to fix this?
    Edited by: Padmanaban G on May 7, 2010 5:15 PM

    The issue was resolved by renaming the workflow. What is learned here is, we should not have same workflow name for two different workspace.

  • Scheduling process flows and mappings

    Hello
    I have created many process flows. Now i want to schedule it. I know i can use OEM, but i need to log in as DBA. i also know that you can use owb scheduler module to schedule a process flow. but i want to schedule it using sql plus. i found a link on scheduling process flow in sql plus for older versions of OWB. Can we use the same script for OWB 10.2? here is the link - http://www.dba-oracle.com/oracle_news/2005_7_7_Scheduling_an_OWB.htm
    Please let me know how to schedule a process flow in OWB 10.2 in sql plus. It would be great if you could post the sql script required to schedule OWB 10.2 process flows.
    Thank You

    Hi,
    the web server named by the link is down, so a general answer.
    You can use the scripts sqlplus_exec_template.sql and oem_exec_template.sql from the directory <OWBHOME>/owb/rtp/sql and schedule it with cron or at or scheduler or ...
    Regards
    Detlef

  • Scheduled process flow fails, run directly works ok

    I've got a hard time with a process flow tthat needs to be scheduled.
    When I start the process flow with wb_rt_api_exec it rus ok,
    when I schedule the job calling wb_rt_api_exec in the Oracle Job scheduler it fails the moment it starts. The error message tells me I've got invalid user credentials, I cannot acces the wokflow location with the supplied userid and password.
    It's the same user to schedule the job as the one that starts wb_rt_api_exec directly.
    What can be rwrong?

    Hi,
    I have not used oracle job scheduler but just a taught....If ur id is able to access the package to execute the processflow that does not mean that the same id has the rights to do such actions thru a oracle job scheduler right?hope this leads to something...Do let me know any details reagrding the same....
    Regards
    Bharath

  • Scheduling Process flows in scheduling tool Control M

    Hi,
    We need to schedule 3 to 4 process flows through the general scheduling tool "Control M". So how do we do this? I mean where should we login to run the OWB jobs (Process Flows) through Control M.
    Any help will be appreciated.
    Thanks,
    Harsha

    Create a shell script that will take in the required parameters you need (i.e.connection User/pwd@SID and OWB mapping inputs if required), which call sqlplus with a procedure that will run your workflow.
    My current client migrates all OWB incl Worflows created through OWB by the means of export. This is why the prefix of the workflow activity will differ from an environment from another.
    Here is a procedure that will launch the OWF and wait for the workflow to be completed before it exits and return control to CONTROL-M.
    CREATE OR REPLACE PROCEDURE XX_OWF_Daily_Load (
    ATTR01 IN VARCHAR2(10),
    ATTR02 IN VARCHAR2(10),
    ATTR03 IN VARCHAR2(10),
    ATTR04 IN VARCHAR2(10),
    ATTR05 IN VARCHAR2)
    IS
    v_ITEM_KEY VARCHAR2(40);
    v_PREFIX VARCHAR2(4);
    v_ITEM_TYPE VARCHAR2(8):= 'MY_ITEM';
    v_PROCESS VARCHAR2(32):='MY_ITEM_KEY';
    /*Mapping Inputs for OWB */
    v_ATTRIBUTETXT01 VARCHAR2(1):='ATTR01';
    v_ATTRIBUTETXT02 VARCHAR2(1):='ATTR02';
    v_ATTRIBUTETXT03 VARCHAR2(1):='ATTR03';
    v_ATTRIBUTETXT04 VARCHAR2(1):='ATTR04';
    v_ATTRIBUTETXT05 VARCHAR2(1):='ATTR01';
    v_STATUS VARCHAR2(30):='RUNNING';
    BEGIN
    /* Generate a unique key */
    SELECT 'DAILY_PROCESS'||TO_CHAR(SYSDATE,'YYYYMMDD:HH24MI') INTO v_ITEM_KEY FROM DUAL;
    SELECT TRIM(TEXT_DEFAULT)||'_' INTO v_PREFIX
    FROM WF_ACTIVITY_ATTRIBUTES_VL
    WHERE
    ACTIVITY_ITEM_TYPE = 'MY_ITEM'
    AND ACTIVITY_NAME = 'MY_ITEM_KEY'
    AND NAME = 'SYS:TLA';
    /* Creating the Workflow Process */
    Wf_Engine.createprocess(ItemType => v_ITEM_TYPE,
    ItemKey => v_ITEM_KEY,
    process => v_PROCESS);
    /* Setting all required attributes for the Workflow Process */
    Wf_Engine.SETITEMATTRTEXT(ItemType => v_ITEM_TYPE,
    ItemKey => v_ITEM_KEY,
    AName => v_PREFIX || 'LOAD_WORKAREA_POLICY',
                                  AValue => v_ATTRIBUTETXT01);
    Wf_Engine.SETITEMATTRTEXT(ItemType => v_ITEM_TYPE,
    ItemKey => v_ITEM_KEY,
    AName => v_PREFIX || 'LOAD_WORKAREA_TR_POLICY',
                                  AValue => v_ATTRIBUTETXT02);
    Wf_Engine.SETITEMATTRTEXT(ItemType => v_ITEM_TYPE,
    ItemKey => v_ITEM_KEY,
    AName => v_PREFIX || 'LOAD_USER_DIM',
                                  AValue => v_LOAD_USER_DIM);
    Wf_Engine.SETITEMATTRTEXT(ItemType => v_ITEM_TYPE,
    ItemKey => v_ITEM_KEY,
    AName => v_PREFIX || 'LOAD_VEHICLE_DIM',
                                  AValue => v_ATTRIBUTETXT05);
    Wf_Engine.setitemowner(ItemType => v_ITEM_TYPE,
    ItemKey => v_ITEM_KEY,
    Owner => 'OWF_MGR');
    /* Starting the Workflow Process */
    Wf_Engine.startprocess (itemtype => v_ITEM_TYPE,
    itemkey => v_ITEM_KEY);
    WHILE (v_status <> 'COMPLETED')
    LOOP                              
    SELECT ACTIVITY_STATUS INTO v_status
         FROM WF_ITEM_ACTIVITY_STATUSES
    WHERE ITEM_TYPE='MY_ITEM' AND ITEM_KEY=v_ITEM_KEY;
    SYS.DBMS_LOCK.SLEEP(600);
    END LOOP;
    END;
    /

  • How to schedule Process Flow in OWB10gR2 ?

    Hi,
    I have a mapping and a corresponding process flow that has the mapping within. Both the mapping and process flow are deployed successfully and they also execute successfully when executed from control center.
    Now I want to run the process flow daily at 4 am in the morning. I have created a schedule and defined the parameters. Then for the process flow, I have added the schedule to the "Referred Calander". Then in control center I got a new object with _JOB as suffix. I deployed that as well and that was successfull. This implies that I have now a job that is scheduled to run daily at 4 am.
    But the next day when I checked the target table that the mapping (wrapped in the process flow which in turn was scheduled to run at 4 am ) was supposed to insert some records, there was no record at all !!! Seemed to me that the job was not kicked off at all at the specified time.
    I am using --
    OWB client version : 10.2.0.1.31
    OWB repository version : 10.2.0.1.0
    Oracle Workflow Version : 2.6.4.0.0
    Database version : 10g Enterprise edition release 10.2.0.1.0
    Does anyone have any idea how do I make this arrangement running?
    Regards,
    Swagata

    Chino -
    Once you start the job, do you have to leave the "Job Details" window open in order for teh scheduled task to run?
    thanks for the help ....
    txb

  • Problems scheduling process flow

    Using OWB I have create a number of mappings and also a process flow using the defined mappings. All the mappings and the process flow are successfully deployed and can be executed without problems from Deployment Manager. I can even successfully execute my process from OS command line using the sqlplus_exec_template.sql file :
    sqlplus vlad_proiect/vlad@proiect @F:\Oracle\OraWB92\owb\rtp\sql\sqlplus_exec_template.sql vlad_runtime ORACLE_WORK_FLOW PROCESS INCARC "," ","
    where :
    vlad_proiect/vlad my user name and passwd
    proiect my database SID
    vlad_runtime is the Runtime Repository owner
    ORACLE_WORK_FLOW is the location of the process flow
    INCARC is the process name.
    I tried to do the same thing using OEM. I followed the example
    http://otn.oracle.com/products/warehouse/htdocs/oem_scheduling_viewlet_swf.html
    and the indication from WB User guide chapter Scheduling Mappings and Process Flows (13-19) but the scheduled job fails with the following reason :
    VNI-2015 : The Node preferred credentials for the target node are either invalid or do not have sufficient privileges to complete the operation.
    On Windows platforms, the Node credentials specified for the Windows target should have the "Logon as a batch job" privilege.
    I have created the job as follows:
    Tab General
     Job name: TEST
    Selected target: Proiect
    Tab Tasks
    Tasks: Run SQL*Plus script
    Tab Parameters
    Parameters: vlad_runtime ORACLE_WORK_FLOW PROCESS INCARC "," ","
    Override preferred credentials: checked
    User name: vlad_runtime_acc the Runtime Repository access user
    Password: vlad the Runtime Repository acc user passwd
    I have imported the script oem_exec_template.sql
    And in the Preferred credentials (from Configuration->Preferences->Administrator preferences) I set :
    Database : Proiect with user vlad_proiect and my passwd.
    Node : localhost with user vlad_runtime and his passwd.
    Somewhere something is wrong set (or not set at all?) or …?

    Razvan,
    When OEM executes a scheduled job, it will logon to the node (i.e. your machine) as the user that is specified in the preferred credentials of OEM. That user (provided there is one... which is not necessarily default) is an operating system user and must have the 'logon as batch job' privilege. You can set this option (on Windows 2000) by going into control panel, administrative tools, local security policy, local policies, user rights assignment. Look for 'logon as batch job' and make sure the user being used to logon to the node has the privilege.
    This setup is actually provided in the installation guide as well.
    Hope this helps,
    Mark.

  • Work schedule Process flow

    Hi All,
    can any of you have sample process flow for Creating a work schedule.
    Just to show how it floows,not based on client reqt's.
    Could any one of you help me out.
    Thanks,
    Lasya

    Hi Lasya...
    Here is the process...
    1. Public Holiday creation (Holiday classes are important here...b, 1, 2, 3 to 9)
    2. Assigning them to Holiday Calendar
    3. Creating break schedule...for the break timings
    4. Creating Rules for variants for special cases like half days and PH's
    5. Creating a Work Schedule...to define the working times of an employee
    6. Creating a Period Work schedule....to define the week with the help of work schedules
    7. Defining selections rules...to define the day (Day types,,,b, 1, 2, and 3 to 9)
    8. Defining Groupings...to define diff emp and diff personnel areas
    9. Generating the work schedules to get the calendar for employee/s (either by manual process or batch)
    Regards
    Vijay

  • Process Flow and Workflow

    Hi experts, does a process flow cannot be used if we dont have oracle workflow?
    If yes, any of you know the alternative ways to run a schedule mapping sequentially?
    Currently i am running schedule from OWB (Control center manager). And i am not satisfied because the lack of Log / information regarding the job execution. Is there a way to get more detail schedule job logs???
    Thank you in advance guys...

    Oracle is pretty smart when it comes to those things, Im sure the table is not lock because one session is DML:ing it and one is querying it. You can get a deadlock when the sessions are trying to DML for the same row, because update/insert/delete is based on row lock, not table lock.
    What you can do to test these kinds of long operation mappings is to generete the intermediate code from the map - open the map editor and click on genereate - choose intermediate from the dropdown list and click on your target table. Copy that code and run it from i.e toad, do the same thing instantly for the other map and you will found out if your sessions are locking each other.
    Because the owb map is bascly configured in a way that it most of it is unnecessery when your are not running it thrue the repository, like I said. Try to run it they way it is - else create a new one by the code generated in the intermediate mapping.
    Cheers

  • OWB process flow & Oracle Workflow

    Hi,
    In order to deploy the OWB process flow packages, is it necessary to have Oracle workflow installed on the Target server? When I tried to deploy a process flow package to the target database (10gR2 db), it required a user called owf_mgr. As far I know, owf_mgr is the admin user for workflow. Can this feature work without OWF being installed?
    Thanks for your help
    regards

    You also might be interested in this thread...
    OWB and Work Flow (being dessuported)
    Just in case you are starting an implementation.

  • Problem with copying Process Flows in OWB 10.2.0.1..

    Hello
    We have a complex process flow which runs fine. When we try to duplicate the process flow in design center by copy/paste operation, the new process flow seems to execute activities out of sequence. We tried saving/synchronizing the process flow (eact activity individually) with no luck.
    We checked the repository browser and see all the activities and transitions in the right order. I looked at both OWB repository tables as well as Workflow tables/views. It just seems that the run time picks up the data in a different order and executes it.
    Any idea on how to debug this?. We can't create each process flow from scratch every time we need to add new one which will be slightly different one from an existing process flow.
    Thanks
    Prakash

    Find and read the thread about when queries take too long.
    Something is different between the systems, possibly
    * indexing
    * volume of data
    * connect-by structure in table data
    * initialization or session settings

  • Scheduling Process flows

    I have created process flow and created and schedule and attached it to the process flow thru configure and refferred calander and depoyed the process flow again. But the flow doesnt start.
    Is there anything else to do. I read in form that some _job appears in Control center. I dont find in my control center.
    Can anyone explain me any other steps which are required to run PF based on schedue.
    Thanks..

    Hi Tom
    You will find pfname_JOB in the control center. if you expand the location under which you created your Schedule, you will see a scheduled jobs tree expand that and then you will find your schduled job( pfname_ JOB) which requires deployment to start running.
    Hope this helps
    Regards
    Vibhuti

  • Scheduling Process Flow

    Hi
    I'm having trouble setting up a schedule in OWB, can anyone help?
    I'm using OWB 10.2.0.3, I've created a Schedule and Process Flow, I've configured the Process Flow so that the REFERRED SCHEDULE property is set. I've redeployed the process flow. So far so good?
    I presume I now need to deploy the scheduled job (so I can start it?), however when I try I get error:
    ORA-27475: "BIR_ROLAP.PF_SS_SCHEDULE_JOB" must be a job
    ORA-06512: at "SYS.DBMS_ISCHED", line 178
    ORA-06512: at "SYS.DBMS_SCHEDULER", line 544
    ORA-06512: at line 1
    PF_SS_SCHEDULE_JOB
    Create
    Error
    RPE-02183: Task runner procedure PPF_SS_SCHEDULE_JOB is not valid.
    Am I missing a step?
    Cheers
    Si

    Check if the foll is done:
    say there is a process flow 'PF1' and in this process flow click on configure and set the referred calendar to the new schedule that you have created.
    also make sure the identification and evaluation locations are setup for the process flow.
    Deploy the process flow.
    This works for me.

  • Help with batch processing

    Hi, I am having trouble with batch processing. I want to apply adaptive noise reduction (ANR) to several files from the same source tapes. So, following the help instructions, I create a script from one file. When I try to apply it to the other files, instead of applying ANR to them, it simply saves them as is. The steps I perform are as follows:
    I select the entire wave (I have also tried it without first selecting)
    I open the scripts box in the file menu
    I click on open/new script collection and create a new script
    I title the new script
    I click 'record'
    I close the scripts box
    I run ANR on the file
    I go back to the scripts box and click 'stop current script'
    I click add to collection
    I close the scripts box
    I open the batch processing box
    I select the files, then the script, then I click to start processing
    When I try to apply this to script to other files, it saves them but doesn't apply ANR.
    Can anyone suggest what I am doing wrong? Also, in the scripts box, there are three options for the type of script that I can create. One is highlighted: 'Scripts start from scratch.' Is that the correct one to use? If not, how do I select one of the others? I click on them but nothing happens. Finally, when creating a script, do I save the file before or after clicking 'stop record'? I have tried it both ways but don't know which is correct (neither seems to make a difference).
    Just to be as thorough as possible, below is the text of one of my scripts, in case that contains any clues. Thanks so much for any and all help!!
    Collection: doubletnr
    Title: d2
    Description:
    Mode: 2
    Undo: 0
    Selected: none at 0 scaled 109479495 SR 44100
    Freq: Off
    cmd: Channel Both
    Selected: 0 to 109479494 scaled 109479495 SR 44100
    Freq: Off
    Comment: Restoration\Adaptive Noise Reduction
    cmd: {EA93BBBE-0B8F-47D6-AC6D-B67B46524E41}
    1: 52,AAA€ÛÚZ€AAQ€ãýÇÛÚÚAAA€Ďč¸āĂ}úƒÓ~ip€k•iëåÁëåÁ
    2:
    3: 13
    4: 0
    5: 0
    6: 3190728
    7: 0
    8: 0
    9: 0
    10: 1
    Freq: Off
    End:

    This is what my script looks like. Although I was worried about the strange characters in the script, it does work.
    Make sure that the script you use is suitable for the sample rate and bit depth of the file. E.g. if you have 44100/32-bit files, then don't use a script that was recorded on a file with e.g. 48000/16-bit. If required, resample or make different scripts for different rates/depths.
    Collection: Test ANR AA Forum
    Title: Test ANR AA Forum
    Description:
    Mode: 4
    Undo: 1
    Selected: 0 to 9233563 scaled 9233563 SR 44100
    Freq: Off
    cmd: Channel Both
    Selected: 0 to 9233563 scaled 9233563 SR 44100
    Freq: Off
    Comment: Restoration\Adaptive Noise Reduction
    cmd: {EA93BBBE-0B8F-47D6-AC6D-B67B46524E41}
    1: 52,AAA€ÛÚZ€AAQ€ãýÇÛÚÚAAA€Ďč¸āĂ}úƒÓ~ip€k•iëåÁëåÁ
    2:
    3: 13
    4: 0
    5: 0
    6: 154705552
    7: 0
    8: 0
    9: 0
    10: 1
    Freq: Off
    End:

  • Urgent help with BPEL process

    Hello there,
    I need help with BPEL project.
    i have created a table Employee in Database.
    I did create application, BPEL project and connection to the database properly using Database Adapter.
    I need to read the records from the database and convert into xml fomat and it should to go approval for BPM worklist.
    Can someone please describe me step by step what i need to do.
    Thanks,
    Dps

    Read the Demo examples given with Oracle BPEL Process Manager.
    I am now at a proficient level in BPEL in the past 1 year,
    still need to reach the excellent mark.
    Thanks & Regards,
    Gopal D. Kalsekar
    Sr. Software Developer
    Business Solutions (eGroup)
    M.H. Alshaya Company W.L.L.
    www.alshaya.com
    Jai Maharashtra
    P :- (965) 224 3598
    F :- (965) 224 2488
    E :- [email protected]

Maybe you are looking for

  • Does Captivate 6 work with IE 11 and Windows 8.1?

    I have a situation where I created a Captivate presentation in Captive 6. The users are using IE 11 and Windows 7 and 8.1. The presentation will not load. Is there a problem with Captivate woring with those OSs and browser? Thanks!

  • What is the keyboard command to restore red, yellow and green buttons to Safari? Thanks, Richard

    Will deleting mail accounts on one laptop delete them from another laptop on the same network? Both laptops are also connected to iCloud. Thanks, Richard

  • How to create a xml object dynamically

    Hi all, In my current project the database is returning the query result in xml string format(using oracle's DBMS-XML package). Now I need to use this xml string and build a xml object and transform it into XSLT and then in a servlet and then pass it

  • Allocate asset balance to other assets - what's the best way

    Hi there, I need to allocate the balance of an asset to multiple assets but this allocation should only impact a single depreciation area.  We have 3 depreciation areas, so the other 2 shouldn't get the allotment.  What is the better way to do this?

  • Passing arguments to case

    Hi, I am trying to run this script as follows; avplaylist -a Music/artist/ or avplaylist -v Videos/tv_show/ and have it create a sorted playlist for me. It works if I make one function for audio and one for video but not this way, what am I doing wro