Logical Problem

Question

I've got a problem with simple vb logic. Not sure what's going on. I can't seem to get this if statement to fire the way I'd expect.
If room.HasFirstVisit = True And String.IsNullOrEmpty(room.FirstVisitDescription) Then
MsgBox("FIRED")
canAddRoom = False
errorList.Add("Room has first visit checked, but no description was given for first visit.")
End If
I've tried
If room.HasFirstVisit = True And room.FirstVisitDescription = "" Then
MsgBox("FIRED")
canAddRoom = False
errorList.Add("Room has first visit checked, but no description was given for first visit.")
End If
I have no idea why this isn't working.

Answer 1

hmm,
Thanks for the demo :) Looks exactly the same as what you've shown, at least logically. Not sure why it didn't work..
Public Sub applycreate_room()
Dim map As cMap = New cMap
Dim mainWindow As MainWindow = New MainWindow
mainWindow = Application.Current.MainWindow
map = mainWindow.return_map()
Dim room As cRoom = New cRoom
Dim canAddRoom As Boolean = False
Dim errorList As List(Of String) = New List(Of String)
''Room's basic info
room.Name = txtRoomName.Text
room.HasFirstVisit = chkHasFirstVisit.IsChecked
rtxFirstVisitDescription.SelectAll()
room.FirstVisitDescription = rtxFirstVisitDescription.Selection.Text
room.FirstVisitDescription = room.FirstVisitDescription.Trim(" ")
rtxRoomDescription.SelectAll()
room.Description = rtxRoomDescription.Selection.Text
''Rooms connected rooms
Dim roomText() As String
room.North = cmboNorthRoom.SelectedItem.ToString()
roomText = room.North.Split(" ")
room.North = roomText(roomText.Count - 1)
roomText = Nothing
room.NorthEast = cmboNorthEastRoom.SelectedItem.ToString()
roomText = room.NorthEast.Split(" ")
room.NorthEast = roomText(roomText.Count - 1)
roomText = Nothing
room.East = cmboEastRoom.SelectedItem.ToString()
roomText = room.East.Split(" ")
room.East = roomText(roomText.Count - 1)
roomText = Nothing
room.SouthEast = cmboSouthEastRoom.SelectedItem.ToString()
roomText = room.SouthEast.Split(" ")
room.SouthEast = roomText(roomText.Count - 1)
roomText = Nothing
room.South = cmboSouthRoom.SelectedItem.ToString()
roomText = room.South.Split(" ")
room.South = roomText(roomText.Count - 1)
roomText = Nothing
room.SouthWest = cmboSouthWestRoom.SelectedItem.ToString()
roomText = room.SouthWest.Split(" ")
room.SouthWest = roomText(roomText.Count - 1)
roomText = Nothing
room.West = cmboWestRoom.SelectedItem.ToString()
roomText = room.West.Split(" ")
room.West = roomText(roomText.Count - 1)
roomText = Nothing
room.NorthWest = cmboNorthWestRoom.SelectedItem.ToString()
roomText = room.NorthWest.Split(" ")
room.NorthWest = roomText(roomText.Count - 1)
roomText = Nothing
room.Up = cmboUpRoom.SelectedItem.ToString()
roomText = room.Up.Split(" ")
room.Up = roomText(roomText.Count - 1)
roomText = Nothing
room.Down = cmboDownRoom.SelectedItem.ToString()
roomText = room.Down.Split(" ")
room.Down = roomText(roomText.Count - 1)
roomText = Nothing
room.InRoom = cmboInRoom.SelectedItem.ToString()
roomText = room.InRoom.Split(" ")
room.InRoom = roomText(roomText.Count - 1)
roomText = Nothing
room.Out = cmboOutRoom.SelectedItem.ToString()
roomText = room.Out.Split(" ")
room.Out = roomText(roomText.Count - 1)
roomText = Nothing
'' remember to code doors.
'' Locked State of connected rooms.
room.isLockedNorth = chkLockNorthDoor.IsChecked
room.IsLockedNorthEast = chkLockNorthEastDoor.IsChecked
room.IsLockedEast = chkLockEastDoor.IsChecked
room.IsLockedSouthEast = chkLockSouthEastDoor.IsChecked
room.IsLockedSouth = chkLockSouthDoor.IsChecked
room.IsLockedSouthWest = chkLockSouthWestDoor.IsChecked
room.IsLockedWest = chkLockWestDoor.IsChecked
room.IsLockedNorthWest = chkLockNorthWestDoor.IsChecked
room.IsLockedIn = chkLockInDoor.IsChecked
room.IsLockedOut = chkLockOutDoor.IsChecked
room.IsLockedUp = chkLockUpDoor.IsChecked
room.IsLockedDown = chkLockDownDoor.IsChecked
''Blocked Text for rooms, text only applys to blocked exits.
rtxNorthBlockedText.SelectAll()
rtxNorthEastBlockedText.SelectAll()
rtxEastBlockedText.SelectAll()
rtxSouthEastBlockedText.SelectAll()
rtxSouthBlockedText.SelectAll()
rtxSouthWestBlockedText.SelectAll()
rtxWestBlockedText.SelectAll()
rtxNorthWestBlockedText.SelectAll()
rtxUpBlockedText.SelectAll()
rtxDownBlockedText.SelectAll()
rtxInBlockedText.SelectAll()
rtxOutBlockedText.SelectAll()
room.NorthBlockedMessage = rtxNorthBlockedText.Selection.Text
room.NorthEastBlockedMessage = rtxNorthEastBlockedText.Selection.Text
room.EastBlockedMessage = rtxEastBlockedText.Selection.Text
room.SouthEastBlockedMessage = rtxSouthEastBlockedText.Selection.Text
room.SouthBlockedMessage = rtxSouthBlockedText.Selection.Text
room.SouthWestBlockedMessage = rtxWestBlockedText.Selection.Text
room.WestBlockedMessage = rtxSouthWestBlockedText.Selection.Text
room.NorthWestBlockedMessage = rtxNorthWestBlockedText.Selection.Text
room.UpBlockedMessage = rtxUpBlockedText.Selection.Text
room.DownBlockedMessage = rtxDownBlockedText.Selection.Text
room.InBlockedMessage = rtxInBlockedText.Selection.Text
room.OutBlockedMessage = rtxOutBlockedText.Selection.Text
'' Room attributes
room.IsDark = chkIsDark.IsChecked
room.CanBeLit = chkCanBeLit.IsChecked
room.IsInside = chkIsInside.IsChecked
room.CanEnemiesEnter = chkEnemiesEnter.IsChecked
room.CanEnemiesLeave = chkEnemiesLeave.IsChecked
'' Test name
If room.Name = "" Then
canAddRoom = False
errorList.Add("Room needs a name.")
End If
If room.HasFirstVisit = True And Not Regex.IsMatch(room.FirstVisitDescription, "\w") Or Not Regex.IsMatch(room.FirstVisitDescription, "\W") Then
MsgBox("FIRED")
canAddRoom = False
errorList.Add("Room has first visit checked, but no description was given for first visit.")
End If
If canAddRoom = True Then
Else
Dim errorLog As roomerrorlog = New roomerrorlog
errorLog.Owner = Me
For Each errorText As String In errorList
Dim errorLabel As Label = New Label
errorLabel.Content = "Error: " + errorText
errorLabel.Margin = New Thickness(0, 4, 0, 0)
errorLog.errorStack.Children.Add(errorLabel)
errorLog.Height = errorLog.Height + 12
Next
errorLog.Show()
End If
End Sub