Need help in optimizing the ABAP code

Question

Hi,
Can anyone help me in optimizing the code. Here the select statement has select within the loop. Need help in optimization.
WHEN '0CO_PC_PCP_03'.
LOOP AT C_T_DATA INTO TBL_KKBW_ITEM.
      W_TABIX = SY-TABIX.
      IF TBL_KKBW_ITEM-CURRENCY_TYPE EQ '20'.
SELECT SINGLE KALNR KALKA KADKY TVERS KADAT KOKRS INTO (W_KALNR, W_KALKA, W_KADKY, W_TVERS,  
                TBL_KKBW_ITEM-COSTING_DATE,
                TBL_KKBW_ITEM-CONTROLLING_AREA)           
                FROM KEKO                                  
                   WHERE KLVAR EQ TBL_KKBW_ITEM-COSTING_VARIANT                              
                    AND  KADKY EQ TBL_KKBW_ITEM-COSTING_DATE
                    AND  TVERS EQ TBL_KKBW_ITEM-COSTING_VERSION                           
                    AND  MATNR EQ TBL_KKBW_ITEM-HEADER_MATERIAL                             
                    AND  WERKS EQ TBL_KKBW_ITEM-HEADER_PLANT.
           IF SY-SUBRC EQ 0.                                
          SELECT SINGLE KOSTL INTO TBL_KKBW_ITEM-COST_CENTER
                          FROM CKIS WHERE KOSTL NE SPACE   
                                     AND  KALNR EQ W_KALNR 
                                     AND  KALKA EQ W_KALKA 
                                     AND  KADKY EQ W_KADKY 
                                     AND  TVERS EQ W_TVERS.
          IF SY-SUBRC NE 0.                                
            CLEAR TBL_KKBW_ITEM-COST_CENTER.               
          ENDIF.                                           
        ENDIF.                                             
        MODIFY C_T_DATA FROM TBL_KKBW_ITEM INDEX W_TABIX.
      ELSE.
        DELETE C_T_DATA INDEX W_TABIX.
      ENDIF.
    ENDLOOP.
Thanks,
Rani.

Answer 1

hi
plz use the below code :
WHEN '0CO_PC_PCP_03'.
SELECT  KALNR KALKA KADKY TVERS KADAT KOKRS INTO it_keko "declare internal table with the mentioned fields
" also select the fields to be used in where condition
FROM KEKO
for all entries in c_t_data
WHERE KLVAR EQ c_t_data-COSTING_VARIANT
AND KADKY EQ c_t_data-COSTING_DATE
AND TVERS EQ c_t_data-COSTING_VERSION
AND MATNR EQ c_t_data-HEADER_MATERIAL
AND WERKS EQ c_t_data-HEADER_PLANT.
"sort the tables on the fields used in where.
IF SY-SUBRC EQ 0.
SELECT  KOSTL "and other fields to be used in where
INTO it _ckis
FROM CKIS
for all entries in c_t_data
WHERE KOSTL NE SPACE "use c_t_data
AND KALNR EQ W_KALNR
AND KALKA EQ W_KALKA
AND KADKY EQ W_KADKY
AND TVERS EQ W_TVERS.
IF SY-SUBRC NE 0.
CLEAR TBL_KKBW_ITEM-COST_CENTER.
ENDIF.
it_data[] = c_t_data. "declare it_data same as the extract structure
delete it_data where CURRENCY_TYPE  NE '20'.
LOOP AT it_data assigning <fs_data>. "use field symbols
read from it_keko into wa_keko
where
KLVAR EQ <fs_data>-COSTING_VARIANT
AND KADKY EQ <fs_data>-COSTING_DATE
AND TVERS EQ <fs_data>-COSTING_VERSION
AND MATNR EQ <fs_data>-HEADER_MATERIAL
AND WERKS EQ<fs_data>-HEADER_PLANT
binary search.
if sy_subrc = 0.
similarly read from the second itab
ENDIF.
ENDLOOP.
c_t_data[] = it_data[].
Pls let me know in case of any issues
Regards,
Aparna
Edited by: Aparna KS on Jun 13, 2010 11:01 PM