Non effective procedure

Question

Hello,
I am using oracle 10g R2 on unix solaris for an extraction purpose.
Anytime I run this process It drags on and on :
a) CREATE OR REPLACE procedure ACT_FRD_EMP.etl_trans_temp1
is
begin
insert into act_frd_emp.etl_trans_tmp
select tran_date
,tran_id
,part_tran_type
,part_tran_srl_num
,trim(tran_id)||trim(part_tran_srl_num)||to_char(tran_date,'ddmmyyyy')||a.sol_id Transaction_Key
,trim(tran_id)||trim(part_tran_srl_num)||to_char(tran_date,'ddmmyyyy')||a.sol_id activity_key
,a.rcre_time Transaction_Date_Time
,case when module_id in ('LA','DD','XGL','DC','BG','FEX','REN','OSP','GA','FFD') then 'FIN'
when tran_particular like 'CASH%' then 'FIN'
when upper(tran_particular) LIKE '%NEFT%' then 'NEFT'
when substr(tran_particular,1,4) = 'FNN/' then 'FINN'
when SUBSTR(TRAN_PARTICULAR,1,4) IN ('VDCC','VPAY') then 'VIS'
when substr(tran_particular,1,3)='BWY' then 'BWAY'
when substr(tran_particular,1,3)='ATM' then 'ATM'
when substr(tran_particular,1,4) = 'ETZ/' then 'ETZ'
when substr(tran_particular,1,3)='FTR' then 'FT'
when SUBSTR(TRAN_PARTICULAR,1,4) = 'ZPAY' then 'ZPAY'
when substr(tran_particular,1,3) in ('ATC','Bul','CIF','CPS','CRF','TUD') then 'DEV'
when SUBSTR(TRAN_PARTICULAR,1,4) = 'MG /' then 'MNG'
when SUBSTR(TRAN_PARTICULAR,1,4) = 'UMO/' then 'UMO' end as Channel_Type_Cd
,tran_type||tran_sub_type as tran_type_cd
,case when a.rcre_user_id = 'SYSTEM' then 1 else 0 end as Automatic_transaction_ind
,a.sol_id Branch_Key
,foracid Account_Key
,tran_amt Amount
,substr(tran_particular ,1,3) reversal
,case when a.pstd_flg ='N' and a.del_flg = 'Y' then 'Y' else 'N' end as Reject_Type_Cd
,a.cust_id
from htd a, gam b
where tran_date > (select last_rundate from status_ind where table_name = 'etl_trans_temp')
AND tran_date <trunc(sysdate - 1)
and a.acid = b.acid
and a.cust_id is not NULL
and a.pstd_flg='Y'
and a.del_flg='N'
and acct_cls_flg <>'Y'
and tran_type = 'T';
commit;
exception
when DUP_VAL_ON_INDEX then
ROLLBACK;
when OTHERS then
NULL;
end;
but when i run this one It gives me the result on time but i cant use the procedure:
b) CREATE OR REPLACE procedure ACT_FRD_EMP.etl_trans_temp1
is
begin
insert into act_frd_emp.etl_trans_tmp
select tran_date
,tran_id
,part_tran_type
,part_tran_srl_num
,trim(tran_id)||trim(part_tran_srl_num)||to_char(tran_date,'ddmmyyyy')||a.sol_id Transaction_Key
,trim(tran_id)||trim(part_tran_srl_num)||to_char(tran_date,'ddmmyyyy')||a.sol_id activity_key
,a.rcre_time Transaction_Date_Time
,case when module_id in ('LA','DD','XGL','DC','BG','FEX','REN','OSP','GA','FFD') then 'FIN'
when tran_particular like 'CASH%' then 'FIN'
when upper(tran_particular) LIKE '%NEFT%' then 'NEFT'
when substr(tran_particular,1,4) = 'FNN/' then 'FINN'
when SUBSTR(TRAN_PARTICULAR,1,4) IN ('VDCC','VPAY') then 'VIS'
when substr(tran_particular,1,3)='BWY' then 'BWAY'
when substr(tran_particular,1,3)='ATM' then 'ATM'
when substr(tran_particular,1,4) = 'ETZ/' then 'ETZ'
when substr(tran_particular,1,3)='FTR' then 'FT'
when SUBSTR(TRAN_PARTICULAR,1,4) = 'ZPAY' then 'ZPAY'
when substr(tran_particular,1,3) in ('ATC','Bul','CIF','CPS','CRF','TUD') then 'DEV'
when SUBSTR(TRAN_PARTICULAR,1,4) = 'MG /' then 'MNG'
when SUBSTR(TRAN_PARTICULAR,1,4) = 'UMO/' then 'UMO' end as Channel_Type_Cd
,tran_type||tran_sub_type as tran_type_cd
,case when a.rcre_user_id = 'SYSTEM' then 1 else 0 end as Automatic_transaction_ind
,a.sol_id Branch_Key
,foracid Account_Key
,tran_amt Amount
,substr(tran_particular ,1,3) reversal
,case when a.pstd_flg ='N' and a.del_flg = 'Y' then 'Y' else 'N' end as Reject_Type_Cd
,a.cust_id
from htd a, gam b
where tran_date ='29-NOV-2011'
--tran_date > (select last_rundate from status_ind where table_name = 'etl_trans_temp')
-- AND tran_date <trunc(sysdate - 1)
and a.acid = b.acid
and a.cust_id is not NULL
and a.pstd_flg='Y'
and a.del_flg='N'
and acct_cls_flg <>'Y'
and tran_type = 'T';
commit;
exception
when DUP_VAL_ON_INDEX then
ROLLBACK;
when OTHERS then
NULL;
end;
NB
In A tran_date > (select last_rundate from status_ind where table_name = 'etl_trans_temp') AND tran_date <trunc(sysdate - 1) is the same as
tran_date ='29-NOV-2011' in B.
please i need to know what i am doing wrong in this code. A can be run anytime without editing the code but B is hard-coded and i cant use it.
Thanks
AbdurRahman

Answer 1

Thread: HOW TO: Post a SQL statement tuning request - template posting
HOW TO: Post a SQL statement tuning request - template posting