Pass RowSet from one class to another

Question

Hi, i am trying to pass a rowset from one class to another but i keep getting the error messages:
method does not return a value
statement not reachable
Does anybody know why?
package project1;
import java.sql.SQLException;
public class readdata {
    public static void main(String[] args) {
        Class2 cl = new Class2();
        try {
        while (cl.openConnection().next()) {
            System.out.println(cl.openConnection().getInt("id") + "-");
        catch (SQLException se)
                System.out.println(se);
       // while (rs.next())
         //       System.out.println(rs.getInt("id") + "-");
         //       System.out.println(rs.getString("field1") + '\n');
package project1;
import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
import javax.sql.RowSet;
public class Class2 {
   private Connection conn;
    public Class2() {
        openConnection();
    public RowSet openConnection()
            try
                    Class.forName("sun.jdbc.odbc.JdbcOdbcDriver").newInstance();
                    conn = DriverManager.getConnection("jdbc:odbc:;DRIVER=Microsoft Access Driver (*.mdb);DBQ=D:\\test.mdb;PWD=","admin","");
                    Statement command = conn.createStatement();
                    RowSet rs = (RowSet)command.executeQuery("select * FROM testing");
                    return rs;
                    System.out.println("Connected To Access");
                    rs.close();
                    conn.close();
            catch (SQLException se)
                    System.out.println(se);
            catch (Exception ex)
                    System.out.println(ex);
}Thanks in advance
Message was edited by:
snipered2003
Message was edited by:
snipered2003

Answer 1

Hi snipered2003
I'm fairly new to java, so check out anything I say.
to me it appears that the code within your try block in the main method of readdata class can never throw a SQLException since the calls are to cl.openConnection() which catches any SQLException and does not throw it.
So one statement not reachable is the statement in the catch blockSystem.out.println(se);Second, the only return statement in your openConnection() method is inside the try block, whic means that if an exception is encountered there will be no RowSet returned by the method.
Secondly, the code in the try block in your Class2.openConnection() after the return statement will also never be reached.
You may need something like    public RowSet openConnection()
        RowSet rs = null;
        try
            Class.forName("sun.jdbc.odbc.JdbcOdbcDriver").newInstance();
            conn = DriverManager.getConnection("jdbc:odbc:;DRIVER=Microsoft Access Driver (*.mdb);DBQ=D:\\test.mdb;PWD=","admin","");
            Statement command = conn.createStatement();
            rs = (RowSet)command.executeQuery("select * FROM testing");
            System.out.println("Connected To Access");
        catch (SQLException se)
            System.out.println(se);
        catch (Exception ex)
            System.out.println(ex);
        return rs;
    }But you will have to check for a null return value in the call to the method.
It also looks like the code in your main method, when these things are ironed out, will run an infinite loop, but I could be wrong on that.
I think (note: think) this part should be        RowSet rs = cl.openConnection()
        if (rs != null) {
            while (rs.next()) {
                System.out.println(rs.getInt("id") + "-");
            rs.close();
        }Anybody please correct me if I am wrong.
And I don't know where the conn.close would fit in this scheme of things.
Cheers, Darryl