Passing parameter to stored procedure from windows form getting error

Question

I've written a procedure which shows the data in a table according to the table flag selected from the windows form. My code is:
--- stored procedure ------
CREATE PROC [dbo].[PROC_SELECT_TABLES]
@TBL_FLAG INT
AS
BEGIN
SET NOCOUNT ON;
IF (@TBL_FLAG = 1)
SELECT * FROM MHT_APPUSER ;
IF (@TBL_FLAG = 2)
SELECT * FROM MHT_ISA11 ;
IF (@TBL_FLAG = 3)
SELECT * FROM MHT_ISA22 ;
SET NOCOUNT OFF;
END
GO
Now, the module for calling the above procedure
namespace DAL;
public class DisplayData
SqlLayer layer = new SqlLayer();
public int tblFlag { get; set; }
public DataTable GetData(int tblFlag)
SqlParameter[] p = new SqlParameter[1];
p[0] = new SqlParameter("@tblFlag", this.tblFlag);
return layer.ExecuteDataSet("PROC_SELECT_TABLES", p).Tables[0];
Now the SQL LAYER, containing the ExecuteDataSet and database connection code:
namespace DAL;
public class SqlLayer
// sql connection code
public DataSet ExecuteDataSet(string commandText, SqlParameter[] sqlParameter)
SqlCommand cmd = new SqlCommand(commandText, this.conn);
cmd.CommandType = CommandType.StoredProcedure;
cmd.Parameters.AddRange(sqlParameter);
SqlDataAdapter sda = new SqlDataAdapter(cmd);
DataSet ds = new DataSet();
sda.Fill(ds);
return ds;
Now the windows form layer:
using DAL;
namespace BookKeepingSystem
public partial class DisplayDataForm : Form
DisplayData view = new DisplayData();
private void GetData()
view.tblFlag = 3;
DataTable dt = view.GetData(view.tblFlag);
dgvDisplayData.DataSource = dt;
public DisplayDataForm()
InitializeComponent();
private void DisplayData_Load(object sender, EventArgs e)
GetData();
private void btnExit_Click(object sender, EventArgs e)
Application.Exit();
When I run the code I got the error:
"Unhandled exception has occurred in your application...
Procedure or function 'PROC_SELECT_TABLES' expects parameter @TBL_FLAG, which was not supplied"
I can not figure what is missing with my code. Please can any one point out please.
Thank You!!!

Answer 1

Try something like this for starting -- do just this procedure to see if it works first.
private DataTable GetDataTable(SqlConnection conn1)
SqlDataAdapter daS1 = new SqlDataAdapter();
daS1.SelectCommand = new SqlCommand();
daS1.SelectCommand.Connection = conn1;
if (conn1.State == ConnectionState.Closed) conn1.Open();
daS1.SelectCommand.CommandType = CommandType.StoredProcedure;
daS1.SelectCommand.CommandText = "yourStoredProcedureName";
daS1.SelectCommand.Parameters.Add("@ParamName", SqlDbType.Int, 4);
DataSet DS1 = new DataSet();
daS1.Fill(DS1, "tbl1");
return DS1.Tables["tbl1"];
Note:  in the CommandText part place the name of your stored procedure.  In the Parameter part put the name of your parameter exactly as it is in the actual stored procedure.  Also, (if you have not done this already) make sure your stored
procedure runs OK -- first -- test out your stored procedure in Sql Server Management Studio.  If the procedure runs OK in SSMS, then try it from you app.  Just create a simple form with one button .  Place GetDataTable() code under
the button and call it something like this:
private void button1_Click(object sender, EventArgs e)
int i = GetDataTbl().Rows.Count;
Console.WriteLine("i is {0}", i);
Rich P