PLSQL table in EXECUTE IMMEDIATE

Question

Hi All,
This is just a sample code.Table name may be changed in next run.
when I run this program ,getting error in EXECUTE IMMEDIATE -" V_FIELDS invalid identifier",Also the way I am doing,that's right?
create table TEMP
col1 VARCHAR2(200),
col2 VARCHAR2(200),
col3 DATE )
DECLARE
v_fields dbms_sql.varchar2a;
v_col_str VARCHAR2(200);
v_insert VARCHAR2(200);
v_idx INTEGER := 0;
v_tab VARCHAR2(30) := 'TEMP';
BEGIN
FOR i IN (SELECT s.column_name, s.data_type
FROM user_tab_cols s
WHERE s.table_name = v_tab
ORDER BY s.column_id)
LOOP
v_col_str := v_col_str || i.column_name || ',';
IF i.data_type = 'DATE'
THEN
v_insert := v_insert || 'TO_DATE(v_fields(' || v_idx || '),' ||
'''MM/DD/YYYY''' || '),';
ELSE
v_insert := v_insert || 'v_fields(' || v_idx || '),';
END IF;
v_idx := v_idx + 1;
END LOOP;
v_insert := '( ' || RTRIM(v_insert, ',') || ' )';
v_col_str := 'INSERT INTO ' || v_tab || ' ( ' || RTRIM(v_col_str, ',') ||
' ) VALUES ';
dbms_output.put_line(v_col_str || v_insert);
v_fields(0) := 1;
v_fields(1) := 'AB';
v_fields(2) := SYSDATE;
EXECUTE IMMEDIATE v_col_str || v_insert;
EXCEPTION
WHEN OTHERS THEN
dbms_output.put_line('Err: ' || SQLERRM);
END;
Thanks,

Answer 1

The dynamic SQL generated is
INSERT INTO TEMP ( COL1,COL2,COL3 ) VALUES ( v_fields(0),v_fields(1),TO_DATE(v_fields(2),'MM/DD/YYYY') ) PL/SQL engine sends this SQL to SQL engine. And guess what, SQL Engine has no clue what v_fields is. Why? because v_fields a private variable defined in a PL/SQL block for which SQL Engine has zero access.
Try this
DECLARE
    v_fields  dbms_sql.varchar2a;
    v_col_str VARCHAR2(200);
    v_insert  VARCHAR2(200);
    v_idx     INTEGER := 0;
    v_tab     VARCHAR2(30) := 'TEMP';
BEGIN
    FOR i IN (SELECT s.column_name, s.data_type
                FROM user_tab_cols s
               WHERE s.table_name = v_tab
               ORDER BY s.column_id)
    LOOP
        v_col_str := v_col_str || i.column_name || ',';
        IF i.data_type = 'DATE'
        THEN
            v_insert := v_insert || 'TO_DATE(:' || v_idx || ',' ||
                        '''MM/DD/YYYY''' || '),';
        ELSE
            v_insert := v_insert || ':' || v_idx || ',';
        END IF;
        v_idx := v_idx + 1;
    END LOOP;
    v_insert  := '( ' || RTRIM(v_insert, ',') || ' )';
    v_col_str := 'INSERT INTO ' || v_tab || ' ( ' || RTRIM(v_col_str, ',') ||
                 ' ) VALUES ';
    v_fields(0) := 1;
    v_fields(1) := 'AB';
    v_fields(2) := to_char(SYSDATE, 'MM/DD/YYYY');
    execute immediate v_col_str || v_insert using v_fields(0), v_fields(1), v_fields(2);
END;
/ I personally don't encourage dynamic SQL. Dynamic SQL is always a pain and a result of bad design.
And the most worst thing, the thing that is terrible than dynamic SQL is this
WHEN OTHERS THEN
dbms_output.put_line('Err: ' || SQLERRM);
END; Whats the logic and possible benefit behind this code? Its NONE. Don't do that, NEVER. WHEN OTHERS without a RAISE is a bug in your code. So never do that. And DBMS_OUTPUT is not the correct way to render error message to user.