Problem displaying windows

Question

This is my first AppleScript Studio app so please be gentle.
part of my script checks to see what applications are running. If there are applications running that shouldn't be then I want an error window to appear. If the check is OK I want a different window to appear. The problem I've got is BOTH windows appear no matter what. I tink I'm heading in the right direction but can some help??
Here's my code:
on clicked theObject
set goodProcs to {"Finder", "Disc Eraser"}
tell application "System Events" to set theProcs to name of every process whose background only is false
repeat with myProc in theProcs
if myProc is not in goodProcs then
-- Display Warning Window
show window "WARNING"
else
show window "Erasing Disc"
end if
end repeat
end clicked

Answer 1

I haven't had much experience with AppleScript, but I think I see the problem. You are running the test against every process. Every time the loop hits a "badProc", it will display the warning, and everytime it hits a "goodProc", it displays the other window.
What you need to do is set some sort of Boolean variable before you run the loop (i.e.: set badProcsRunning to FALSE), then in your loop, have the following:
if myProc is not in goodProcs then
set badProcsRunning to TRUE
end if
Follow that with another if statement AFTER the repeat loop:
if badProcsRunning is TRUE then
show window "WARNING"
else
show window "Erasing Disc"
end if