Query taking too long (database is huge)

Question

Hi ,
Please let me know anybody have any recomentation please find my function:
FUNCTION QueryPatientsByName(p_family_name IN VARCHAR2
,p_gender IN VARCHAR2
,p_given_name IN VARCHAR2
,p_other_given_name IN VARCHAR2
,p_date_of_birth_range_from IN VARCHAR2
,p_date_of_birth_range_to IN VARCHAR2
,p_date_of_death_range_from IN VARCHAR2
,p_date_of_death_range_to IN VARCHAR2
) RETURN REF_CURSOR_TYPE
IS
people REF_CURSOR_TYPE;
BEGIN
OPEN people FOR
SELECT psbr.euid
FROM sbyn_personsbr psbr
WHERE psbr.personid in (
SELECT pmain.personid
FROM sbyn_person_hstsbr pmain
-- restict person to be person who has or did have specified name attributes
WHERE (
pmain.personid IN
(SELECT pinnerb.personid
FROM sbyn_name_hstsbr pinnerb
WHERE UPPER(pinnerb.family_name) LIKE UPPER(p_family_name)
AND (p_given_name IS NULL OR UPPER(pinnerb.given_name) LIKE UPPER(p_given_name))
AND (p_other_given_name IS NULL OR
UPPER(pinnerb.other_given_name) LIKE UPPER(p_other_given_name))
AND pmain.gender LIKE p_gender
--DOB AND DOD CHECK
* @todo need to change AS A FUNCTION INSTEAD OF LENGTHY CODE !
AND (p_date_of_birth_range_from IS NULL OR ( pmain.date_of_birth BETWEEN p_date_of_birth_range_from
AND p_date_of_birth_range_to
OR (LENGTH(pmain.date_of_birth)=c_len_year_month AND pmain.date_of_birth BETWEEN
SUBSTR(p_date_of_birth_range_from,1,c_len_year_month) AND
SUBSTR(p_date_of_birth_range_to,1,c_len_year_month) )
OR (LENGTH(pmain.date_of_birth)=c_len_year AND pmain.date_of_birth BETWEEN
SUBSTR(p_date_of_birth_range_from,1,c_len_year) AND
SUBSTR(p_date_of_birth_range_to,1,c_len_year) ))
AND (p_date_of_death_range_from IS NULL OR ( pmain.date_of_death BETWEEN p_date_of_death_range_from AND
p_date_of_death_range_to
OR (LENGTH(pmain.date_of_death)=c_len_year_month AND pmain.date_of_death BETWEEN
SUBSTR(p_date_of_death_range_from,1,c_len_year_month) AND
SUBSTR(p_date_of_death_range_to,1,c_len_year_month))
OR (LENGTH(pmain.date_of_death)=c_len_year AND pmain.date_of_death between
SUBSTR(p_date_of_death_range_from,1,c_len_year) AND
SUBSTR(p_date_of_death_range_to,1,c_len_year))
RETURN people;
END;

Answer 1

Hello
Using dynamic SQL would seem to be the way forward here. To get rid of the sub queries, you may be able to do something like this...
SELECT
     psbr.euid
FROM
     sbyn_personsbr psbr,
     sbyn_person_hstsbr pmain,
     sbyn_name_hstsbr pinnerb
WHERE
     psbr.personid = pmain.personid
AND
     pinnerb.personid = psbr.personid
AND
     UPPER(pinnerb.family_name) LIKE UPPER(p_family_name)
AND
          p_given_name IS NULL
     OR
          UPPER(pinnerb.given_name) LIKE UPPER(p_given_name)
AND
          p_other_given_name IS NULL
     OR
          UPPER(pinnerb.other_given_name) LIKE UPPER(p_other_given_name)
AND
     pmain.gender LIKE p_gender
AND
          p_date_of_birth_range_from IS NULL
     OR
               pmain.date_of_birth BETWEEN p_date_of_birth_range_from AND p_date_of_birth_range_to
          OR
                    LENGTH(pmain.date_of_birth)=c_len_year_month
               AND
                    pmain.date_of_birth BETWEEN SUBSTR(p_date_of_birth_range_from,1,c_len_year_month) AND SUBSTR(p_date_of_birth_range_to,1,c_len_year_month)
          OR
                    LENGTH(pmain.date_of_birth)=c_len_year
               AND
                    pmain.date_of_birth BETWEEN SUBSTR(p_date_of_birth_range_from,1,c_len_year) AND SUBSTR(p_date_of_birth_range_to,1,c_len_year)
AND
          p_date_of_death_range_from IS NULL
     OR
               pmain.date_of_death BETWEEN p_date_of_death_range_from AND p_date_of_death_range_to
          OR
                    LENGTH(pmain.date_of_death)=c_len_year_month
               AND
                    pmain.date_of_death BETWEEN SUBSTR(p_date_of_death_range_from,1,c_len_year_month) AND SUBSTR(p_date_of_death_range_to,1,c_len_year_month)
          OR
                    LENGTH(pmain.date_of_death)=c_len_year
               AND
                    pmain.date_of_death between SUBSTR(p_date_of_death_range_from,1,c_len_year) AND SUBSTR(p_date_of_death_range_to,1,c_len_year)
     )If you can't use that type of structure for the query, consider changing the
xxx.personid IN(select yyy.personidsubqueries to use
EXISTS(SELECT NULL FROM yyy WHERE yyy.personid = xxx.personidAlso see if you can restructure the tests that you are doing on the dates. Are they date columns? What is it you are trying to achieve with the tests on the dates?
And finally, the tests you are doing on the name columns UPPER(pinnerb.given_name) etc. Unless you have a function index on these columns, oracle will not be able to use any indexes, which may not be a problem if you are accessing the majority of the table, but if you are only dealing with a small subset, this could prove to be very time consuming.
HTH