Quick Migrate Creates a Trigger with Infinite Loop

Question

Quick Migrate did a good job at nicely converting my MS SQL Database to Oracle. The only problem that I have is triggers. I have a table with the companies and when the table is just created and there are no rows in the table, on the very first insert it goes into a constant loop. There is no code I have altered after the migration has been completed.
So, there is:
table: RA_COMPANY
sequence: SEQ_RA_COMPANY_ID
trigger: TRG_RA_COMPANY_ID
table has no rows, trigger has been compiled and sequence hasn't been accessed so on the first insert, the trigger should put 1 into the newly added row. Here is the migration code for the trigger:
CREATE OR REPLACE TRIGGER TRG_RA_COMPANY_ID BEFORE INSERT OR UPDATE ON RA_COMPANY
FOR EACH ROW
DECLARE
v_newVal NUMBER(12) := 0;
v_incval NUMBER(12) := 0;
BEGIN
  IF INSERTING AND :new.ID IS NULL THEN
    SELECT SEQ_RA_COMPANY_ID.NEXTVAL INTO v_newVal FROM DUAL;
    -- If this is the first time this table have been inserted into (sequence == 1)
    IF v_newVal = 1 THEN
      --get the max indentity value from the table
      SELECT max(ID) INTO v_newVal FROM RA_COMPANY;
      v_newVal := v_newVal + 1;
      --set the sequence to that value
      LOOP
           EXIT WHEN v_incval>=v_newVal;
           SELECT SEQ_RA_COMPANY_ID.nextval INTO v_incval FROM dual;
      END LOOP;
    END IF;
   -- assign the value from the sequence to emulate the identity column
   :new.ID := v_newVal;
  END IF;
END;
ALTER TRIGGER TRG_RA_COMPANY_ID ENABLE;
/and on the first insert, the loop that is in the middle will be an infinite loop.
I do need only the inserts and I removed the UPDATE part and the loop itself but I am just wondering why is migration process creating this loop.
thanks

Answer 1

Hi Tridy,
I look into this for you.
I can see that this line
SELECT max(ID) INTO v_newVal FROM RA_COMPANY;
Is going to cause an issue if there are no rows.
I wonder if
SELECT NVL(max(ID),0) INTO v_newVal FROM RA_COMPANY;
Solve the issue?
Ill do some tests latter today and get back to you.
Regards,
Dermot.