What is fault in code?

Question

Hi create or replace
PROCEDURE YILARALIKLI_HARFDAGILIMI  IS
cursor c_basari is
  WITH PIVOT_DATA AS (
SELECT   OA.OGRENCI_NO, DK.HARF_KODU,DA.ACILDIGI_YIL
FROM ders_aktif da,ders_tanim dt,ogrenci_akademik oa,ders_kayit dk
WHERE
      oa.birim like'1521%' and
      (da.acildigi_donem='1'or
      da.acildigi_donem='2')and
      da.ders_kodu like '1521%' and
      (dt.normal_yariyili=1 or
      dt.normal_yariyili=2)and
      dt.ders_kodu=da.ders_kodu and
      da.acilan_ders_no=dk.acilan_ders_no and
      oa.ogrenci_no=dk.ogrenci_no and
      dk.harf_kodu is not null
      SELECT * FROM PIVOT_DATA
     PIVOT(count(distinct ogrenci_no ) SAYI  FOR ACILDIGI_YIL IN(2007,2006,2005,2004,2003));    
BEGIN
FOR I IN c_basari
DBMS_OUTPUT.PUT_LINE(I."2007_SAYI");
      DBMS_OUTPUT.PUT_LINE(I."2006_SAYI");
       DBMS_OUTPUT.PUT_LINE(I."2005_SAYI");
        DBMS_OUTPUT.PUT_LINE(I."2004_SAYI");
         DBMS_OUTPUT.PUT_LINE(I."2003_SAYI");
end loop;
END YILARALIKLI_HARFDAGILIMI;It is correct has not a problem.
But problem occured in following.
create or replace
PROCEDURE DINAMICYILARALIKLIHARFDAGILIM
IS
  SQLCOMMAND VARCHAR2(32767);
  I NUMBER;
BEGIN
SQLCOMMAND := 'cursor c_basari is
  WITH PIVOT_DATA AS (
SELECT   OA.OGRENCI_NO, DK.HARF_KODU,DA.ACILDIGI_YIL
FROM ders_aktif da,ders_tanim dt,ogrenci_akademik oa,ders_kayit dk
WHERE
      oa.birim like 1521% and
      (da.acildigi_donem=1or
      da.acildigi_donem=1)and
      da.ders_kodu like 1521% and
      (dt.normal_yariyili=1 or
      dt.normal_yariyili=2)and
      dt.ders_kodu=da.ders_kodu and
      da.acilan_ders_no=dk.acilan_ders_no and
      oa.ogrenci_no=dk.ogrenci_no and
      dk.harf_kodu is not null      
      SELECT * FROM PIVOT_DATA
     PIVOT(count(distinct ogrenci_no ) SAYI  FOR ACILDIGI_YIL IN(2007,2006,2005,2004,2003));
      BEGIN
     FOR I IN c_basari LOOP
     DBMS_OUTPUT.PUT_LINE(I."2007_SAYI");
      DBMS_OUTPUT.PUT_LINE(I."2006_SAYI");
       DBMS_OUTPUT.PUT_LINE(I."2005_SAYI");
        DBMS_OUTPUT.PUT_LINE(I."2004_SAYI");
         DBMS_OUTPUT.PUT_LINE(I."2003_SAYI");
     END;
      EXECUTE IMMEDIATE SQLCOMMAND ;
      END;what is my marking,punctuation marking errors..
Compile is ok but when running
ORA-00900: invalid SQL statement
ORA-06512: at "OGUBS.DINAMICYILARALIKLIHARFDAGILIM", line 39=>line 39 is before EXECUTE IMMEDIATE SQLCOMMAND
ORA-06512: at line 8

Answer 1

Here's what I came up with. I made it an anonymous block to make testing easier - you can edit it back into a 'create or replace procedure' statement when you get it working.
create or replace procedure dinamicyilaralikliharfdagilim
   ( birimno        in number
   , starting_year  in number )
as
declare
   birimno constant number := 123;
   starting_year constant number := 2000;
   v_maincommand long;
   v_outputcommands long;
begin
   v_maincommand := q'[
declare
   cursor c_basari is
      with pivot_data as
           ( select oa.ogrenci_no
                  , dk.harf_kodu
                  , da.acildigi_yil
             from   ders_aktif da
                  , ders_tanim dt
                  , ogrenci_akademik oa
                  , ders_kayit dk
             where  oa.birim like :b || '%'
             and    (    da.acildigi_donem = '1'
                     or  da.acildigi_donem = '1' )
             and    da.ders_kodu like :b || '%'
             and    (    dt.normal_yariyili = 1
                     or  dt.normal_yariyili = 2 )
             and    dt.ders_kodu = da.ders_kodu
             and    da.acilan_ders_no = dk.acilan_ders_no
             and    oa.ogrenci_no = dk.ogrenci_no
             and    dk.harf_kodu is not null )
   select * from pivot_data
   pivot(count(distinct ogrenci_no) for acildigi_yil in (]';
   for i in 0..4 loop
      v_outputcommands := v_outputcommands ||
      '      dbms_output.put_line(c_cur."'|| (starting_year -i) ||'_SAYI");' || chr(10);
      v_maincommand := v_maincommand || (starting_year -i);
      if i < 4 then
         v_maincommand := v_maincommand || ', ';
      end if;
   end loop;
   v_maincommand := v_maincommand || ') );' || chr(10) ||
   'begin' || chr(10) ||
   '   for c_cur in c_basari loop' || chr(10) ||
   '      dbms_output.put_line(c_cur.harf_kodu);' || chr(10) ||
          v_outputcommands ||
   '   end loop;' || chr(10) ||
   'end;';
   -- execute immediate v_maincommand using birimno, birimno;
   dbms_output.put_line(v_maincommand);
end;I've commented out the EXECUTE IMMEDIATE' because I don't have your tables or data (so I have no idea whether it works), but notice I pass birimno in (twice) as a bind variable, where it will be used in place of the two ':b's. Also notice that careful formatting makes it easier to check.
da.acildigi_donem is compared to '1' twice - is that intended? Also if it's a number it can just be compared to 1 (no quotes) like dt.normal_yariyili below it. Also this construction can be simplified to something like <tt> and dt.normal_yariyili in (1,2)</tt>, which cuts down on the number of brackets etc while meaning the same thing.
dbms_output.put_line is really a debug tool for developers, testers and tech support though, and not much use to business users. If all this procedure does is generate some debug statements, I have to wonder what it's really for.
The dbms_output command gives this:
declare
   cursor c_basari is
      with pivot_data as
           ( select oa.ogrenci_no
                  , dk.harf_kodu
                  , da.acildigi_yil
             from   ders_aktif da
                  , ders_tanim dt
                  , ogrenci_akademik oa
                  , ders_kayit dk
             where  oa.birim like :b||'%'
             and    (    da.acildigi_donem = '1'
                     or  da.acildigi_donem = '1' )
             and    da.ders_kodu like :b||'%'
             and    (    dt.normal_yariyili = 1
                     or  dt.normal_yariyili = 2 )
             and    dt.ders_kodu = da.ders_kodu
             and    da.acilan_ders_no = dk.acilan_ders_no
             and    oa.ogrenci_no = dk.ogrenci_no
             and    dk.harf_kodu is not null )
      select * from pivot_data
      pivot(count(distinct ogrenci_no) for acildigi_yil in (2000, 1999, 1998, 1997, 1996) );
begin
   for c_cur in c_basari loop
      dbms_output.put_line(c_cur.harf_kodu);
      dbms_output.put_line(c_cur."2000_SAYI");
      dbms_output.put_line(c_cur."1999_SAYI");
      dbms_output.put_line(c_cur."1998_SAYI");
      dbms_output.put_line(c_cur."1997_SAYI");
      dbms_output.put_line(c_cur."1996_SAYI");
   end loop;
end;You can use this to test that what you're generating is correct.