Windows\Temp folder filling fast - how to Dispose the Crystal Objects?

Question

Post Author: pontupo
CA Forum: .NET
So the Windows\Temp folder is fast filling the disk in my
deployment. Each time a report is opened, a number of files are created
here. The problem is, of course, probably that I'm not releasing my
report objects in my code, as the reports can't even be manually
deleted without shutting down IIS. Well, fair enough. What I can't
figure out is where to release my reports objects. I have two pages:
one performs a pre-pass of the report object and generates a dynamic
page to prompt the user for parameters. This page, I believe, has no
problems because the report.Close() command is in line with the code
and is the final statement, but I could be mistaken and this page may also be leaving memory leaks. The second page, however, has the
CrystalReportsViewer object and actually displays the report to the
user after setting up the parameters correctly. On this page, I can't
figure out how/when to call report.Close(). If I do it at the
page.Dispose event, there seems to be no affect. If I do it at the
page.Close event, the report will load fine, but if you try to go to
another page in the report (in the case of multi-page reports) or
refresh the data, the report object has already been unloaded and the
CrystalReportsViewer won't be able to find the report document. If I
wrap my code in one big Try-Catch-Finally (rather than just having a
Try-Catch around the file load itself) as I've seen suggested elsewhere and place a report.Close()
command in the Finally, the Finally is executed before the viewer even
loads the report so I get a file not found error. So where
can I unload the report object? What I want is to persist the report
via Sessions (which I do) so that as the user moves between pages of
the report/refreshes the report will remain loaded, but when the user
closes the page or browses to another page, perhaps, I want to close
the report and free the resources so that the temp files are deleted.
Following are some code samples: Protected Sub Page_Init(ByVal sender As Object, ByVal e As System.EventArgs) Handles Me.Init        sessionString = Request.QueryString("report")        report = Server.MapPath("reports/") & Request.QueryString("report") & ".rpt"        ConfigureCrystalReport()    End SubPrivate Sub ConfigureCrystalReport()        If (Session(sessionString) Is Nothing) Then            reportDoc = New ReportDocument()            'load the report document            If (IsReportValid()) Then              reportDoc.Load(report)              '******************************              'bunch of other code, authentication              'parameter handling, etc. here              '******************************              Session(sessionString) = reportDoc        Else                Response.Redirect("error.aspx")            End If        Else            reportDoc = CType(Session(sessionString), ReportDocument)        End If    CrystalReportsViewer.ReportSource = reportDoc    End Sub    Private Function IsReportValid() As Boolean        Dim reportIsValid As Boolean = False        Try            If (System.IO.File.Exists(report)) Then 'does the file exist?                'if it does, try to load it to confirm it's a valid crystal report                Dim tryReportLoad As New CrystalDecisions.CrystalReports.Engine.ReportDocument()                tryReportLoad.Load(report)                tryReportLoad.Close()                tryReportLoad.Dispose()                reportIsValid = True            End If        Catch ex As Exception            reportIsValid = False        End Try        Return reportIsValid    End Function'Currently, I've also tried each of the following:Protected Sub Page_Unload(ByVal sender As Object, ByVal e As System.EventArgs) Handles Me.Unload        CloseReports(reportDoc)        CrystalReportsViewer.Dispose()        CrystalReportsViewer = Nothing    End Sub    Private Sub CloseReports(ByVal report As ReportDocument)        Dim sections As Sections = report.ReportDefinition.Sections        For Each section As Section In sections            Dim reportObjects As ReportObjects = section.ReportObjects            For Each reportObject As ReportObject In reportObjects                If (reportObject.Kind = ReportObjectKind.SubreportObject) Then                    Dim subreportObject As SubreportObject = CType(reportObject, SubreportObject)                    Dim subReportDoc As ReportDocument = subreportObject.OpenSubreport(subreportObject.SubreportName)                    subReportDoc.Close()                End If            Next        Next        report.Close()    End Sub'This was the solution suggested on another forum. I've also tried:Protected Sub Page_Disposed(ByVal sender As Object, ByVal e As System.EventArgs) Handles Me.Disposed        reportDoc.Close()        reportDoc.Dispose()        CType(Session(sessionString), ReportDocument).Close()        Session(sessionString) = Nothing    End Sub'I've also tried wrapping everything inside of the If statement in the ConfigureCrystalReport() method in code to this effect:If (IsReportValid()) Then                Try                    reportDoc.Load(report)Catch e As Exception                    Response.Redirect("error.aspx")                Finally                    reportDoc.Close()                End TryAny advice on this is appreciated. Thanks in advance, Pont

Answer 1

Post Author: sarasew13
CA Forum: .NET
Why are you checking for is valid before closing?  As long as the report object isn't null you should be able to close it (whether it's open or not).  I ran into this same problem when trying to store the report, so now I just store the dataset.  Everything seems to work fine and navigate appropriately so here's more or less how I handle it:
DataSet myDS;ReportDocument myRPT;
    protected void Page_Load(object sender, EventArgs e)    {        try        {            if (!IsPostBack)            {                //pull variables from previous page if available                //set variables into view state so they'll persist in post backs            }            else            {                //if postback then pull from view state            }
            createReport();    }        catch (Exception err)        {            //handle error        }    }
    private void createReport()    {        myDS = new DataSet();        string rpt;
        rpt = "RPTS/report.rpt";        try        {            if (!IsPostBack || Session["data"] == null)            {                myDS = getData();//make data call here                Session["data"] = myDS;            }            else            {                myDS = (DataSet)Session["data"];            }
            if (myDS.Tables.Count > 0)//make sure the dataset isn't empty            {                myRPT = new ReportDocument();                myRPT.Load(Server.MapPath(rpt));                myRPT.SetDataSource(myDS.Tables[0]);
                if (!IsPostBack)                {                    //code to set parameters for report here                }
                MyViewer.ReportSource = myRPT;            }        }        catch (Exception error)        {            //handle error        }    }
    protected void Page_Unload(object Sender, EventArgs e)    {        try        {            if (myRPT != null)            {                myRPT.Close();            }        }        catch (Exception error)        {            //handle error        }    }