Workaround to bugs in ADFPhaseListener

Question

I've developed a nasty but perfectly working workaround to two ADF bugs described here:
* Binding container not initialized after navigation: Navigating does not initialize BindingContainer
* Exceptions ignored in ControllerClass: Bug(?): Exceptions ignored in ControllerClass
The solution replaces the oracle.adf.controller.faces.lifecycle.ADFPhaseListener class. The source for this class is available in $JDEV_HOME/adfc/src/adf-controllersrc.zip. I modified the before() method in RenderResponsePhase object (original line 388):
      public void before(FacesContext context)
         LifecycleContext lfContext = null;
         loop:
         while (true) {
           UIViewRoot newViewRoot = context.getViewRoot();
           UIViewRoot viewRoot = getViewRoot(context);
           lfContext = getLifecycleContext(context);
           // Detect if nagivation occured
           // If the view going to be rendered is different from the one that
           // has being prepared, refreshed the old one.
           if (newViewRoot != viewRoot)
              if (lfContext != null)
                 putViewRoot(context, newViewRoot);
                 // Create a new context for the new view
                 Map envMap = ADFPhaseListener.this.getEnvMap(context);
                 try
                    lfContext = LifecycleContext.getInstance(envMap);
                 catch (Exception ex)
                 if (lfContext != null) {
                   putLifecycleContext(context, lfContext);
                   // Execute the INIT_CONTEXT phase
                   executePhase(INIT_CONTEXT, lfContext);
                   // Execute the PREPARE_MODEL phase of the new view.
                   executePhase(PREPARE_MODEL, lfContext);
           else break loop;
         // Event might had been updated in case of navigation.
         if (lfContext != null)
            // Execute the PREPARE_RENDER phase.
            executePhase(PREPARE_RENDER, lfContext);
      } // End of before methodIt reinitializes the context in loop until it is not changed. And ignores exceptions only in LifecycleContext.getInstance method. To avoid ignoring exceptions in after() method of RestoreViewPhase, it needs to be replaced as well (original line 298):
      public void after(FacesContext context)
         UIViewRoot viewRoot = context.getViewRoot();
         String viewId = (viewRoot != null) ? viewRoot.getViewId() : null;
         if (viewId == null)
            return;
         HttpSession session =
            (HttpSession) context.getExternalContext().getSession(false);
         if (session == null)
            return;
         // Store the current view root so that we can detect if navigation
         // occured when we execute the before RenderResponse.
         putViewRoot(context, viewRoot);
         Map envMap = ADFPhaseListener.this.getEnvMap(context);
         LifecycleContext lfContext = null;
         try
            lfContext = LifecycleContext.getInstance(envMap);
         catch (Exception ex)
         if (lfContext != null) {
            putLifecycleContext(context, lfContext);
            // Execute the INIT_CONTEXT phase
            executePhase(INIT_CONTEXT, lfContext);
            // Execute the PREPARE_MODEL phase
            executePhase(PREPARE_MODEL, lfContext);
      }  // End of after methodI created the class in my own package and replaced the reference in faces-config.xml.
The line numbers refer to JDeveloper 10.1.3.0.4 (SU5). The class is changed in 10.1.3.1.0, so you will need to copy the new source and modify the methods again. But I could not conceive anything better... I hope, that this code will get to the original code of ADFPhaseListener, I don't reserve any rights, so go on, guys!
Viliam

Answer 1

Question to guys from Oracle: what do you think about including these features to next release of ADF?