ABAP Code in Start Routine to fill a field

Question

Hello,
with the following code in the start routine in BW3.5 I am trying to fill Intercompany-Indicator based on Distribution Channel. The main code is marked bold.
Distribution Channel = DISTR_CHAN
InterCompany-Indicator = G_CWWR14
Pls help. Thanks.
SD
Intercompany Indicator
    IF NOT wa_daten-customer IS INITIAL.
      SELECT SINGLE /b05/s_rbkunde FROM  /b05/mrbcust INTO l_rbcust
             WHERE  /b05/s_rbcust  = wa_daten-customer
             AND    objvers        = 'A'
             AND    datefrom      <= l_date
             AND    dateto        >= l_date.
      IF sy-subrc EQ 0.
        SELECT SINGLE g_cwwr14 FROM  /b05/mrbkdbkrs INTO l_ii
               WHERE  comp_code        = wa_daten-comp_code
               AND    /b05/s_rbkdbkrs  = l_rbcust
               AND    objvers          = 'A'
               AND    datefrom        <= l_date
               AND    dateto          >= l_date.
        IF sy-subrc = 0.
          wa_daten-g_cwwr14 = l_ii.
        ELSE.
          CLEAR wa_daten-g_cwwr14.
        ENDIF.
      ELSE.
        CLEAR wa_daten-g_cwwr14.
      ENDIF.
    ELSE.
      IF wa_daten-G_CWWR14 = ' '.
        CASE wa_daten-DISTR_CHAN.
          WHEN 'Y4'.
            wa_daten-G_CWWR14 = '4'.
          WHEN 'Y5'.
            wa_daten-G_CWWR14 = '2'.
          WHEN OTHERS.
            wa_daten-G_CWWR14 = '0'.
        ENDCASE.
      ENDIF.
    ENDIF.      " NOT wa_daten-customer IS INITIAL
    MODIFY DATA_PACKAGE FROM wa_daten.
  ENDLOOP.

Answer 1

Hi Venkat,
  Two things -One is the performance and the other ... there is no Append  within the loop.
  Try moving the select statement ousdie the loop to improve performance and move the modify statement into the loop ... change modify to append. Code below.
   Let me know if you need more help.
Best regards,
Kazmi
data: it_data type standard table of data_package_structure
with header line
with non-unique default key initial size 0.
types: begin of billing_item_type,
BILL_NUM like /BIC/AZSD_O0700-BILL_NUM,
DOC_NUMBER like /BIC/AZSD_O0700-DOC_NUMBER,
PLANT like /BIC/AZSD_O0700-PLANT,
end of billing_item_type.
refresh it_data.
clear it_data.
it_data] = DATA_PACKAGE[.
refresh DATA_PACKAGE.
clear DATA_PACKAGE.
loop at it_data.
select DOC_NUMBER PLANT into (it_data-DOC_NUMBER, it_data-PLANT)
from /BIC/AZSD_O0700
where BILL_NUM = it_data-BILL_NUM
and FISCVARNT = it_data-fiscvarnt.
endselect.
if sy-subrc = 0.
move-corresponding it_data to DATA_PACKAGE.
Append DATA_PACKAGE.
endif.
endloop.