ABAP query help

Question

hi folks,
I have a query that is giving me a Run time Error and reason is  databse commit is being called before the databse selection is completed.
I understood the error but I do not know how to solve it.
select * from  ZEDMSTR.
  if sy-subrc = 0.
    rec-businessunit = ZEDMSTR-ZBUSUNIT.
    rec-tablename = ZEDMSTR-ZTABNAME.
    rec-oldlegcode = ZEDMSTR-ZOLDLEGCODE.
    rec-description = ZEDMSTR-ZDESCRIPTION.
    rec-newlawsoncode = ZEDMSTR-ZNEWLAWCODE.
   WRITE: ' tHE RECORDS GOT APPENDED INTO THE TABLE'.
  else.
  exit.
endif.
  append rec.
  endselect.
The table ZEDMSTR HAS FIVE FIELDS (SAME NUMBER DECLARED FOR THE INTERNL TABLE 'REC') AND I HAVE TO PULL ALL THE RECORDS OF ALL THE FIELDS FROM THE TABLE INTO REC.
My question is how can I modify the select query  to eliminate the runtime exception and without the use of select...endselect. because I shall be reading over 40,000 records from the query and it may raise a performance issue.
Thanks in advance for your help folks.
Vinu

Answer 1

Vinu,
First, you don't need a SY-SUBRC check within a select end-select loop. Your check should be outside the loop. Are you getting this error while you are debugging? When you are debugging, a select endselect loop sometimes results in this dump. If you put your breakpoint after the endselect, you will not get this dump.
select * from ZEDMSTR.
  rec-businessunit = ZEDMSTR-ZBUSUNIT.
  rec-tablename = ZEDMSTR-ZTABNAME.
  rec-oldlegcode = ZEDMSTR-ZOLDLEGCODE.
  rec-description = ZEDMSTR-ZDESCRIPTION.
  rec-newlawsoncode = ZEDMSTR-ZNEWLAWCODE.
  append rec.
endselect.
if sy-subrc <> 0. <-- put your breakpoint here
  write:/ 'No records selected.'.
else.
  write:/ 'Records are appended.'.
endif.