Black image from Dalsa CL-P1-2048 with 1424
Hi all,I am using Dalsa CL-P1 2048 line scan camera with PCI 1424(LVDS). I checked with MAX and have some problems in acquiring the correct image.
In short I am getting Image only with the following setup in MAX:
1. Integration Type – Total
2. Line rate is less than 10 KHz,
3. Only with Snap & not in Grab operation
4. Only if the acquisition window height is 1.
If any of the above setup is changed then I am getting a black image. Further the image appears only in MAX and I am getting black line/image with Vision builder and LabVIEW.
I have checked for the connections and that’s correct. What could be the problem??
Does the timing of the si
gnals that NI card gives is as per the Dalsa Camera's requirement?
Can we check the signals directly with the scope??
Please reply at the earliest.
Thanks,
Nandhini
Nandhini,
I have seen exactly this behavior before. The problem turned out to be a lack of light since line scan cameras typically require very bright light. Try aiming the camera at a bright light source and see if the image changes.
Regards,
Brent R.
Applications Engineer
National Instruments
Similar Messages
-
Importing black images from my 4s on to iphoto
Hey there
can anyone help me with an issue on iphoto? recently im importing some photos from my 4s and some of them are coming up as black images on my iphoto ....
does any one else have this issue ?
ive tried doing the repair library on i photo by pressing command + ALT but it hasnt improved it....
can any one recommend any options for me ?
Thanks alot
WayneDo you have a passcode lock on your iphone? I have a 4s and many of my photos turn up black in iPhoto.
I THINK that this happens because you take photos without unlocking your phone, so you technically "wouldn't have pemissions" on those photos. I only think this because I sometimes need to take a quick picture and don't unlock my phone, and those are the photos that are black on iPhoto.
I also tried repairing my library, but nothing. I guess we must wait. -
'cut-out' images from Photoshop import into FCE with unwanted background
I want to import some custom 'cut-out' images from Photoshop, but they come into FCE with a rectangular background around them. Is there a way to import just the irregular 'cut-out' image?
BobMake sure the images are RGB 8-bit and in a format that carries an alpha channel or Photoshop transparency like Photoshop, TIFF, PNG, even PICT.
-
Extract images from PDF out of Illustrator with script
Looking for a script to extract images from a pdf opened in Illustrator.
I need the images to extract separately to a folder. Jpeg perhaps.hi
I have to do the same... I have to convert a pdf to an image format.... can you solved the problem??? Can you help me??
Thanks in advance... -
An image from my computer is sent with every email in the title section
Every time I send an email, the same image from my computer is sent in the upper right-hand section of the email. This is very frustrating as I can't see how the image is being attached. It's always the same picture and I'm sure that recipients of my emails are wondering why I send the image, but there's nowhere in the options that identifies how the image is attached.
Can someone please tell me how this is happening and more importantly, how to stop it.Application Basics
Name: Thunderbird
Version: 24.6.0
User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
Profile Folder: Show Folder
(Local drive)
Application Build ID: 20140610001341
Enabled Plugins: about:plugins
Build Configuration: about:buildconfig
Crash Reports: about:crashes
Memory Use: about:memory
Mail and News Accounts
account2:
INCOMING: account2, , (none) Local Folders, plain, passwordCleartext
account3:
INCOMING: account3, , (pop3) mail.optusnet.com.au:110, plain, passwordCleartext
OUTGOING: mail.optusnet.com.au:25, plain, passwordCleartext, true
Extensions
Important Modified Preferences
Name: Value
browser.cache.disk.capacity: 358400
browser.cache.disk.smart_size.first_run: false
browser.cache.disk.smart_size.use_old_max: false
browser.cache.disk.smart_size_cached_value: 358400
extensions.lastAppVersion: 24.6.0
font.name.monospace.el: Consolas
font.name.monospace.tr: Consolas
font.name.monospace.x-baltic: Consolas
font.name.monospace.x-central-euro: Consolas
font.name.monospace.x-cyrillic: Consolas
font.name.monospace.x-unicode: Consolas
font.name.monospace.x-western: Consolas
font.name.sans-serif.el: Calibri
font.name.sans-serif.tr: Calibri
font.name.sans-serif.x-baltic: Calibri
font.name.sans-serif.x-central-euro: Calibri
font.name.sans-serif.x-cyrillic: Calibri
font.name.sans-serif.x-unicode: Calibri
font.name.sans-serif.x-western: Calibri
font.name.serif.el: Cambria
font.name.serif.tr: Cambria
font.name.serif.x-baltic: Cambria
font.name.serif.x-central-euro: Cambria
font.name.serif.x-cyrillic: Cambria
font.name.serif.x-unicode: Cambria
font.name.serif.x-western: Cambria
font.size.fixed.el: 14
font.size.fixed.tr: 14
font.size.fixed.x-baltic: 14
font.size.fixed.x-central-euro: 14
font.size.fixed.x-cyrillic: 14
font.size.fixed.x-unicode: 14
font.size.fixed.x-western: 14
font.size.variable.el: 17
font.size.variable.tr: 17
font.size.variable.x-baltic: 17
font.size.variable.x-central-euro: 17
font.size.variable.x-cyrillic: 17
font.size.variable.x-unicode: 17
font.size.variable.x-western: 17
mail.openMessageBehavior.version: 1
mail.winsearch.firstRunDone: true
mailnews.database.global.datastore.id: 3c0e414b-2dab-4ccf-8897-8cf567930c4
network.cookie.prefsMigrated: true
network.online: false
places.database.lastMaintenance: 1412293568
places.history.expiration.transient_current_max_pages: 92439
plugin.importedState: true
plugin.state.npnitromozilla: 0
plugin.state.npvlc: 0
plugin.state.npwlpg: 0
Graphics
Adapter Description: AMD Radeon HD 7500G
Vendor ID: 0x1002
Device ID: 0x990a
Adapter RAM: 512
Adapter Drivers: aticfx64 aticfx64 aticfx64 aticfx32 aticfx32 aticfx32 atiumd64 atidxx64 atidxx64 atiumdag atidxx32 atidxx32 atiumdva atiumd6a atitmm64
Driver Version: 13.251.9001.0
Driver Date: 4-23-2014
Direct2D Enabled: false
DirectWrite Enabled: false (6.3.9600.17111)
ClearType Parameters: ClearType parameters not found
WebGL Renderer: false
GPU Accelerated Windows: 0
AzureCanvasBackend: skia
AzureFallbackCanvasBackend: cairo
AzureContentBackend: none
JavaScript
Incremental GC: 1
Accessibility
Activated: 1
Prevent Accessibility: 0
Library Versions
Expected minimum version
Version in use
NSPR
4.10.2
4.10.2
NSS
3.15.4 Basic ECC
3.15.4 Basic ECC
NSS Util
3.15.4
3.15.4
NSS SSL
3.15.4 Basic ECC
3.15.4 Basic ECC
NSS S/MIME
3.15.4 Basic ECC
3.15.4 Basic ECC -
Change image from 300 to 72 dpi with Photoshop elements 13?
Want to buy an image for a Kindle cover which is only available in the size required by Kindle as a 300 dpi image.Can I change It to 72 dpi with my Photoshop elements 13?
So, on a copy I made of the image I want,I did go to "file", Then "save for Web", and made the long size 800 pixels, and saved that as JPEG..
But in that particular window, I didn't see "Constrain proportions" anywhere.
Yesterday,with that image, I did go "image" and then "resize", and did have checked "constrain proportions". That is, I'm presently working with a resized image, that includes a few text inserts and one simple custom shape..
But do I have to start with a fresh, Unedited image?
You continue to be marvelous help. I'm so grateful. -
When trying to export a RAW image from Aperture to a jpeg, the jpeg file is completely black.
I am trying to share some photos that I have taken. I shot them in RAW and store them in Aperture that way. I then tried to export the version to my desktop to be able to send to someone. The export process went through just fine, but the jpeg file is just a black image. I have tried this with several different images with the same result.
I have done this a million times in the past with no problems. I don't know what is different now.
Thanks for any help you can provide.As a work-around: are the jpegs ok, if you simply drag the images that you want to export from Aperture's browser to your Desktop?
What is your Aperture version?
And which export preset are you using? Check, if your "Export preset", for example "JPEG original size" has been changed. Have you perhaps added a watermark, that could be occluding the image? -
How to create Image from 8-bit grayscal pixel matrix
Hi,
I am trying to display image from fingerprintscanner.
To communicate with the scanner I use JNI
I've wrote java code which get the image from C++ as a byte[].
To display image I use as sample code from forum tring to display the image.
http://forum.java.sun.com/thread.jspa?forumID=20&threadID=628129
import java.awt.*;
import java.awt.color.*;
import java.awt.image.*;
import java.io.*;
import java.util.*;
import javax.imageio.*;
import javax.swing.*;
public class Example {
public static void main(String[] args) throws IOException {
final int H = 400;
final int W = 600;
byte[] pixels = createPixels(W*H);
BufferedImage image = toImage(pixels, W, H);
display(image);
ImageIO.write(image, "jpeg", new File("static.jpeg"));
public static void _main(String[] args) throws IOException {
BufferedImage m = new BufferedImage(1, 1, BufferedImage.TYPE_BYTE_GRAY);
WritableRaster r = m.getRaster();
System.out.println(r.getClass());
static byte[] createPixels(int size){
byte[] pixels = new byte[size];
Random r = new Random();
r.nextBytes(pixels);
return pixels;
static BufferedImage toImage(byte[] pixels, int w, int h) {
DataBuffer db = new DataBufferByte(pixels, w*h);
WritableRaster raster = Raster.createInterleavedRaster(db,
w, h, w, 1, new int[]{0}, null);
ColorSpace cs = ColorSpace.getInstance(ColorSpace.CS_GRAY);
ColorModel cm = new ComponentColorModel(cs, false, false,
Transparency.OPAQUE, DataBuffer.TYPE_BYTE);
return new BufferedImage(cm, raster, false, null);
static void display(BufferedImage image) {
final JFrame f = new JFrame("");
f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
f.getContentPane().add(new JLabel(new ImageIcon(image)));
f.pack();
SwingUtilities.invokeLater(new Runnable(){
public void run() {
f.setLocationRelativeTo(null);
f.setVisible(true);
And I see only white pixels on black background.
Here is description of C++ method:
GetImage
Syntax: unsigned char* GetImage(int handle)
Description: This function grabs the image of a fingerprint from the UFIS scanner.
Parameters: Handle of the scanner
Return values: Pointer to 1D-array, which contains the 8-bit grayscale pixel matrix line by line.
here is sample C++ code which works fine to show image in C++
void Show(unsigned char * bitmap, int W, int H, CClientDC & ClientDC)
int i, j;
short color;
for(i = 0; i < H; i++) {
for(j = 0; j < W; j++) {
color = (unsigned char)bitmap[j+i*W];
ClientDC.SetPixel(j,i,RGB(color,color,color));
Will appreciate your help .Hi Joel,
The database nls parameters are:
select * from nls_database_parameters;
NLS_LANGUAGE AMERICAN
NLS_TERRITORY AMERICA
NLS_CURRENCY $
NLS_ISO_CURRENCY AMERICA
NLS_NUMERIC_CHARACTERS .,
NLS_CHARACTERSET CL8MSWIN1251
NLS_CALENDAR GREGORIAN
NLS_DATE_FORMAT DD-MON-RR
NLS_DATE_LANGUAGE AMERICAN
NLS_SORT BINARY
NLS_TIME_FORMAT HH.MI.SSXFF AM
NLS_TIMESTAMP_FORMAT DD-MON-RR HH.MI.SSXFF AM
NLS_TIME_TZ_FORMAT HH.MI.SSXFF AM TZR
NLS_TIMESTAMP_TZ_FORMAT DD-MON-RR HH.MI.SSXFF AM TZR
NLS_DUAL_CURRENCY $
NLS_COMP BINARY
NLS_LENGTH_SEMANTICS BYTE
NLS_NCHAR_CONV_EXCP FALSE
NLS_NCHAR_CHARACTERSET AL16UTF16
NLS_RDBMS_VERSION 9.2.0.4.0
Part of the email header:
Content-Type: multipart/alternative; boundary="---=1T02D27M75MU981T02D27M75MU98"
-----=1T02D27M75MU981T02D27M75MU98
-----=1T02D27M75MU981T02D27M75MU98
Content-Type: text/plain; charset=us-ascii
-----=1T02D27M75MU981T02D27M75MU98
Content-Type: text/html;
-----=1T02D27M75MU981T02D27M75MU98--
I think that something is wrong in the WWV_FLOW_MAIL package. In order to send 8-bit characters must be used UTL_SMTP.WRITE_ROW_DATA instead of the UTL_SMTP.WRITE_DATA.
Regards,
Roumen -
Hi,
I have a ZyXEL NSA310 NAS device on my network that I use for backups (as well as a media server). I have been very happy with it as, amongst other things, it has a gigabit Ethernet connection. I recently upgraded my home laptop from Win7 Pro to Win8
Pro. Under Win7 the NAS device worked perfectly as the backup target. I could back up file sets and - most importantly to me - create a system image on the device should I need to restore the system in the event of a full disk failure.
When I upgraded to Win8 it kept the Win7 settings and it looked like it was just going to work, then as it came to create the system image it failed with error code 0x807800C5 and message "The version does not support this version of the file format".
I have searched the internet and seen that others have had similar issues on Win7 and Win8 with NAS devices where they have had to hack the device to get it working - though it isn't clear that this has been successful for everyone. This isn't an option
for me as the NSA310 is a closed device and in any event I don't see why I should have to hack the device when clearly this is a Win8 issue (since Win7 worked perfectly).
Does anyone have any ideas how to fix this issue so that I can create the full backups I require?
Thanks,
Phil
Event Log messages:
Log Name: Application
Source: Microsoft-Windows-Backup
Date: 13/01/2013 23:14:52
Event ID: 517
Task Category: None
Level: Error
Keywords:
User: SYSTEM
Computer: Home-Laptop
Description:
The backup operation that started at '2013-01-13T23:13:43.523158000Z' has failed with following error code '0x807800C5' (There was a failure in preparing the backup image of one of the volumes in the backup set.). Please review the event details for a
solution, and then rerun the backup operation once the issue is resolved.
Log Name: Application
Source: Windows Backup
Date: 13/01/2013 23:14:56
Event ID: 4104
Task Category: None
Level: Error
Keywords: Classic
User: N/A
Computer: Home-Laptop
Description:
The backup was not successful. The error is: There was a failure in preparing the backup image of one of the volumes in the backup set. (0x807800C5).Thanks willis! I will look into the iSCSI route. A quick Google search and I can see some mention of the NSA310 and iSCSI so maybe it does support it.
One question: Have you ever attempted to restore a system image from a NAS iSCSI device with a Win8 Restore Disk? Is it easy? I just want to be sure that it is possible to do so in case the worst happens and I need to restore the entire image onto a
new disk.
Hopefully Microsoft will fix the issue with the standard NAS setup with an update in the future, but I don't want to wait for it.
Thanks again,
Phil
Hi Phil, No I have not had to do this yet, but I see no reason why it shouldn't work as the iSCSI disk looks just like a regular hard disk to the OS. I agree that Microsoft should fix the direct NAS support as the iSCSI approach does have the downside
of dedicating a fixed chunk of your NAS drive to the iSCSI disk that you have to choose when you create the disk whereas the direct NAS just uses the actual space currently needed by the backup. Also I had some trouble getting authentication (access rights)
to work so I left the iSCSI portal as open access - which is OK for a home solution but not a good idea in general. I will revisit this for my own setup and see if I can get it working but just wanted to mention it in case you have the same issue. It manifests
itself as not being able to connect to the iSCSI portal due to failed authentication when running iSCSI initiator setup.
-willis -
Problem in sending image from applet to servlet
dear friends,
i have a need to send an image from applet to servlet via HttpConnection and getting back that image from applet.
i am struggling with this sice many hours and got tired by searching any post that would help me but haven't got yet.
i tried using this code but it dosent make any execution sit right. i got NPE at ImageIcon.getDescription() line;
at applet side
jf.setContentPane(getJContentPane());
FileDialog fd=new FileDialog(jf,"hi");
fd.setMode(FileDialog.LOAD);
fd.setVisible(true);
v=new Vector();
try{
FileInputStream fis=new FileInputStream(new File(fd.getDirectory()+fd.getFile()));
byte[] imgbuffer=new byte[fis.available()];
fis.read(imgbuffer);
ImageIcon imgdata=new ImageIcon(imgbuffer);
v.add(0,imgicon);
String strwp ="/UASProject/Storeimage";
URL servletURL = new URL(getCodeBase(),strwp);
HttpURLConnection servletCon = (HttpURLConnection)servletURL.openConnection();
servletCon.setDoInput(true);
servletCon.setDoOutput(true);
servletCon.setUseCaches(false);
servletCon.setDefaultUseCaches(false);
servletCon.setRequestMethod("POST");
servletCon.setRequestProperty("Content-Type", "application/octet-stream");
servletCon.connect();
ObjectOutputStream oboutStream = new ObjectOutputStream(servletCon.getOutputStream());
oboutStream.writeObject(v);
v.remove(0);
oboutStream.flush();
oboutStream.close();
//read back from servlet
ObjectInputStream inputStream = new ObjectInputStream(servletCon.getInputStream());
v= (Vector)inputStream.readObject();
imgicon=(ImageIcon)v.get(1);
showimg.setIcon(imgicon);
this.getContentPane().validate();
this.validate();
inputStream.close();
// repaint();
}catch(Exception e){e.printStackTrace();} and this is at servlet side
try {
Vector v=new Vector();
ObjectInputStream inputFromjsp = new ObjectInputStream(request.getInputStream());
v = (Vector)inputFromjsp.readObject();
imgicon=(ImageIcon)v.get(0);
inputFromjsp.close();
System.out.println(imgicon.getDescription());
v.remove(0);
v.add(1,imgicon);
//sending back to applet
response.setContentType("application/octet-stream");
ObjectOutputStream oboutstream=new ObjectOutputStream(response.getOutputStream());
oboutstream.writeObject(v);
oboutstream.flush();
oboutstream.close();
} catch (Exception e) {e.printStackTrace();} i really need your help. please let me out of this headche
thanks
Edited by: san_4u on Nov 24, 2007 1:00 PMBalusC wrote:
san_4u wrote:
how can i made a HttpClient PostMethod using java applets? as i have experience making request using HttpURLConnection.POST method. ok first of all i am going make a search of this only after i will tell. please be onlineOnce again, see link [3] in my first reply of your former topic.
yeah! i got the related topic at http://www.theserverside.com/tt/articles/article.tss?l=HttpClient_FileUpload. please look it, i am reading it right now and expecting to be reliable for me.
well what i got, when request made by html code(stated above) then all the form fields and file data mixed as binary data and available in HttpServletRequest.getinputstream. and at servlet side we have to use a mutipart parser of DiskFileItemFactory class that automatically parse the file data and return a FileItem object cotaing the actual file data,right?.You can also setup the MultipartFilter in your environment and don't >care about it further. Uploaded files will be available as request attributes in the servlet.is the multipartfilter class file available in jar files(that u suggested to add in yours article) so that i can use it directly? one more thing the import org.apache.commons.httpclient package is not available in these jar files, so where can got it from?
one mere question..
i looked somewhere that when we request for a file from webserver using web browser then there is a server that process our request and after retrieving that file from database it sends back as response.
now i confused that, wheather these webservers are like apache tomcat, IBM's webspher etc those processes these request or there is a unique server that always turned on and process all the request?
because, suppose in an orgnisation made it's website using its own server then, in fact, all the time it will not turned on its server or yes it will? and a user can make a search for kind of information about this orgnisation at any time.
hopes, you will have understand my quary, then please let me know the actual process
thanks
Edited by: san_4u on Nov 25, 2007 11:25 AM -
Can I download raw images from my Panasonic Lumix DMC - FZ45 to my iMac using Aperture3 ?
I want to start using Aperture3 as long as I can handle Raw images from my Panasonic DMC-FZ45 with it but that camera is not on the list - will it work?
If the camera is not on the list then Aperture will not be able to handle the RAW images from the camera.
It's surprising as this is a relatively old camera, so if it's not in Aperture by now I would tend to think it won't be included. You could download the trial version and see what happens just to make sure.
One other thing, you could convert the RAW images to DNG using the Adobe Camera Raw and DNG Converter for Macintosh and then import those.
regards -
How can I download automatically only new images from my camera?
Hello,
I can not download only new images from my EOS 450D-camera with Elements 10-Photodownloafer (Mac os).
Each time I use Photodownloader it downloads all images , also those that were downloaded preveously
How can I set photodownloader?
Thanks for your advicesI share my card with my wife and she likes to download our images also on her PC, so erasing all images is not an option.
It seems that earlier version of adobe photo downloader has the feature "copy only new files" , but V10 does not.
Thanks for your answer
Mikele
Op 10-jun.-2012, om 15:33 heeft 99jon het volgende geschreven:
Re: How can I download automatically only new images from my camera?
created by 99jon in Photoshop Elements - View the full discussion
Don’t you format the card in the camera after each download? That will wipe all images and prepare the card for a fresh shoot.
Replies to this message go to everyone subscribed to this thread, not directly to the person who posted the message. To post a reply, either reply to this email or visit the message page: http://forums.adobe.com/message/4480409#4480409
To unsubscribe from this thread, please visit the message page at http://forums.adobe.com/message/4480409#4480409. In the Actions box on the right, click the Stop Email Notifications link.
Start a new discussion in Photoshop Elements by email or at Adobe Forums
For more information about maintaining your forum email notifications please go to http://forums.adobe.com/message/2936746#2936746. -
Make Composite image from layer data instead from merged data section...
I am working on parsing the psd file and saving the data as per doc of photoshop 6. I need to make an image from the layer data alone with different combinations of layers selected, visible etc... and not using the merged data section in the file. Can any one please help me in this issue??
Thank u.Ask in the SDK forum.
Mylenium -
Help! Black printing from Colour cartridge
I just bought a HP Deskjet 6840 and I'm having trouble printing in black. When i do this, the black colour looks opaque/greyish. I tried changing the paper type in the printer preferences in illustrator, but for some reason it doesn't let me select "inkjet paper". I also found out after checking my ink levels that my printer prints black images from the colour cartridge. How can I change this? I'm totally confused!
Thanx in advance.
imac G5 Mac OS X (10.4.2)It sounds like you may need to review the print settings beyond paper type. Make sure you are using an RGB color mode (File>Document Color Mode>RGB) & that you're not using any settings for CMYK or Process Color printing. You may also have to turn Color Management off in the Print dialog box.
If you're sure the settings are correct & still have a problem, HP should be able to help you.
HTH |:>) -
A friend recently gave me their old Macbook pro 15 because they broke the screen and the Apple store quoted them $500-600 to fix it. I looked online and bought a screen of ebay for $170 in hopes of fixing it myself. After getting the screen I hooked it up using the steps I found online. Sadly when I turned it on, the top half of the screen was working apparently normally, but then it faded to black. The bottom half stayed bright with color the whole time but the images were always blurred. When I close the screen with it on, then open it after turning the computer on, the top half lights up with my desktop images as if it is working fine but then fades to black. The bottom is still blurred the whole time. What all could be wrong? Display cable, Inverter cable, not registering the screen or something, the screen is bad? I don't now a ton about all this and I have learned most of what I know from online research. I am not sure if I should send the screen back or if there is another issue. I just want to fix this thing.
Unfortunately, you don't even know the lower half of the computer is working properly, because you didn't have it until after it had been abused. So forget the attached screen for the moment. Connect an external monitor to it, fire it up, and see whether you can get a usable image on the external screen. If you can, send the defective "new" screen back for a refund, or replace the LVDS video cable first to make sure that's not where the problem lies, and if it isn't, then resort to sending the screen back. If you can't get a good image on the external, give the junk machine back to your friend and walk away.
Maybe you are looking for
-
Downloaded 11.1.3 and itunes wont open
Just downloaded itunes 11.1.3 and now it won't open. What to do?
-
Problem installing Flash Player 11
Hi, When I installed the Flash Player 11, it always stops at 50%, and asking me to close IE, but even I've closed all IE, it still stops there and would not continue installing. Please help! Thanks!
-
Connect AirPort Extreme Base Station to air card
How do you connect AirPort Extreme Base Station to Verizon Air Card?
-
Weblogic and mod_wls_ohs re-authenticate issue
Hello there, I got the following scenario (all software 11.1.1.6): WEBCACHE:80 > OHS:7777 > WLS:7001 I have this little issue: every time I update something on the weblogic console, and activate the change (by clicking on "Activete changes"), it lead
-
We have some GL accounts that we need to enable open item management. These gl accounts already have postings. What is the best solution to convert these accounts to open item managed. Thanks krishna