Can someone please check my VI??

Question

Purpose of the VI is to generate  and random numbers on graph, and also to compute the average of the random numbers.
Since i am a learner, i want someone to check it for me.
Thanks........
Attachments:
hhiyu.vi ‏305 KB

Answer 1

Yes, it is fine.  As a general rule of thumb, if it works....
As with any language there are good habits and bad habits.  Your VI is pretty simple and works as it should.
Now for constructive critisism:
Try to minimize unneccessary bends in the wires.
Apply comments to your code.  You can utilize the Free label decoration in the decorations palette, so as to provide for a standardized color...but feel free to adopt your own color codes.
Do not create unneccessary tunnels in loops as it will create increase your memory allocation.  In your example you ran the same data out twice, thus causing twice the memory to be utilized.
Get used to using the error clusters.  If a VI has error out, it should be wired.  You can also use these to sync your data flow (error out to error in.)
Once you get better at this and in the short term, I would also recommend the following.
Standardize your naming conventions for VIs and sub-Vis.  Usually very descriptive names are better.
Turn off the automatic error handling in LabVIEW.  You should control when and where errors are handled.  Some errors are OK and can be handled by your application.  Auto error handling will put up a prompt every time an error is passed out.
Turn off the auto-wiring and auto-wire routing.  This usually leads to unnecessary bends in wires and frustration from LabVIEW wanting to wire to the wrong terminal, especially when they are close together.
Use the VI icons.  Set the default font in the Icon editor to small fonts 10 point and at least type in some text.  If you are a creative individual, draw pretty pictures.
Always include extra terminals when setting up the inputs and outputs to allow you expandability without having to re-compile.  I personally perfer the 10 or 12 terminal block as it is nice and symetrical.
Always, always, always document your VI and what it does in the VI documentation property.
I could go on and on, but this should be enough to get you started.  Remember, good habits are easy to follow, bad habits are hard to break!
My $0.02
Paul <--Always Learning!!!
sense and simplicity.
Browse my sample VIs?
Attachments:
pictures.PNG ‏1112 KB