Convert spool to pdf and send in email sometimes attachment duplicated.

Question

Hi all, I have a process that creates a spool, converts it to a pdf and then attaches it to an email. My problem is that sometimes, the same attachment is duplicated.
The process seems to work fine in debug mode (the attachment changes for each loop) but when I run it in the background, every few emails, it will duplicate an attachment.
I have noticed that the size of the pdf seems to change properly but that the content of the pdf does not match.  So, it is like it gets the correct size of the pdf but not the body.
This is code that a consultant wrote and I am pretty new to abap/sap. I have changed some of the code because it was trying to handle an endless loop (I figured it should not have to handle (be in) an endless loop). I changed that code and it is working but this previous issue still exists. Thanks for your help.
*&      Form  PROCESS_EMPLOYEE
FORM process_employee .
* process appraisal only
  IF it_final[] IS NOT INITIAL .
*                READ DISTRIBUTION LIST                                *
    REFRESH : it_email, it_idlient. 
*Sort by supervisor
    SORT it_final[] BY supervisor.
    LOOP AT it_final INTO wa_final .
      APPEND wa_final TO it_final1 .
      AT END OF supervisor .
* Perform to create the PDF from the Output
       report = 'zhr_pm_appemail'.
       PERFORM create_pdf using report.
** Perform to email the PDF attachment
** to the supervisor and the Mailing list
        subject = 'Performance Appraisals'.
        PERFORM process_email using subject.
        REFRESH it_final1 .
        CLEAR it_final1 .
        CLEAR wa_final .
        FREE MEMORY ID 'MEM'.
      ENDAT .
    ENDLOOP.
  ENDIF.
ENDFORM.                    " PROCESS_EMPLOYEE
*&      Form  CREATE_PDF
FORM create_pdf using report.
  DATA:  spoolno TYPE tsp01-rqident.
  DATA : p_repid TYPE sy-repid .
  DATA: v_len  TYPE i , v_len1  TYPE i .
  DATA: v_temp(8) TYPE c .
  DATA: p_uname TYPE sy-uname .
  DATA: it_tsp01 TYPE STANDARD TABLE OF tsp01 WITH HEADER LINE .
*  DATA: it_pdf TYPE tline OCCURS 0 WITH HEADER LINE .
  TABLES: tsp01.
  DATA: var  TYPE c .
*-- STRUCTURES
  DATA:
    lc_rq2name TYPE tsp01-rq2name.
  DATA:
    mstr_print_parms TYPE pri_params,
    mc_valid(1)      TYPE c,
    mi_bytecount     TYPE i,
    mi_length        TYPE i,
    mi_rqident       TYPE tsp01-rqident.
*-- INTERNAL TABLES
  DATA:
    mtab_pdf    TYPE tline OCCURS 0 WITH HEADER LINE,
    mc_filename TYPE rlgrap-filename.
*-- SELECTION SCREEN
  DATA:
    p_linsz TYPE sy-linsz VALUE 80, " Line size
    p_paart TYPE sy-paart VALUE 'X_65_80'.  " Paper Format
    p_uname = sy-uname .
    var = var + 1.
    p_repid = report.
* START-OF-SELECTION .
  concatenate p_repid+0(9)
              p_uname+0(3)
        into mc_filename
   separated by '_'.
translate mc_filename to upper case.
*-- Setup the Print Parmaters
  CALL FUNCTION 'GET_PRINT_PARAMETERS'
    EXPORTING
      authority              = space
      copies                 = '1'
      cover_page             = space
      data_set               = space
      department             = space
      destination            = space
      expiration             = '1'
      immediately            = space
      new_list_id            = 'X'
      no_dialog              = 'X'
      user                   = sy-uname
    IMPORTING
      out_parameters         = mstr_print_parms
      valid                  = mc_valid
    EXCEPTIONS
      archive_info_not_found = 1
      invalid_print_params   = 2
      invalid_archive_params = 3
      OTHERS                 = 4.
IF sy-subrc = 0 .
*--Make sure that a printer destination has been set up. If this is not done the PDF module abends.
*-- Explicitly set line width, and output format so that
*-- the PDF conversion comes out OK
  mstr_print_parms-linsz = p_linsz.
  mstr_print_parms-paart = p_paart.
        EXPORT it_final1 it_email p_email1 p_sender p_date vl_nmth
        TO MEMORY ID 'MEM' .
      IF report =   'zhr_pm_appandprogemail'.
         SUBMIT zhr_pm_appandprogemail TO SAP-SPOOL WITHOUT SPOOL DYNPRO
      SPOOL PARAMETERS mstr_print_parms
      VIA SELECTION-SCREEN AND RETURN.
      ENDIF.
      IF report =   'zhr_pm_appemail'.
         SUBMIT zhr_pm_appemail TO SAP-SPOOL WITHOUT SPOOL DYNPRO
      SPOOL PARAMETERS mstr_print_parms
      VIA SELECTION-SCREEN AND RETURN.
      ENDIF.
ENDIF.
*Find out what the spool number is that was just created
  perform get_spool_number using p_repid p_uname changing mi_rqident.
*converting the spool request into pdf
  CALL FUNCTION 'CONVERT_ABAPSPOOLJOB_2_PDF'
    EXPORTING
      src_spoolid              = mi_rqident
      no_dialog                = space
      dst_device               = mstr_print_parms-pdest
    IMPORTING
      pdf_bytecount            = mi_bytecount
    TABLES
      pdf                      = it_pdf
    EXCEPTIONS
      err_no_abap_spooljob     = 1
      err_no_spooljob          = 2
      err_no_permission        = 3
      err_conv_not_possible    = 4
      err_bad_destdevice       = 5
      user_cancelled           = 6
      err_spoolerror           = 7
      err_temseerror           = 8
      err_btcjob_open_failed   = 9
      err_btcjob_submit_failed = 10
      err_btcjob_close_failed  = 11
      OTHERS                   = 12.
*  call function 'DOWNLOAD'
*    exporting
*      bin_filesize      = mi_bytecount
*      filename          = mc_filename
*      filetype          = 'BIN'
*    importing
*      act_filename      = mc_filename
*    tables
*      data_tab          = it_mess_att.
  CHECK sy-subrc = 0.
* Transfer the 132-long strings to 255-long strings
  LOOP AT it_pdf INTO wa_pdf.
    TRANSLATE wa_pdf USING ' ~'.
    CONCATENATE v_gd_buffer wa_pdf INTO v_gd_buffer.
    CLEAR wa_pdf .
  ENDLOOP.
  TRANSLATE v_gd_buffer USING '~ '.
  DO.
    it_mess_att = v_gd_buffer.
   APPEND it_mess_att.
    SHIFT v_gd_buffer LEFT BY 255 PLACES.
    IF v_gd_buffer IS INITIAL.
      EXIT.
    ENDIF.
  ENDDO.
ENDFORM.                    " CREATE_PDF
* FORM get_spool_nunber *
* Get the most recent spool created by user/report                      *
form get_spool_number using f_repid
      f_uname changing f_rqident.
  data:
        lc_rq2name TYPE rlgrap-filename.
  concatenate f_repid+0(6)
              f_repid+7(3)
              f_uname+0(3)
        into lc_rq2name.
*   separated by '_'.
translate lc_rq2name to upper case.
  select * from tsp01 where rq2name = lc_rq2name
    order by rqcretime descending.
      f_rqident = tsp01-rqident.
      exit.
      endselect.
      if sy-subrc ne 0.
        clear f_rqident.
      endif.
endform. " get spool number
*&      Form  SEND_MAIL
FORM send_email USING p_email subject.
  REFRESH it_mess_bod.
* Default subject matter
  gd_subject         = text-019 ."'Subject'.
  gd_attachment_desc = text-020 ."'Performance Appraisal'.
  IF subject =   'Performance Appraisals and Progression I'.
    gd_attachment_desc = 'PerfAppAndProg'.
  ENDIF.
  IF subject =   'Performance Appraisals'.
    gd_attachment_desc = 'PerfAppraisal'.
  ENDIF.
* If no sender specified - default blank
  IF p_sender EQ space.
    gd_sender_type  = space.
  ELSE.
    gd_sender_type  = 'INT'.
  ENDIF.
* Send file by email as .pdf
  PERFORM send_file_as_email_attachment
                               TABLES it_mess_bod
                                      it_mess_att
                                USING p_email
                                      subject
                                      'PDF'
                                      gd_attachment_desc
                                      gd_attachment_desc
                                      p_sender
                                      gd_sender_type
                             CHANGING gd_error
                                      gd_reciever.
ENDFORM.                    " SEND_MAIL
*       FORM process_email                                            *
FORM process_email using subject.
  DESCRIBE TABLE it_mess_att LINES gd_recsize.
  CHECK gd_recsize > 0.
  PERFORM send_email USING p_email1 subject.
*  perform send_email using p_email2.
ENDFORM.                    "process_email
*&      Form  SEND_FILE_AS_EMAIL_ATTACHMENT
*       Send email
FORM send_file_as_email_attachment TABLES it_message
                                          it_attach
                                    USING p_email
                                          p_mtitle
                                          p_format
                                          p_filename
                                          p_attdescription
                                          p_sender_address
                                          p_sender_addres_type
                                 CHANGING p_error
                                          p_reciever.
  CLEAR : ld_email , ld_mtitle , ld_format , ld_attdescription  ,
    ld_attfilename , ld_sender_address , ld_sender_address_type ,
    w_doc_data.
  REFRESH: t_packing_list.
  ld_email   = p_email.
  ld_mtitle = p_mtitle.
  ld_format              = p_format.
  ld_attdescription      = p_attdescription.
  ld_attfilename         = p_filename.
  ld_sender_address      = p_sender_address.
  ld_sender_address_type = p_sender_addres_type.
* Fill the document data.
  w_doc_data-doc_size = 1.
* Populate the subject/generic message attributes
  w_doc_data-obj_langu = sy-langu.
  w_doc_data-obj_name  = 'SAPRPT'.
  w_doc_data-obj_descr = ld_mtitle .
  w_doc_data-sensitivty = 'F'.
* Fill the document data and get size of attachment
  CLEAR w_doc_data.
  READ TABLE it_attach INDEX w_cnt.
  w_doc_data-doc_size =
     ( w_cnt - 1 ) * 255 + STRLEN( it_attach ).
  w_doc_data-obj_langu  = sy-langu.
  w_doc_data-obj_name   = 'SAPRPT'.
  w_doc_data-obj_descr  = ld_mtitle.
  w_doc_data-sensitivty = 'F'.
  CLEAR t_attachment.
  REFRESH t_attachment.
  t_attachment[] = it_attach[].
* Describe the body of the message
  CLEAR t_packing_list.
  REFRESH t_packing_list.
  t_packing_list-transf_bin = space.
  t_packing_list-head_start = 1.
  t_packing_list-head_num = 0.
  t_packing_list-body_start = 1.
  DESCRIBE TABLE it_message LINES t_packing_list-body_num.
  t_packing_list-doc_type = 'RAW'.
  APPEND t_packing_list.
* Create attachment notification
  t_packing_list-transf_bin = 'X'.
  t_packing_list-head_start = 1.
  t_packing_list-head_num   = 1.
  t_packing_list-body_start = 1.
  DESCRIBE TABLE t_attachment LINES t_packing_list-body_num.
  t_packing_list-doc_type   =  ld_format.
  t_packing_list-obj_descr  =  ld_attdescription.
  t_packing_list-obj_name   =  ld_attfilename.
  t_packing_list-doc_size   =  t_packing_list-body_num * 255.
  APPEND t_packing_list.
* Add the recipients email address
  CLEAR t_receivers.
  t_receivers-receiver = ld_email.
  t_receivers-rec_type = 'U'.
  t_receivers-com_type = 'INT'.
  t_receivers-notif_del = 'X'.
  t_receivers-notif_ndel = 'X'.
  APPEND t_receivers.
  LOOP AT it_email.
* Add the recipients email address
    t_receivers-receiver = it_email.
    t_receivers-rec_type = 'U'.
    t_receivers-com_type = 'INT'.
    t_receivers-notif_del = 'X'.
    t_receivers-notif_ndel = 'X'.
    APPEND t_receivers.
  ENDLOOP.
  CALL FUNCTION 'SO_DOCUMENT_SEND_API1'
       EXPORTING
            document_data              = w_doc_data
            put_in_outbox              = 'X'
            sender_address             = ld_sender_address
            sender_address_type        = ld_sender_address_type
            commit_work                = 'X'
       IMPORTING
            sent_to_all                = w_sent_all
       TABLES
            packing_list               = t_packing_list
            contents_bin               = t_attachment
*            CONTENTS_HEX               = t_attachment
            contents_txt               = it_message
            receivers                  = t_receivers
       EXCEPTIONS
            too_many_receivers         = 1
            document_not_sent          = 2
            document_type_not_exist    = 3
            operation_no_authorization = 4
            parameter_error            = 5
            x_error                    = 6
            enqueue_error              = 7
            OTHERS                     = 8.
  IF sy-subrc = 0.
    PERFORM update_infotype_0019 .
  ENDIF.
* Populate zerror return code
*  ld_error = sy-subrc.
**  stop .
*  READ TABLE t_receivers WITH KEY retrn_code = '0' .
*  IF sy-subrc = 0 .
*    v_update_flag = '1' .
*    EXPORT v_update_flag TO MEMORY ID 'MEM2' .
*  ENDIF .
** Populate zreceiver return code
*  LOOP AT t_receivers.
*    ld_receiver = t_receivers-retrn_code.
*  ENDLOOP.
ENDFORM.                    "send_file_as_email_attachment
*&      Form  GET_NEXT_MONTH
FORM get_next_month .
  CLEAR v_month .
  v_month = vl_nmth+4(2).
  REFRESH it_t247 .
  CLEAR it_t247 .
  CALL FUNCTION 'IDWT_READ_MONTH_TEXT'
    EXPORTING
      langu = 'E'
      month = v_month
    IMPORTING
      t247  = it_t247.
  CLEAR v_mon_text .
  v_mon_text = it_t247-ltx .
ENDFORM.                    " GET_NEXT_MONTH
Edited by: Katie Doody on Feb 24, 2010 12:30 AM

Answer 1

Thank you for your response, this has allowed me to identify the problem. It is when I create the spool by using the code below. If I add a wait after this, the program works successfully. Is there another way to write the data to create a spool within my initial program rather than doing the submit? Could it be that it is putting data in memory?
SUBMIT zhr_pm_appandprogemail TO SAP-SPOOL WITHOUT SPOOL DYNPRO
      SPOOL PARAMETERS mstr_print_parms
      VIA SELECTION-SCREEN AND RETURN.
*& Report  ZHR_PM_APPANDPROGEMAIL
REPORT  ZHR_PM_APPANDPROGEMAIL
        NO STANDARD PAGE HEADING
        LINE-SIZE 80
        LINE-COUNT 65(8).
*        MESSAGE-ID zhr.
* INTERNAL TABLES DECLARATION
DATA: it_pdf TYPE tline OCCURS 0 ." WITH HEADER LINE .
* WORK AEA DECLARATION
DATA: wa_pdf TYPE tline .
* Spool to PDF conversions
*DATA: "gd_spool_nr TYPE tsp01-rqident,
*      gd_destination TYPE rlgrap-filename,
*      gd_bytecount TYPE tst01-dsize,
DATA:v_update_flag TYPE c .                                   "flag for updating infotype 41 last appraisal date
DATA: v_gd_buffer TYPE string.
DATA: BEGIN OF it_final1 OCCURS 0 ,
        supervisor      TYPE persno ,
        pernr           TYPE persno ,
        ename           TYPE pa0001-ename ,
        subgroup        TYPE persk ,
        stext           TYPE t503t-ptext ,
        lastapp         TYPE dats ,
        lastjob         TYPE dats ,
        email           TYPE ztype,
        darxx(5)        TYPE c,
        progression(1)  TYPE c,
        supervisor_desc(50) TYPE c,
      END OF it_final1 .
DATA:   t_packing_list TYPE sopcklsti1 OCCURS 0 WITH HEADER LINE,
        t_contents TYPE solisti1 OCCURS 0 WITH HEADER LINE,
        t_receivers TYPE somlreci1 OCCURS 0 WITH HEADER LINE,
        t_attachment TYPE solisti1 OCCURS 0 WITH HEADER LINE,
        t_object_header TYPE solisti1 OCCURS 0 WITH HEADER LINE,
        w_cnt TYPE i,
        w_sent_all(1) TYPE c,
        w_doc_data TYPE sodocchgi1 .
DATA: gd_error    TYPE sy-subrc,
      gd_reciever TYPE sy-subrc.
DATA: v_flag TYPE c VALUE '1' .
DATA: BEGIN OF it_final OCCURS 0 ,
        subgroup       TYPE persk ,
        supervisor     TYPE persno ,
        pernr          TYPE persno ,
        ename          TYPE pa0001-ename ,
        stext          TYPE t503t-ptext ,
        lastapp        TYPE dats ,
        lastjob        TYPE dats ,
        email          TYPE ztype,
        progression(1) TYPE c,
        supervisor_desc(50) TYPE c,
      END OF it_final .
DATA:it_t247 TYPE STANDARD TABLE OF t247 WITH HEADER LINE .
DATA: it_email TYPE STANDARD TABLE OF zemail WITH HEADER LINE.
*VARIABLE DECLARATION
DATA: p_date   TYPE sy-datum ,               "excution date
      vl_date  TYPE sy-datum ,
      p_email1 TYPE somlreci1-receiver ,     "receiver
      p_sender TYPE somlreci1-receiver .     "sender
DATA:  w_recsize TYPE i.
DATA: gd_recsize TYPE i.
DATA : vl_nmth TYPE sy-datum.
DATA: v_month(2) TYPE n .
DATA: v_mon_text TYPE t247-ltx .
*START OF SELECTION
START-OF-SELECTION .
  REFRESH t_receivers.
  IMPORT it_final1 it_email p_email1 p_sender p_date vl_nmth FROM MEMORY ID 'MEM'.
  PERFORM get_next_month .
  LOOP AT it_final1 .
    IF  it_final1-progression IS NOT INITIAL.
      MOVE-CORRESPONDING it_final1 TO it_final .
      APPEND it_final .
      CLEAR  it_final .
*   Add the recipients email address
      t_receivers-receiver = it_final1-email.
      t_receivers-rec_type = 'U'.
      t_receivers-com_type = 'INT'.
      t_receivers-notif_del = 'X'.
      t_receivers-notif_ndel = 'X'.
      APPEND t_receivers.
    ENDIF.
  ENDLOOP .
  PERFORM write_output .
*END OF SELECTION
END-OF-SELECTION .
*&      Form  WRITE_OUTPUT
FORM write_output .
  DATA: l_date(14) TYPE c ,
        l_date_temp(14) TYPE c ,
        v_date(10) TYPE c ,
        v_date1(20) TYPE c ,
        v_date1_temp(20) TYPE c ,
        f_date(10) TYPE c.
  DATA: lv_stext TYPE t503t-ptext .
  CLEAR : v_date, v_date1.
  CONCATENATE p_date+4(02) p_date+6(02) p_date+0(04)'.' INTO v_date.
  CONCATENATE v_mon_text p_date+0(4) INTO l_date_temp SEPARATED BY space.
  CONCATENATE l_date_temp '.' INTO l_date.
  CONCATENATE v_mon_text vl_nmth+6(2) INTO v_date1_temp SEPARATED BY space.
  CONCATENATE v_date1_temp ',' INTO v_date1_temp.
  CONCATENATE v_date1_temp vl_nmth(4) INTO v_date1_temp SEPARATED BY space.
  CONCATENATE v_date1_temp '.' INTO v_date1.
  CONDENSE l_date .
  FORMAT INTENSIFIED ON.
  SKIP 4.
  WRITE:/(80) text-001 CENTERED .         "'METROPOLITAN UTILITIES DISTRICT'.
  WRITE:/(80) text-002 CENTERED .         "'OMAHA NEBR.'.
  SKIP 2.
  WRITE:/(80) text-003 CENTERED .        "'Inter-Departmental Communication'.
  FORMAT INTENSIFIED OFF.
  WRITE  :/(80) v_date CENTERED using edit mask '__/__/____'.   " v_date.
  SKIP 2.
  WRITE: /10 text-004.                     "'SUBJECT:   Performance Appraisals and Progression Increase'.
  SKIP 1.
  WRITE: /10 text-005, it_final1-supervisor_desc.  "'TO: Supervisor'.
  SKIP 1.
  WRITE: /10 text-006.                     "'FROM:      Anne M. Undajon, Director of Compensation and Benefits'.
  SKIP 2.
  WRITE:/10 text-007 .                       "'Listed below are the employees in your area who are due a '.
  WRITE:/10 text-008 ,l_date.                "'Performance Appraisal during the month of ',l_date.'.      "v_mon_text , P_date+0(4)
  WRITE:/10 text-009 .                       "'These employees are also eligible for a progression increase.
  WRITE:/10 text-010 .                       "' A performance appraisal form can be found on-line in the MUD '.
  WRITE:/10 text-011 .                       "'template section. The Performance Appraisal is to be completed '
  WRITE:/10 text-012 .                       "'and discussed with the employee by the immediate supervisor.'
  SKIP 2.
  WRITE:/10 text-013.                        "Signed forms should be returned to the Human Resource Department by '.
  WRITE:/10 v_date1.
  SKIP 2 .
  SORT it_final[] BY subgroup .
  LOOP AT it_final .
    CLEAR: lv_stext .
    lv_stext =  it_final-stext.
    AT NEW subgroup .
      TRANSLATE lv_stext TO UPPER CASE .
      WRITE:/(80) lv_stext CENTERED .
      SKIP 2 .
      WRITE: 10 text-014 .                      "'Employee name' .
      WRITE: 32 text-015 .                      "'Job Date' .
      WRITE :44 text-016 .                      "'Last Appraisal' .
      WRITE :59 text-021 .                      "'Employee' .
      WRITE :/10 '--------------------' , 32'----------', 44 '--------------', 59 '--------'.
    ENDAT .
    WRITE:/10 it_final-ename .
    WRITE: 32 it_final-lastjob using edit mask '__/__/____'.
    CONCATENATE it_final-lastapp+4(02) it_final-lastapp+6(02) it_final-lastapp+0(04) INTO f_date.
    WRITE :44 f_date using edit mask '__/__/____'.
    SHIFT it_final-pernr left deleting leading '0'.
    WRITE : 59 it_final-pernr.
    SKIP 2 .
  ENDLOOP.
  SKIP 4.
  WRITE :10 text-017.             "'Anne M. Undajon'.
  FORMAT INTENSIFIED ON.
  WRITE:/10 text-018.              "'Director of Compensation & Benefits'.
  FORMAT INTENSIFIED OFF.
ENDFORM.                    " WRITE_OUTPUT
*&      Form  GET_NEXT_MONTH
FORM get_next_month .
  CLEAR v_month .
  v_month = vl_nmth+4(2).
  REFRESH it_t247 .
  CLEAR it_t247 .
  CALL FUNCTION 'IDWT_READ_MONTH_TEXT'
    EXPORTING
      langu = 'E'
      month = v_month
    IMPORTING
      t247  = it_t247.
  CLEAR v_mon_text .
  v_mon_text = it_t247-ltx .
ENDFORM.                    " GET_NEXT_MONTH
Edited by: Katie Doody on Feb 24, 2010 4:07 PM