COUNT ROWS - Help

Question

My procedure takes in a schema and get some data related to that schema. I want ot count the number of rows for each table and table partition stored in the table object_size_history. I was looking into adding a REF CURSOR so I can loop through the tables, table partitions. The Loop is not working for me. I want to get the count using this syntax: select count(*) FROM <schema name>.<table name> INTO <VARIABLE>. How can I achieve this? I attempted this at the end of the procedure
CREATE OR REPLACE PROCEDURE calc_object_size (v_schema_name  in varchar2) IS
TYPE type_cur IS REF CURSOR;
cur_rows type_cur;
lv_num_rows number := 0;
lv_obj_name varchar2(30);
BEGIN
     INSERT INTO object_size_history (schema_name, object_name, object_type, object_size_mb, count_size_date)
          SELECT OWNER, SEGMENT_NAME, SEGMENT_TYPE, BYTES/(1024*1024), current_timestamp from dba_segments
           WHERE owner = v_schema_name
             AND segment_type IN ('TABLE','INDEX');
     COMMIT;
     INSERT INTO object_size_history (schema_name, object_name, partition_name, object_type, object_size_mb, count_size_date)
          SELECT OWNER, SEGMENT_NAME, partition_name, SEGMENT_TYPE, BYTES/(1024*1024), current_timestamp from dba_segments
           WHERE owner=v_schema_name
             AND segment_type IN ('TABLE PARTITION','INDEX PARTITION');
     COMMIT;
     --Now we need a loop that counts the rows for object_type = tables and table partitions, and inserts the count into the object_size_history
     OPEN cur_rows FOR
          select object_name
          from object_size_history
          where object_type in ('TABLE', 'TABLE PARTITION');
     LOOP
          FETCH cur_rows lv_obj_name
               SELECT count(*) FROM v_schema_name.lv_obj_name
                INTO lv_num_rows;
                UPDATE object_size_history
                  SET object_count = lv_num_rows
                    WHERE object_name = lv_obj_name
                       AND object_type IN ('TABLE', 'TABLE PARTITION');
    END LOOP;
     CLOSE cur_rows;
END;
/

Answer 1

Well your specific syntax error is
FETCH cur_rows INTO lv_obj_name;The whole procedure is a bit of a mess though. You don't need to use a ref cursor for what you are attempting. A normal cursor with the FOR UPDATE OF clause is a better bet. You do have to use dynamic SQL for the other selects, because we can't use a variable in a FROM clause.
something like this...
CREATE OR REPLACE PROCEDURE calc_object_size (v_schema_name in varchar2) IS
    lv_num_rows number := 0;
    lv_obj_name varchar2(30);
    CURSOR tabs IS
     select object_name
     from object_size_history
     where object_type in ('TABLE', 'TABLE PARTITION')
     FOR UPDATE OF object_count;
BEGIN
    INSERT INTO object_size_history (schema_name, object_name, object_type, object_size_mb, count_size_date)
        SELECT OWNER, SEGMENT_NAME, SEGMENT_TYPE, sum(BYTES/(1024*1024)), current_timestamp
        from dba_segments
        WHERE owner = v_schema_name
        AND segment_type IN ('TABLE','INDEX')
        GROUP BY OWNER, SEGMENT_NAME, SEGMENT_TYPE, current_timestamp;
    INSERT INTO object_size_history (schema_name, object_name, partition_name, object_type, object_size_mb, count_size_date)
        SELECT OWNER, SEGMENT_NAME, partition_name, SEGMENT_TYPE, sum(BYTES/(1024*1024)), current_timestamp
        from dba_segments
        WHERE owner=v_schema_name
        AND segment_type IN ('TABLE PARTITION','INDEX PARTITION')
        GROUP BY OWNER, SEGMENT_NAME, SEGMENT_TYPE, current_timestamp;
    OPEN tabs;
    FETCH tabs INTO lv_obj_name;
    LOOP
        EXIT WHEN tabs%NOTFOUND
        EXECUTE IMMEDIATE
             'SELECT count(*) FROM '||v_schema_name||'.'||lv_obj_name
             INTO lv_num_rows;
        UPDATE object_size_history
        SET object_count = lv_num_rows
        WHERE CURRENT OF tabs;
    END LOOP;
    CLOSE tabs;
    COMMIT;
END;
/Cheers, APC