Cursors in Stored Procedures

Question

Hi,
Hope someone can give me few ideas about this:
I have a database table from which I will take each record in a cursor at one time, use that record as IN parameters in a procedure to do modifications on another table and then once it completes it will take the next record from the cursor and execute the procedure again with the new IN parameters from the second record of table1.
Sample Code:
PROCEDURE p_procedure (p_id IN table1.id%TYPE,
p_date IN table1.date%TYPE,
p_code IN table1.code%TYPE) IS
CURSOR c1 IS
SELECT id, date, code
FROM table1
WHERE id = p_id
and date = p_date
and code = p_code;
BEGIN
For crec in c1 LOOP
BEGIN LOOP
UPDATE table2
SET ID = NULL, DATE = NULL, CODE = NULL, PRINT = NULL, TRAN = NULL --updates to columns in table2
WHERE table2.id = p_id
and table2.date = p_date
and table2.code = p_code;
COMMIT;
END LOOP;
END p_procedure;
Is this the right process or is my code wrong???
Thanks
Manoj

Answer 1

What is wrong in having a COMMIT inside a loop? It might only increase the I/O, but the code does work right?The COMMIT says you've finished and can release resources, the loop says you haven't finished and still need them. It's asking for trouble (traditionally in the form of ORA-01555 "Snapshot too old" errors, which confuse developers who thought they were doing the database a favour by saving their work like it was MS Word). It can also complicate restartability, although perversely developers sometimes claim it is necessary in order to allow restarting if a long-running process fails (which it isn't) or to allow monitoring of how far it's got.
At the very least, try COMMIT WRITE BATCH NOWAIT ;)