Dynamically change the value in order by clause (urgent)

Question

Could any one help atall with this.
I have a cursor within a procedure and i want to be able to pass parameter into the procedure so that the record fetched by the cursor can be ordered by the parameter passed in.
For instance
create or replace procedure select_all(p_order_by in varchar2) is
cursor r_cur (c_order_by in varchar2) is
select empno,empname,job,manager,salary
from emp
ordry by c_order_by;
r_rec r_cur%rowtype;
lv_order_by varchar2(30);
begin
lv_order_by := p_order_by;
for r_rec in r_cur(lv_order_by) loop
dbms_output.put_line(empno||empname||job||manager||salary);
end loop;
end;
I have obviously done it as written above but the output is not ordered by the value i passed into the procedure when ran. Is the a better way to achieve the desired result?

Answer 1

I handle dynamic order by using dynamic sql
create or replace procedure select_all
               (p_order_by  in varchar2) is
TYPE               RefCurTyp is REF CURSOR;
CV                    REFCURTYP;
v_sql_stmt  VARCHAR2(4000) ;
r_rec r_cur%rowtype;
BEGIN
  v_sql_stmt := 'select empno,empname,job,manager,salary '||
                            ' from emp ' ||
                            ' ORDER BY '||p_order_by ;
  open CV for v_sql_stmt;
  loop
        fetch CV into r_rec ;
                exit when CV%NotFound;
        dbms_output.put_line(r_rec.empno||' '||r_rec.empname||' '||r_rec.job||' '||r_rec.manager||' '||r_rec.salary);
  end loop;
close CV;
end;