Error while executing Procedure - ORA-06511: PL/SQL: cursor already open

Question

I have successfully compiled the following procedure but when I execute it, following error occurs, please adv.
Thanks and Regards,
Luqman
create or replace
procedure TESTKIBOR
(contno in varchar)
AS
BEGIN
DECLARE cursor c1 is
SELECT * FROM KIBOR_SCHEDULE
WHERE CN=contno;
begin
OPEN C1;
FOR line IN c1 LOOP
update kibor_schedule
set lincome=line.Lincome,
expo=line.eXPO,
pport=line.pPORT
where cn=line.cn
and rno=line.rno;
END LOOP;
COMMIT;
close c1;
END;
END TESTKIBOR;
ERROR at line 1:
ORA-06511: PL/SQL: cursor already open
ORA-06512: at "MKTG.TESTKIBOR", line 6
ORA-06512: at "MKTG.TESTKIBOR", line 10
ORA-06512: at line 1

Answer 1

Hi,
CREATE OR REPLACE PROCEDURE Testkibor
     (contno  IN VARCHAR)
AS
BEGIN
  DECLARE
    CURSOR c1 IS
      SELECT *
      FROM   kibor_schedule
      WHERE  cn = contno;
  BEGIN
--//    OPEN c1; --no need to open if using for loop
    FOR line IN c1 LOOP
      UPDATE kibor_schedule
      SET    lincome = line.lincome,
             expo = line.expo,
             pport = line.pport
      WHERE  cn = line.cn
             AND rno = line.rno;
    END LOOP;
    COMMIT;
--//     CLOSE c1; -- no need for loop  does it for you
  END;
END testkibor;SS