Help needed! AppleScript

Question

Hello Guys.
Am writing a script for the apple migic mouse to use in magicprefs.
I have 1Password and I would to control my login activities with just a click with my migic mouse.
The script below works great with safari, where my keyboard shortcut for 1Password is ⌘@
tell application "Safari"
activate
tell application "System Events"
tell process "Safari"
keystroke "@" using command down -- ⌘@
end tell
end tell
end tell
Now i want this action to work for any running browser (all browers installed like firefox, chrome etc.)
So i extend my script as shown below, but works only with safari.
Can you guys please help me out?
Thanks in advance
if appIsRunning("Safari") then
tell me to safari_login()
else if appIsRunning("Firefox") then
tell me to firefox_login()
else
tell me to auto_login()
end if
on safari_login()
tell application "Safari"
tell application "System Events"
tell process "Safari"
keystroke "@" using command down -- ⌘@
end tell
end tell
end tell
end safari_login
on firefox_login()
tell application "Firefox"
tell application "System Events"
tell process "Firefox"
keystroke "@" using command down -- ⌘@
end tell
end tell
end tell
end firefox_login
on auto_login()
tell application "Safari"
activate
tell application "System Events"
tell process "Safari"
keystroke "@" using command down -- ⌘@
end tell
end tell
end tell
end auto_login
-- functions
on appIsRunning(appName)
tell application "System Events" to (name of processes) contains appName
end appIsRunning
Ernest.

Answer 1

What you haven't said is what the failure state is.
For example, there are at least two ways your script could fail - first in determining which browser is open and secondly in the call to the specific browser.
From the description you can't tell whether the firefox_login() handler is being called at all. That would be the place to start.
Add some debugging code to your script so that you can determine whether the handler is getting called. Once you've determined that you can look at the specifics of the handler if that's where the failure is.