How to make this code more simplified?

Question

hi, is there any possiibilty or logic to simply my code than below one?
here my data is like that in a table
sql>> select * from drawn order by effdate,code desc;
CODE EFFDATE AMT
1 01-JAN-06 30
2 01-JUL-08 100
2 01-JUL-09 150
2 01-OCT-09 160
1 01-OCT-09 50
2 01-FEB-10 200
2 01-MAR-10 250
1 01-MAR-10 80
1 01-APR-10 100
from this my desired output should be:
EXEC DUE_DRAWN ('01-SEP-08');
code effdate amt(1+2)
2 01-SEP-08 130
2 01-JUL-09 180
2 01-OCT-09 210
2 01-FEB-10 250
2 01-MAR-10 330
1 01-APR-10 350
here i want to display total amt as on particular date and with the particular code. if date are same in different code then code 2 will be given as priority . here outputput of amt is amt(code1+code2). so i have written below
code...
PROCEDURE DUE_DRAWN(V_DATE IN DATE) IS
CURSOR C1(V_DATE IN DATE) IS SELECT * from drawn order by effdate,code desc;
PREV_REC C1%ROWTYPE;
CURR_REC C1%ROWTYPE;
V_FDATE DATE;
V_INL_GPY NUMBER(5):=0;
V_BPY     NUMBER(5):=0;
BEGIN
OPEN C1(V_DATE);
FETCH C1 INTO PREV_REC;
V_INL_GPY:=PREV_REC.AMT;
LOOP
     FETCH C1 INTO CURR_REC;
     EXIT WHEN C1%NOTFOUND;
     IF V_DATE > CURR_REC.EFFDATE THEN
          V_FDATE:=V_DATE;
     ELSE
          V_FDATE:=CURR_REC.EFFDATE;
     END IF;
     IF CURR_REC.CODE=2 THEN
          BEGIN
          SELECT AMT INTO V_INL_GPY FROM DRAWN WHERE CODE=1 AND EFFDATE=CURR_REC.EFFDATE;
          EXCEPTION
               WHEN OTHERS THEN
               NULL;
          END ;
          DBMS_OUTPUT.PUT_LINE(CURR_REC.CODE|| ' '||V_FDATE || ' '||(CURR_REC.AMT+V_INL_GPY));
     ELSIF CURR_REC.EFFDATE != PREV_REC.EFFDATE THEN
          SELECT AMT INTO V_BPY FROM DRAWN WHERE CODE=2 AND EFFDATE=(SELECT MAX(EFFDATE) FROM DRAWN
                                                                                                                        WHERE CODE=2 AND EFFDATE<=CURR_REC.EFFDATE);
               DBMS_OUTPUT.PUT_LINE(CURR_REC.CODE|| ' '||V_FDATE || ' '||(CURR_REC.AMT+V_BPY));
          END IF;           
     PREV_REC:=CURR_REC;     
END LOOP;
END;
please tell is there any other way to write this ...
thanks
Edited by: Hi FRNzzz!! on Jun 3, 2010 6:45 PM
Edited by: Hi FRNzzz!! on Jun 3, 2010 7:43 PM
Edited by: Hi FRNzzz!! on Jun 3, 2010 7:44 PM
Edited by: Hi FRNzzz!! on Jun 3, 2010 7:47 PM

Answer 1

The if condition is without an operator
ELSIF CURR_REC.EFFDATE PREV_REC.EFFDATE THENwhat operator did you apply?
When I run your code, with your sample data I get a different output to you, but I assumed a ">" operator for the above condition:
SQL> declare
  2 
  3  V_DATE DATE :=TO_DATE('010908','ddmmyy');
  4  cursor c1 is
  5    select * from drawn order by effdate, code desc;
  6   
  7    PREV_REC  C1%ROWTYPE;
  8    CURR_REC  C1%ROWTYPE;
  9    V_FDATE   DATE;
10    V_INL_GPY NUMBER(5) := 0;
11    V_BPY     NUMBER(5) := 0;
12   
13  begin
14 
15    OPEN C1;
16   
17    FETCH C1 INTO PREV_REC;
18    V_INL_GPY := PREV_REC.AMT;
19   
20    LOOP
21      FETCH C1 INTO CURR_REC;
22      EXIT WHEN C1%NOTFOUND;
23     
24      IF V_DATE > CURR_REC.EFFDATE THEN
25        V_FDATE := V_DATE;
26      ELSE
27        V_FDATE := CURR_REC.EFFDATE;
28      END IF;
29     
30      IF CURR_REC.CODE = 2 THEN
31        BEGIN
32          SELECT  AMT
33          INTO    V_INL_GPY
34          FROM    DRAWN
35          WHERE   CODE    = 1
36          AND     EFFDATE = CURR_REC.EFFDATE;
37   
38        EXCEPTION
39          WHEN OTHERS THEN
40            NULL;
41 
42        END ;
43        DBMS_OUTPUT.PUT_LINE(CURR_REC.CODE || ' ' ||V_FDATE || ' ' || ( (CURR_REC.AMT + V_INL_GPY) * 0.1) );
44 
45      ELSIF CURR_REC.EFFDATE = PREV_REC.EFFDATE THEN
46        SELECT  AMT
47        INTO    V_BPY
48        FROM    DRAWN
49        WHERE   CODE    = 2
50        AND     EFFDATE = (SELECT MAX(EFFDATE)
51                           FROM   DRAWN
52                           WHERE  CODE    = 2
53                           AND    EFFDATE <= CURR_REC.EFFDATE);
54                          
55        DBMS_OUTPUT.PUT_LINE( CURR_REC.CODE|| ' ' || V_FDATE || ' ' || ( (CURR_REC.AMT+V_BPY) * 0.1 ) );
56      END IF;
57 
58      PREV_REC := CURR_REC;
59 
60    END LOOP;
61 
62  END;
63  /
2 01-09-2008 00:00:00 13
2 01-07-2009 00:00:00 18
2 01-10-2009 00:00:00 21
1 01-10-2009 00:00:00 21
2 01-02-2010 00:00:00 25
2 01-03-2010 00:00:00 33
1 01-03-2010 00:00:00 33Also, could you kindly place before and after any code you post.