How to use PL/SQL table

Question

Hi all,
can you guys suggest me how can I use pl/sql tables for the below query to incresing the performance.
DECLARE
    TYPE cur_typ IS REF CURSOR;
    c           cur_typ;
    total_val varchar2(1000);
    sql_stmt varchar2(1000);
    freeform_name NUMBER;
    freeform_id NUMBER;
    imgname_rec EMC_FTW_PREVA.EMC_Image_C_Mungo%rowtype;
    imgval_rec  EMC_FTW_PREVA.EMC_Content_C_Mungo%rowtype;
    CURSOR imgname_cur IS
        select * from EMC_FTW_PREVA.EMC_Image_C_Mungo
        where cs_ownerid in (
                    select id from EMC_FTW_PREVA.EMC_Image_C
                    where updateddate > '01-JUN-13'
                    and path is not null
                    and createddate != updateddate)
        and cs_attrid = (select id from EMC_FTW_PREVA.EMC_ATTRIBUTE where name = 'Image_Upload');
BEGIN
    OPEN imgname_cur;
    LOOP
      FETCH imgname_cur INTO imgname_rec;
      EXIT WHEN imgname_cur%NOTFOUND;
      total_val := 'EMC_Image_C_' || imgname_rec.cs_ownerid;
      sql_stmt := 'SELECT instr(textvalue,''' || total_val || '''), cs_ownerid FROM EMC_FTW_PREVA.EMC_Content_C_Mungo a Where cs_attrid = (select id from EMC_FTW_PREVA.EMC_ATTRIBUTE where name = ' || '''' || 'Body_freeform' || '''' || ')';
        OPEN c FOR sql_stmt;
        LOOP
          FETCH c INTO freeform_id,freeform_name;
          EXIT WHEN c%NOTFOUND;
                                  IF freeform_id > 0 THEN
            dbms_output.put_line (imgname_rec.cs_ownerid || ',' || total_val || ',' || freeform_id || ',' || freeform_name);
                                  END IF;
        END LOOP;
        CLOSE c;     
   END LOOP;
   CLOSE imgname_cur;
END;
Thanks in Advance.

Answer 1

can you guys suggest me how can I use pl/sql tables for the below query to incresing the performance.
There would be absolutely no point at all in improving the performance of code that has NO benefit.
The only result of executing that code is to possibly produce some lines of output AFTER the entire procedure if finished:
dbms_output.put_line (imgname_rec.cs_ownerid || ',' || total_val || ',' || freeform_id || ',' || freeform_name);
So first you need to explain:
1. what PROBLEM you are trying to solve?
2. why you are trying to use PL/SQL code to solve it.
3. why are you using 'slow by slow' (row by row) processing and then, for each row, opening a new cursor to query more data?
You should be using a single query rather than two nested cursors. But that begs the question of what the code is even supposed to be doing since the only output is going to a memory buffer.