I Need Help with the LOGON Built-in

Question

Hello I have the following problem, I have a code implemented in the trigger ON-LOGON I will show them the code.
DECLARE
--Numero de Intentos Permitidos
num_intentos NUMBER :=3;
--Variables de Coneccion
usu VARCHAR2(80);
pass VARCHAR2(80);
conec VARCHAR2(80);
upc VARCHAR2(200);
coneccion BOOLEAN:=FALSE;
--Numero de Erro
num_error NUMBER;
BEGIN     
     --Ciclo que controla el numero de intentos
     FOR i IN 1..num_intentos
     LOOP
     --Muestra la pantalla logon de Oracle Forms
     LOGON_SCREEN;
     --Se recupera los valores de la coneccion.
     usu := GET_APPLICATION_PROPERTY(USERNAME);
     pass := GET_APPLICATION_PROPERTY(PASSWORD);
     conec := GET_APPLICATION_PROPERTY(CONNECT_STRING);
--Digito Cancel
IF NOT FORM_SUCCESS THEN
k_mensajes.push('No es posible establecer la Coneccion, Contacte con el Administrador del Sistema','E');
EXIT;
END IF;
--Se Desconecta cualquier session
LOGOUT;
--Verificamos que los datos de coneccion no esten nulos
IF ((usu IS NULL) AND (pass IS NULL) AND (conec IS NULL)) THEN
     k_mensajes.push('Los Datos para establecer la Coneccion estan incompletos','E');
RETURN;
END IF;
--Realizando la coneccion
IF ((usu IS NOT NULL) AND (pass IS NOT NULL) AND (conec IS NOT NULL)) THEN
     LOGON(usu,pass||'@'||conec,FALSE);
     num_error:=DBMS_ERROR_CODE;     
ELSE
     LOGON(usu,pass,FALSE);
     num_error:=DBMS_ERROR_CODE;
     coneccion :=FALSE;
END IF;     
RETURN;
--Finalizando el Ciclo  
     END LOOP;
     IF NOT coneccion THEN
RAISE FORM_TRIGGER_FAILURE;
END IF;
END;
The problem is that when I capture the the I number of error, I pass it to the ON-ERROR and of there I verify that I number of error it is and I throw the message, but I am not able to contralar the sequence among the triggers.
I will show them the code of the trigger ON-ERROR:
DECLARE
     --Numero de Error
     num_error NUMBER;
BEGIN
     num_error:=DBMS_ERROR_CODE;
--Se Verifica el Tipo de Error
IF num_error= -1017 THEN
     --El Usuario ingreso mal la contraseña
     k_mensajes.push('El Password Ingresado no es Valido.','E');
     LOGON_SCREEN;     
ELSIF num_error= -28000 THEN
     --El Usuario esta Bloqueado
     k_mensajes.push('El Usuario esta Bloqueado, Contacte con el Administrador del Sistema.','E');
ELSIF num_error= -28002 THEN
     --La Contraseña del Usuario ha Expirado
     k_mensajes.push('Su Password va Expirar, favor cambiarla antes de que Expire.','E');
     CALL_FORM (lower('S_SEG_CAMBPASS'),NO_HIDE,DO_REPLACE);
--======> Cuando el valor es 0 indica que la coneccion fue establecida <=====     
ELSIF num_error= 0 OR num_error IS NULL THEN
     NULL;
--======>Cuando el valor es -24309 hay una sesion conectada, se realiza la desconeccion de esa sesion. <======     
ELSIF num_error= -24309 THEN
     NULL;
     LOGOUT;
ELSIF num_error= -1403 THEN
     NULL;
ELSE
     --Si es otro error
     k_mensajes.push('Error al Ingresar '||TO_CHAR(num_error)||', Contacte con el Administrador del Sistema','E');
     NULL;
END IF;
END;
If somebody can help me or to indicate me where this my error, because I need to look for the way to tell to the user that this blocked, or that I enter bad their password.

Answer 1

Hi!
I think this will help us:
declare
   --Numero de Intentos Permitidos  == number of allowed ....
   num_intentos                                 number := 3;
   --Variables de Coneccion  == connection variables
   usu                                          varchar2( 80 );
   pass                                         varchar2( 80 );
   conec                                        varchar2( 80 );
   upc                                          varchar2( 200 );
   coneccion                                    boolean := false;
   num_error                                    number;
begin
   --Ciclo que controla el numero de intentos
   for i in 1 .. num_intentos
   loop
      --show Oracle Forms logon screen
      logon_screen;
      --save connection settings
      usu := get_application_property( username );
      pass := get_application_property( password );
      conec := get_application_property( connect_string );
      -- Exit the loop
      if not form_success
      then
         k_mensajes.push
            ( 'No es posible establecer la Coneccion, Contacte con el Administrador del Sistema'
          , 'E' );
         exit;
      end if;
      -- Disconnect
      logout;
      -- Test for null values
      if (     ( usu is null )
          and ( pass is null )
          and ( conec is null ) )
      then
         k_mensajes.push( 'Los Datos para establecer la Coneccion estan incompletos'
          , 'E' );
         return;
      end if;
      -- now make the connection
      if (     ( usu is not null )
          and ( pass is not null )
          and ( conec is not null ) )
      then
         logon(
            usu
          , pass || '@' || conec
          , false );
         num_error := dbms_error_code;
      else
         logon(
            usu
          , pass
          , false );
         num_error := dbms_error_code;
         coneccion := false;
      end if;
      return;
   end loop;
   if not coneccion
   then
      raise form_trigger_failure;
   end if;
end;And then:
declare
   num_error                                    number;
begin
   num_error := dbms_error_code;
   -- discern error type
   if num_error = -1017
   then
      --password entered is invalid
      k_mensajes.push( 'El Password Ingresado no es Valido.', 'E' );
      logon_screen;
   elsif num_error = -28000
   then
      --user is blocked
      k_mensajes.push
               ( 'El Usuario esta Bloqueado, Contacte con el Administrador del Sistema.'
       , 'E' );
   elsif num_error = -28002
   then
      --password is expired
      k_mensajes.push( 'Su Password va Expirar, favor cambiarla antes de que Expire.'
       , 'E' );
      call_form(
         lower( 'S_SEG_CAMBPASS' )
       , no_hide
       , do_replace );
   --======> 0 means that the connection was succesfully made <=====
   elsif    num_error = 0
         or num_error is null
   then
      null;
   --======>Cuando el valor es -24309 hay una sesion conectada, se realiza la desconeccion de esa sesion. <======
   -- think this means something like 'there is a connection, but we have to end it'
   elsif num_error = -24309
   then
      null;
      logout;
   elsif num_error = -1403
   then
      null;
   else
      --other error
      k_mensajes.push('Error al Ingresar '
         || to_char( num_error )
         || ', Contacte con el Administrador del Sistema'
       , 'E' );
      null;
   end if;
end;In you on-logon trigger you have entered some return statements. These will omit you last segment of code:
   if not coneccion
   then
      raise form_trigger_failure;
   end if;I don't think you want to skip this. but then again, this is a confusing segment as well:
      else
         logon(
            usu
          , pass
          , false );
         num_error := dbms_error_code;
         coneccion := false;
      end if;You make a connection but then you set the variable 'coneccion' to false. Why?
Furthermore, I am not sure that form_success gives you the info you want. It will only tell you whether the very last statement before the call to form_succes, was successfull. In your case, that is
      conec := get_application_property( connect_string );which, I believe, will not fail in your code.
Hope this helps!
Grtx
Remco