Its working just fine but does it look good? Take a look and give me your advice!

Question

I got to say that this is my first finnished labview program, and  it's working fine, almost no problems. But i'm not that shure about
this huge while loop with all its instructions. Normaly a while loop takes 1 ms to iterate once, but this loop takes more than one ms,
I'm using another subVI to catch data up to 5 ms. / sample as output from measurement device to  the while loop in this Sub vi, and then from this sub VI i'm initializing the data value read from the Measurement device, to a global variable that i read in this huge while loop.  I belive that the subVI while loop iterates several times before the huge loop iterates once. Meaby thats why my graphs for the data are plotting more than one data at a time.
Take a look and give your advice, it seems that all the measurements are well. And I don't really got problems with the program when running, exept from small delays when I switch the sample rates.
Regards
Zamzam 
HFZ
Attachments:
WhileLoop.JPG ‏354 KB

Answer 1

I agree with Titou.
Wow!  That's an eye-full. 
There are some functions like setting audio On / Off that may not need to be in there.  Or do they?  You'd have to describe what the loop is supposed to do.  Same comment for the indicator display settings on property nodes.  Do you intend to turn them on/off a number of times during an iteration of the loop?
You should "divide & conquer".  By that I mean, use sub-vi's that are function specific.  As mentionned by Titou, you should have a look at the development guidelines.   Basically, now that you have a working loop, you can improve it by creating some sub-vi's, revisit some items that may  not need to be in the loop.  As a matter of fact, you could create some control & indicators and maybe transform the loop into a sub-vi as well. 
There are many Case Statements that you could convert to sub-vi's and that way, you could eliminate the global variables by using indicators and wiring directly to them.
However, I would have to say that the value for "Write Flow Data" might become unpredictable due to race conditions.  Revisit how the value(s) are set for that one.
But it does look like you had some fun doing this one.  Which is the most important thing.  To have fun implementing solutions with LV.
Happy wiring!
JLV