JDialog dispose() not firing windowClosing()/windowClosed() event

Question

I have a small dialog that has 'OK' and 'CANCEL' buttons. When the user clicks on the 'X' in the top right hand corner to close the window, the windowClosing() event is fired on all listeners. However, calling dipose() when i click on the 'OK' or 'Cancel' buttons does not fire the event. I am sure this should work without a problem but i just cannot see what is going wrong.
Andrew

Answer 1

I'd have to test this, but there's some sort of logic to think that calling hide or dispose would not generate events. What would be the point? You know it's going to be closed, so you should tell anyone who needs to know. You can get the list of listeners and fire your own event if you wanted.
Window.dispose() does fire a window closed event, though.
If you want to simulate closing... This is from code I had written... some of it you can replace as appropriate (isJFrame(), etc).
      * Closes the window based on the window's default close operation. 
      * The reason for this method is, instead of just making the window
      * invisible or disposing it, to rely on either the default close
      * operation (for JFrames or JDialogs) or rely on the window's other
      * listeners to do whatever the application should do on the "window
      * closing" event. 
     private void doClose() {
          int closeOp = getDefaultCloseOperation();
          // send the window listeners a "window closing" event... 
          WindowEvent we = new WindowEvent(getWindow(), WindowEvent.WINDOW_CLOSING, null, 0, 0);
          WindowListener[] wl = getWindow().getWindowListeners();
          for(int i = 0; i < wl.length; i++) {
               // this handler doesn't need to know...
               if(wl[i] == this) {
                    continue;
               wl.windowClosing(we);
          // if still visible, make it not (maybe)...
          if(getWindow().isVisible()) {
               switch(closeOp) {
                    case WindowConstants.HIDE_ON_CLOSE:
                         getWindow().setVisible(false);
                         break;
                    case JFrame.EXIT_ON_CLOSE:
                    case WindowConstants.DISPOSE_ON_CLOSE:
                         getWindow().setVisible(false);
                         getWindow().dispose();
                         break;
                    case WindowConstants.DO_NOTHING_ON_CLOSE:
                    default:
     * Gets the default close operation of the frame or dialog.
     * @return the default close operation
     public int getDefaultCloseOperation() {
          if(isJFrame()) {
               return ((JFrame)getWindow()).getDefaultCloseOperation();
          if(isJDialog()) {
               return ((JDialog)getWindow()).getDefaultCloseOperation();
          // "do nothing" is, for all intents and purposes, the way AWT
          // Frame and Dialog work.
          return WindowConstants.DO_NOTHING_ON_CLOSE;