JPA - One to Many persistence issue

Question

Hi All,
We are facing an issue with one to many relationship persistence using JPA.
We have a one to many relationship between Company and Personnel. When A personnel is created, the company(the parent in the relationship) is selected and that needs to be persisted along with the new Personnel Entity
Find below the Entity Definitions and the code snippet to persist the Entity into the database.
Entity - Company:
@OneToMany(mappedBy = "company", cascade=CascadeType.ALL, fetch = javax.persistence.FetchType.EAGER)
private Collection<Personnel> personnelCollection;
Entity Personnel:
@ManyToOne(optional = true)
private Company company;
public ErrorCode createAndAssignPersonnel(String personnelName, String company, String email, String title, String user)
PersonnelPK personnelPK = new PersonnelPK(personnelName, this.appInfoEJB.getSiteId());
Personnel personnel = new Personnel(personnelPK);
personnel.setEmail(email);
personnel.setTitle(title);
CompanyPK companyPK = new CompanyPK(company, this.appInfoEJB.getSiteId());
Company companyObj = this.companyEJB.find(companyPK);
//Double Wiring the personnel and company records
companyObj.getPersonnelCollection().add(personnel);
personnel.setCompany(companyObj);
//Running merge on the parent entity
em.merge(companyObj);
return ErrorCode.OK;
The personnel entity is being persisted into the database but the company is not getting associated with it. (The company value remains blank)
We are using the Toplink JPA Implementation with Glassfish application server. Any pointers would be greatly appreciated.
Thanks and Regards,
GK
Edited by: user12055063 on Oct 13, 2009 10:05 AM
Edited by: user12055063 on Oct 13, 2009 10:05 AM

Answer 1

Hi All,
Since PERSONNEL and COMPANY both had the SITEID column, we renamed the column in both tables to check if that solves the issue. However, a null company value is still being persisted into the database.
Find below the altered schema:
CREATE TABLE COMPANY
COMPANYNAME VARCHAR(255) NOT NULL,
COMPANYSITEID VARCHAR (255) NOT NULL,
PARENTNAME VARCHAR(255),
PARENTSITEID VARCHAR(255),
ADDRESS VARCHAR(255),
PRIMARY KEY (COMPANYNAME, COMPANYSITEID),
FOREIGN KEY (PARENTNAME, PARENTSITEID) REFERENCES COMPANY (COMPANYNAME, COMPANYSITEID)
CREATE TABLE PERSONNEL
PERSONNELNAME VARCHAR(255) NOT NULL,
PERSONNELSITEID VARCHAR(255) NOT NULL,
COMPANY VARCHAR(255),
EMAIL VARCHAR(255),
TITLE VARCHAR(255),
PRIMARY KEY (PERSONNELNAME, PERSONNELSITEID)
ALTER TABLE PERSONNEL
ADD CONSTRAINT PERCOMPANYCONS FOREIGN KEY (COMPANY, PERSONNELSITEID) REFERENCES COMPANY (COMPANYNAME, COMPANYSITEID);
The corresponding entity classes are as follows:
Personnel:
public class Personnel implements Serializable {
    private static final long serialVersionUID = 1L;
    @EmbeddedId
    protected PersonnelPK personnelPK;
    @Column(name = "EMAIL")
    private String email;
    @Column(name = "TITLE")
    private String title;
    @OneToMany(cascade = CascadeType.ALL, mappedBy = "personnel", fetch = FetchType.EAGER)
    private Collection<Deliverynote> deliverynoteCollection;
    @OneToMany(cascade = CascadeType.ALL, mappedBy = "personnel", fetch = FetchType.EAGER)
    private Collection<Microreader> microreaderCollection;
    @JoinColumns({@JoinColumn(name = "COMPANY", referencedColumnName = "COMPANYNAME"), @JoinColumn(name = "PERSONNELSITEID", referencedColumnName = "COMPANYSITEID", insertable = false, updatable = false)})
    @ManyToOne
    private Company company;
    public Personnel() {
Company:
public class Company implements Serializable {
    private static final long serialVersionUID = 1L;
    @EmbeddedId
    protected CompanyPK companyPK;
    @Column(name = "ADDRESS")
    private String address;
    @OneToMany(mappedBy = "company", fetch = FetchType.EAGER)
    private Collection<Company> companyCollection;
    @JoinColumns({@JoinColumn(name = "PARENTNAME", referencedColumnName = "COMPANYNAME"), @JoinColumn(name = "PARENTSITEID", referencedColumnName = "COMPANYSITEID")})
    @ManyToOne(fetch = FetchType.EAGER)
    private Company company;
    @OneToMany(cascade = CascadeType.ALL, mappedBy = "company", fetch = FetchType.EAGER)
    private Collection<Credential> credentialCollection;
    @OneToMany(cascade = CascadeType.ALL, mappedBy = "company", fetch = FetchType.EAGER)
    private Collection<Personnel> personnelCollection;
    @OneToMany(cascade = CascadeType.ALL, mappedBy = "company", fetch = FetchType.EAGER)
    private Collection<Entityobject> entityobjectCollection;
    public Company() {
    }...The code for persisting the personnel record is as follows:
  public ErrorCode createAndAssignPersonnel(String personnelName, String company, String email, String title, String user)
        Personnel personnel = new Personnel(new PersonnelPK(personnelName, this.appInfoEJB.getSiteId()));
        personnel.setEmail(email);
        personnel.setTitle(title);
        Company companyObj = this.companyEJB.find(new CompanyPK(company, this.appInfoEJB.getSiteId()));
        personnel.setCompany(companyObj);
        companyObj.getPersonnelCollection().add(personnel);
        //em.merge(companyObj);
        em.persist(personnel);
        em.flush();
        return ErrorCode.OK;
    }The SQL queries internally generated as as follows:
INSERT INTO PERSONNEL (TITLE, EMAIL, PERSONNELSITEID, PERSONNELNAME) VALUES (?, ?, ?, ?)
bind => [, , JackOnSite, Tester]
In this case, the company field is not even added in the query.
On deleting the updatable, insertable attributes from the JoinColumns annotation as follows:
@JoinColumns({@JoinColumn(name = "COMPANY", referencedColumnName = "COMPANYNAME"), @JoinColumn(name = "PERSONNELSITEID", referencedColumnName = "COMPANYSITEID" )})
@ManyToOne
private Company company;The following query is generated:
Local Exception Stack:
Exception [TOPLINK-4002] (Oracle TopLink Essentials - 2.0 (Build b58g-fcs (09/07/2007))): oracle.toplink.essentials.exceptions.DatabaseException
Internal Exception: java.sql.SQLSyntaxErrorException: Column name 'PERSONNELSITEID' appears more than once times in the column list of an INSERT statement.
Error Code: -1
Call: INSERT INTO PERSONNEL (TITLE, EMAIL, COMPANY, PERSONNELSITEID, PERSONNELSITEID, PERSONNELNAME) VALUES (?, ?, ?, ?, ?, ?)
bind => [, , Test New, JackOnSite, JackOnSite, Sesi]
Note that in this case, the company is being inserted into the query. However, the PERSONNELSITEID appears twice.
The company table has a foreign key reference to itself and we have tried testing this use case by dropping that constraint without any success.
We would greatly appreciate any pointers/suggestions.
Thanks and Regards,
GK