Looks like a proper update but won't work/oracle 10g

Question

Hi! What seems to be the trouble with this update?. It looks like it is processing something for a long time,
but in the end it doesn't do any updating. (Anyway, SELECT -clause brings up all the data I want.)
UPDATE yhyapu y SET omistaja =
(SELECT substr(c.surname,1,20)||' '||substr(c.firstname, 1,10)
FROM genowner o, gencontactinfo c, yhyapu y WHERE o.gencontactinfoid = c.id
AND y.prounitid = o.objectid AND o.id IN (SELECT MIN(o.id)
FROM genowner o GROUP BY o.objectid));
Thanks! Olli Virta

Answer 1

bluefrog you are wrong...
how, set omistaja in (select....) will slove this issue...????
The subquery will always return more than one record if genowner table contains different objectid.
The solution for this issue is as follows :
1) Use where clause in the inner subquery and for the update statement like
update yhyapu
set
omistaja = ( select substr(c.surname, 1, 20)||' '||substr(c.firstname, 1, 10)
          from genowner o
          , gencontactinfo c
          , yhyapu y
     where o.gencontactinfoid = c.id
     and y.prounitid = o.objectid
     and o.id in ( select min(x.id)
               from genowner x
               where x.objectid = y.prounitid
               and y.prounitid = ?
     ) where prounitid = ?
2) If the update statement wants to get executed for all the records in the table yhyapu then
     update yhyapu yy
          set yy.omistaja =
          ( select substr(c.surname, 1, 20)||' '||substr(c.firstname, 1,10)
               from genowner o
               , gencontactinfo c
, yhyapu y
          where o.gencontactinfoid = c.id
          and y.prounitid = o.objectid
          and o.id = ( select min(x.id)
                    from genowner x
                    where x.object_id= y.prounitid )
          and y.prounitid = yy.prounitid
Hope this will help you Olli Virta...!
Edited by: Hariharan ST on May 26, 2010 7:19 PM