Need help creating text based game in Java

Question

Alright, I'm taking a big leap and I'm jumping a little out of league here. Anyways here are my two classes...I'm sure I've got plenty of errors :-/ One other thing. I have only programmed the battle section of the program so don't worry about the other 5 sections when fixing the code.
import cs1.Keyboard;
public class Knights
    public static void main (String[] args)
        // Object Declaration
        KnightsAccount player1 = new Account (1, 100, 200);
        // variable declarations
        boolean run = true;
        int choice;
        // Game Start
        System.out.println ("Welcome to Knights.");
        System.out.println ("--------------------------------------");
        System.out.println ("You are a level 1 character.  With 100 HP and 200 gold...good luck.");
        System.out.println ();
        while (run == true)
            System.out.println ();
            System.out.println ("Enter the number of the option you would like to do");
            System.out.println ();
            System.out.println ("1. Battle");
            System.out.println ("2. Train");
            System.out.println ("3. Work");
            System.out.println ("4. Rest");
            System.out.println ("5. Stats");
            System.out.println ("6. Quit");
            choice = Keyboard.readInt();
            if (choice == 1)
                player1.battle();
            else if (choice == 2)
                player1.train();
            else if (choice == 3)
                player1.work();
            else if (choice == 4)
                player1.rest();
            else if (choice == 5)
                player1.stats();
            else
                run = false;
}And here is the second class...
import java.util.Random;
public class KnightsAccount
    public String winner;
    public int exp = 0;
    public void Account (int level, int hitPoints, int gold) {}
    public battle ()
        Random generator = new Random();
        int pumpkinHP = 80;
        int playerAttack, pumpkinAttack;
        System.out.println ("Engaged in combat with an Evil Pumpkin!");
        while (hitPoints > 0 && pumpkinHP > 0)
            if (pumpkinHP > 0)
                playerAttack = generator.nextInt(15);
                hitPoints -= playerAttack;
                System.out.println ("Player 1 attacked Evil Pumpkin for " + playerAttack + ".");
                System.out.println ("Evil Pumpkin has " + hitPoints + " HP left.");
            if (pumpkinHP <= 0)
                pumpkinDead();
            if (hitPoints > 0 && !(pumpkinHP <= 0))
                pumpkinAttack = generator.nextInt(12);
                hitPoints -= pumpkinAttack;
                System.out.println ("Evil Pumpkin attacked Player1 for " + pumpkinAttack + ".");
                System.out.println ("Player 1 has " + pumpkinHP + " HP left.");
            if (hitPoints <= 0)
                playerDead();
        return winner;
    private pumpkinDead ()
        System.out.println ("Success!  You have defeated the Evil Pumpkin with " + hitPoints + "HP left!");
        System.out.println ("For you good deed you earned 20 exp.");
        exp += 20;
        return exp;
    private void playersDead ()
        System.out.println ("You have been defeated.  Go home before we pelt melty cheeze at you.");
}Whoever can help me I'd be grateful. I know there are probably a lot of things wrong here. Also if some of you could post your AIM or MSN so that I can get some one on one help on any of the smaller problems I run acrost that would help a lot too.
Duke dollars to whoever helps me ;)
AIM: Trebor DoD
MSN: [email protected]

Answer 1

You should really create a GameCharacter object that contains the
statistics for a character (player or non-player) in the game.
public class GameCharacter {
   private double attackStrength;
   private double defenseStrength;
   private String name;
   private String[] bodyParts;
   private Random = new Random();
public GameCharacter(String name, String[] bodyParts, double attackSt, double defenseSt){
   this.attackStrength = attackSt;
   this.defenseStrength = defenseSt;
   this.bodyParts = bodyParts;
   this.name = name;
// put lots of methods in here to get and set the information
public String getName(){
  return this.name;
public String getRandomBodyPart(){
   return this.bodyParts[random.nextInt(this.bodyParts.length)];
}You then create your "knight" character and your "rabid pumpkin"
character.
Your fight method then just takes two GameCharacter objects and uses
the information they contain to fight the battle.
public void fight(GameCharacter a, GameCharacter b) {
   boolean fightOver = false;
   Random rn = new Random();
   double attackValue;
   while(!fightOver) {
       attackValue = a.getAttackStrength()*rn.nextDouble();
       System.out.println(a.getName()+" attacks "+b.getName()+"'s "+b.getRandomBodyPart()+" for "+attackValue+" points");
}The above is not the fighting loop of course. I just put it in to
demostrate how the fight method can be made generic. It takes any
two characters and uses their defensive and attack information to
calculate the fight outcome. It also uses the descriptions that the characters have
to make the fight more interesting. (the getRandomBodyPart method in
particular)
matfud