Network Game - Adding more players

Question

Hey. i am in the middle of making a network game. I am have a problem with adding new players.
I am not really sure the best way to do this but what I am doing this now is when a player is first created a
string is sent to the server and returns with how many clients there are and then sets a client id based on that result.
In the main class I have a thread running which moves the players that where created (new Players are stored in an arraylist). Whenever a
player moves it sends its id and current position to the server and the server broadcasts it to all clients.
So, when this thread runs it gets the id number that it broadcasted and if it is higher than the arraylist of stored players, then I create a new player,
and add to the arraylist which is then drawn by the paint method.
When i add a new player, I either add it from another computer or run the program again and connect to the server through port and ip address.
Is this the correct way to do this because what is happening is that when a second players tried to join new players keep getting added. If any of this is not clear I will try and
explain it better, sorry
Thanks in advance for any help given,
Marc

Answer 1

if the game is really simple, sure why not. If your game will send a lot of data over the network, then you'll end up in the interesting part of network game programming; how to deal with latency / slow connections. Whole studies have been made out of that subject alone and it is far from easy material to understand, solve and implement.
I would suggest you check out websites such as gamasutra and gamedev.net for discussions on the topic. A good place to get questions answered is here:
http://www.gamedev.net/community/forums/showfaq.asp?forum_id=15
Don't let the fact that it is aimed at C++ scare you away, the information in there mostly applies in general.
because what is happening is that when a second players tried to join new players keep getting addedYes well that would be a bug in your code. Nobody can help you with that until you provide the code that is misbehaving.