Null Pointer and URL parsing

Question

I am trying to write a Bookmark reader to go through bookmarks on a windows machine and let you know if your booksmarks are old and not valid.
Anyway, I am getting a nullpointer and having all sorts of problems. My error comes at line 56. (See below, I will point it out)
import java.io.*;
import java.net.HttpURLConnection;
import java.net.MalformedURLException;
import java.net.URL;
import java.util.Vector;
* Created by IntelliJ IDEA.
* User: mlubrano
* Date: Jan 29, 2003
* Time: 3:01:20 PM
* To change this template use Options | File Templates.
public class LinkMain {
static String desktopDir = System.getProperty("user.home");
static String osName = System.getProperty("os.name");
static String FSEP = System.getProperty("file.separator");
static String workingDir = new File(System.getProperty("user.dir")).getParent().replace('\\', '/');
private Vector bookmarkList = new Vector();
private Vector bookmarkURLs = new Vector();
public static void main(String[] args) {
String rootDir = desktopDir + FSEP + "Favorites" + FSEP;
LinkMain lm = new LinkMain(rootDir);
//lm.recurseDir(rootDir);
LinkMain(String root) {
//LinkHTTPConnect();
//ReadInBookmarks();
recurseDir(root);
ReadInBookmarks();
//read in boookmarks
public void ReadInBookmarks() {
BufferedReader br = null;
for (int i = 0; i < bookmarkList.size(); i++) {
try {
br = new BufferedReader(new FileReader((File)bookmarkList.get(i)));
while(br.ready()) {
String line = new String("");
System.err.println(br.readLine());
line = br.readLine();
//Problem is somewhere in here!!!!!!!!!!!!!!!!!!!!!!!!!!!
if (line.startsWith("URL=")) {
LinkHTTPConnect(line.substring(4).trim());
//System.out.println(line.substring(4).trim());
} catch (FileNotFoundException e) {
e.printStackTrace(); //To change body of catch statement use Options | File Templates.
catch (IOException ioe) {
ioe.printStackTrace();
public void recurseDir(String startDir) {
File[] children = new File(startDir).listFiles();
for (int i = 0; i < children.length; i++) {
if (children.isDirectory())
recurseDir(children[i].getAbsolutePath());
bookmarkList.add(new File(children[i].getAbsolutePath()));
//System.err.println(children[i].getAbsolutePath());
//Connect and get results
public void LinkHTTPConnect(String s) {
try {
URL url = new URL(s);
HttpURLConnection conn = (HttpURLConnection) url.openConnection();
conn.setRequestMethod("HEAD");
conn.connect();
// GET seems to do a better job of locating it
if (conn.getResponseCode() != 200) {
conn = (HttpURLConnection) url.openConnection();
conn.setRequestMethod("GET");
conn.connect();
if (conn.getResponseCode() == 200) {
System.out.println("ok");
//System.out.println(desktopDir);
} else
System.out.println("not found");
} catch (MalformedURLException e) {
System.out.println(e);
} catch (IOException e) {
System.out.println(e);
//Print Results in some format

Answer 1

Oops....
Well it is not looping right... It seems to be looping the right # of times, but not moving on to the next file...
The idea is that is looks through your favorites folder and check to make sure that url is valid.. if you run this..
import java.io.*;
import java.net.HttpURLConnection;
import java.net.MalformedURLException;
import java.net.URL;
import java.util.Vector;
* Created by IntelliJ IDEA.
* User: mlubrano
* Date: Jan 29, 2003
* Time: 3:01:20 PM
* To change this template use Options | File Templates.
public class LinkMain {
  //C:\Documents and Settings\mlubrano
  static String desktopDir = System.getProperty("user.home");
  static String osName = System.getProperty("os.name");
  static String FSEP = System.getProperty("file.separator");
  static String workingDir = new File(System.getProperty("user.dir")).getParent().replace('\\', '/');
  private Vector bookmarkList = new Vector();
  private Vector bookmarkURLs = new Vector();
  public static void main(String[] args) {
    String rootDir = desktopDir + FSEP + "Favorites" + FSEP;
    LinkMain lm = new LinkMain(rootDir);
    //lm.recurseDir(rootDir);
  LinkMain(String root) {
    //LinkHTTPConnect();
    //ReadInBookmarks();
    recurseDir(root);
    ReadInBookmarks();
  //read in boookmarks
  public void ReadInBookmarks() {
    BufferedReader br = null;
    for (int i = 0; i < bookmarkList.size(); i++) {
      try {
        br = new BufferedReader(new FileReader((File) bookmarkList.get(i)));
        while (br.ready()) {
          String line = new String("");
          System.err.println(br.readLine());
          line = br.readLine();
          while (line != null) {
            if (line.startsWith("URL=") && line != null) {
              LinkHTTPConnect(line.substring(4).trim());
              System.out.println(line.substring(4).trim());
      } catch (FileNotFoundException e) {
        e.printStackTrace();  //To change body of catch statement use Options | File Templates.
      } catch (IOException ioe) {
        ioe.printStackTrace();
  public void recurseDir(String startDir) {
    File[] children = new File(startDir).listFiles();
    for (int i = 0; i < children.length; i++) {
      if (children.isDirectory())
recurseDir(children[i].getAbsolutePath());
bookmarkList.add(new File(children[i].getAbsolutePath()));
//System.err.println(children[i].getAbsolutePath());
//Connect and get results
public void LinkHTTPConnect(String s) {
try {
URL url = new URL(s);
HttpURLConnection conn = (HttpURLConnection) url.openConnection();
conn.setRequestMethod("HEAD");
conn.connect();
// GET seems to do a better job of locating it
if (conn.getResponseCode() != 200) {
conn = (HttpURLConnection) url.openConnection();
conn.setRequestMethod("GET");
conn.connect();
if (conn.getResponseCode() == 200) {
System.out.println("ok");
//System.out.println(desktopDir);
} else
System.out.println("not found");
} catch (MalformedURLException e) {
System.out.println(e);
} catch (IOException e) {
System.out.println(e);
//Print Results in some format
It loops through the first file it finds x number of times (x being the total number of files you have)
Thx,
Usul