ORA-00933 error when filtering in grid implementation

Question

Hi,
I am implementing the workshop grid function and set up the SQL statement in dbcontrol
as follows, please note the SQL statement join two tables:
SELECT S.ID,S.SAMPLE_ID,S.SAMPLE_CODE,S.SAMPLE_BATCH,S.SALTCODE
FROM LOPROJ.LO_SAMPLES S,LOPROJ.LO_MASTER_COMPOUND_LIST M
WHERE M.SAMPLE_CODE=S.SAMPLE_CODE AND M.PROJECT_ID = 16337
{sql: filter.getWhereClause ()} {sql: filter.getOrderByClause ()}
and I have code in grid.jsp as following:
<netui-data:basicColumn filterable="true" title="Id" sortable="true"
name="id"/>
<netui-data:basicColumn filterable="true" title="Sample_id" sortable="true"
name="sample_id"/>
<netui-data:basicColumn filterable="true" title="Sample_code"
sortable="true" name="sample_code"/>
<netui-data:basicColumn filterable="true" title="Sample_batch"
sortable="true" name="sample_batch"/>
<netui-data:basicColumn filterable="true" title="Saltcode" sortable="true"
name="saltcode"/>
the data are properly retrieved from the database and rendered in grid view, however,
when I tried to do filter for individual column, I got the following error:
An exception occurred in the action begin
ORA-00933: SQL command not properly ended
I have code in begin action as following,
public Forward begin()
throws Exception
sortFilterService = SortFilterService.getInstance( getRequest() );
allRows = myControl.getAllLoSamples( getSortFilterService().getDatabaseFilter(
getGridName() ) );
allRows.last();
row_count = allRows.getRow();
return new Forward( "grid" );
I am wondering whether the workshop filter class does not apply to joining of
two tables? Any suggestion is appreciated.
Thanks!
Zhenhao

Answer 1

Zhenhao--
At the very least, the SQL statement generated below will have two
WHERE clauses; the substitution {sql: filter.getWhereClause()} will
create a WHERE clause that will be inserted into your SQL after the
previously declared WHERE.
It would probably help here if you changed the getWhereClause()
method to getFilterExpression(), which will just return the expression
without the WHERE keyword.
Hope that helps...
Eddie
Raj Alagumalai wrote:
Zhenhao,
I am currently working on reproducing this. I will get back to once I have
additional information.
Thanks
Raj Alagumalai
WebLogic Workshop Support
"Zhenhao Qi" <[email protected]> wrote in message
news:[email protected]...
Hi,
I am implementing the workshop grid function and set up the SQL statementin dbcontrol
as follows, please note the SQL statement join two tables:
SELECT S.ID,S.SAMPLE_ID,S.SAMPLE_CODE,S.SAMPLE_BATCH,S.SALTCODE
FROM LOPROJ.LO_SAMPLES S,LOPROJ.LO_MASTER_COMPOUND_LIST M
WHERE M.SAMPLE_CODE=S.SAMPLE_CODE AND M.PROJECT_ID = 16337
{sql: filter.getWhereClause ()} {sql: filter.getOrderByClause ()}
and I have code in grid.jsp as following:
<netui-data:basicColumn filterable="true" title="Id"sortable="true"
name="id"/>
<netui-data:basicColumn filterable="true"title="Sample_id" sortable="true"
name="sample_id"/>
<netui-data:basicColumn filterable="true"title="Sample_code"
sortable="true" name="sample_code"/>
<netui-data:basicColumn filterable="true"title="Sample_batch"
sortable="true" name="sample_batch"/>
<netui-data:basicColumn filterable="true" title="Saltcode"sortable="true"
name="saltcode"/>
the data are properly retrieved from the database and rendered in gridview, however,
when I tried to do filter for individual column, I got the followingerror:
An exception occurred in the action begin
ORA-00933: SQL command not properly ended
I have code in begin action as following,
public Forward begin()
throws Exception
sortFilterService = SortFilterService.getInstance( getRequest() );
allRows = myControl.getAllLoSamples(getSortFilterService().getDatabaseFilter(
getGridName() ) );
allRows.last();
row_count = allRows.getRow();
return new Forward( "grid" );
I am wondering whether the workshop filter class does not apply to joiningof
two tables? Any suggestion is appreciated.
Thanks!
Zhenhao