Pl Sql Program - Not working

Question

I have created a below procedure & its compiled properly. When executed the procedure all the values which are picked by cursor is not considered in loop while executing. Cursor is picking 10 rows but in loop only 5 rows are considered. Please check if some one can help me.
CREATE OR REPLACE PROCEDURE xx_test
IS
v_pid varchar2(100);
v_cn varchar2(100);
v_id varchar2(1000);
v_val varchar2(1000);
CURSOR C1
IS
SELECT DISTINCT(product_id),cn
FROM product1,(SELECT column_name cn
FROM all_tab_cols
WHERE table_name = 'PRODUCT1'
AND column_name <> 'PRODUCT_ID'
BEGIN
FOR V1 IN C1
LOOP
FETCH C1
INTO v_pid,v_cn;
dbms_output.put_line('==== '||v_pid||'==== '||v_cn);
EXECUTE IMMEDIATE 'SELECT product_id, DECODE(cnt,1, mx)'||v_cn||'
FROM (SELECT product_id, COUNT (DISTINCT '||v_cn||') cnt, MAX ('||v_cn||') mx
FROM product1
WHERE product_id =:a
GROUP BY product_id)'
INTO v_id,v_val
USING v_pid;
dbms_output.put_line('==== '||v_id||'==== '||v_val);
EXECUTE IMMEDIATE 'UPDATE product2
SET '||v_cn||' = ' ||''''|| v_val ||''''||
' WHERE product_id = :b'
USING v_pid;
dbms_output.put_line('++++ '||v_cn||'++++ '||v_val||'++++ '||v_pid);
END LOOP;
END xx_test;
Cursor query O/P:
Product_id cn
P1     PRODUCT_COLOUR
P1     PRODUCT_NAME
P2     PRODUCT_COLOUR
P2     PRODUCT_NAME
P3     PRODUCT_COLOUR
P3     PRODUCT_NAME
P4     PRODUCT_COLOUR
P4     PRODUCT_NAME
P5     PRODUCT_COLOUR
P5     PRODUCT_NAME
In loop only below are considered
P1     PRODUCT_NAME
P2     PRODUCT_NAME
P3     PRODUCT_NAME
P4     PRODUCT_NAME
P5     PRODUCT_NAME

Answer 1

Hi,
Welcome to Oracle OTN Forums!
I changed your code a little. I think this help you
CREATE OR REPLACE
PROCEDURE xx_test
IS
  v_pid VARCHAR2(100);
  v_cn  VARCHAR2(100);
  v_id  VARCHAR2(1000);
  v_val VARCHAR2(1000);
  CURSOR C1
  IS
    (SELECT product_id, 'PRODUCT_ID'  cn
        FROM product1 );
  BEGIN
    FOR V1 IN C1
    LOOP
      FETCH C1 INTO v_pid, v_cn;
      dbms_output.put_line('==== '||v_pid||'==== '||v_cn);
      EXECUTE IMMEDIATE
      'SELECT product_id, DECODE(COUNT (product_id),1,MAX (product_id))||'''||V_CN||''' as val
        FROM product1
       WHERE product_id =:a
       GROUP BY product_id)' INTO v_id, v_val USING v_pid;
      dbms_output.put_line('==== '||v_id||'==== '||v_val);
      EXECUTE IMMEDIATE 'UPDATE product2 SET '||v_cn||' = ' ||''''|| v_val ||''''|| ' WHERE product_id = :b' USING v_pid;
      dbms_output.put_line('++++ '||v_cn||'++++ '||v_val||'++++ '||v_pid);
    END LOOP;
  END xx_test;