Pls help me out in notifyAll

Question

class Test2 implements Runnable
     static int n=0;
     int a=0;
     Test2(int a)
          this.a=a;
          Thread t = new Thread(this);
          t.start();
     public void run()
          if(a==1)
               producer();
          else
               consumer();               
     synchronized void producer()
          System.out.println("Starting Producer");
          for(int i=0;i<5;i++)
               n++;
               System.out.println("producer n = " + n);
               notifyAll();
               try {Thread.sleep(1000); } catch(Exception e) {}
          notifyAll();
     synchronized void consumer()
          System.out.println("Starting Consumer");
          try {wait(); } catch(InterruptedException e) {System.out.println("interupted...");}
          for(int i=0;i<5;i++)
               System.out.println(Thread.currentThread() + " : n = " + n);
               try {wait(); } catch(InterruptedException e) {System.out.println("interupted...");}
     public static void main(String args[])
          new Test2(1);
          new Test2(0);
          new Test2(0);
}this is my source i'm trying to implement single producer and multiple receiver
the problemis that wait function is called but its not coming out of wait when notifyAll is called pls can someone help me
o/p
starting consumer
starting producer
producer n=1
starting consumer
thread thread-2,5,main : n=1
thread thread-1,5,main : n=1
producer n=2
producer n=3
producer n=4
producer n=5
the consumer is stuck producer produces at 1 second each
i have to press [ctrl+c] to exit.

Answer 1

>
synchronized void producer()
     System.out.println("Starting Producer");
     for(int i=0;i<5;i++)
          n++;
          System.out.println("producer n = " + n);
          notifyAll();
          try {Thread.sleep(1000); } catch(Exception e) {}
     notifyAll();
}wait()'&#105;ng on an object temporarily releases the object monitor. Sleeping does not release any monitors.
EDIT: This is important because the other threads, although notified, will not be able to acquire the monitor until the producer thread releases it.
You should only synchronize around the part that modifies the shared state. The sleep should be outside of that synchronized block.
Edited by: paul.miner on Jan 22, 2008 9:26 AM