Problem with Assocaite Array & Bulk Collect

Question

Hi All,
I encountered compilation error when I executed the following block. Improper reference of elements in associate array ( at var.party_name (r) in the code ) is giving problems. Please help me in correcting it.
Regards,
Kashif
DECLARE
   TYPE record1 IS RECORD (
      party_name           racsf_cust_pre_staging_int.party_name%TYPE,
      shipping_address_1   racsf_cust_pre_staging_int.shipping_address_1%TYPE,
      cust_acct_site_id    racsf_cust_pre_staging_int.cust_acct_site_id%TYPE
   TYPE typ_cust_pre_staging_int IS TABLE OF record1
      INDEX BY BINARY_INTEGER;
   var   typ_cust_pre_staging_int;
BEGIN
   SELECT party_name,
          shipping_address_1,
          cust_acct_site_id
   BULK COLLECT INTO var
     FROM racsf_cust_pre_staging_int;
   FORALL r IN var.FIRST .. var.LAST
      UPDATE racsf_cust_pre_staging_int
         SET party_name = var.party_name (r),
             shipping_address_1 = var.shipping_address_1 (r)
       WHERE cust_acct_site_id = var.cust_acct_site_id (r);
END;

Answer 1

I thought if i collect BULK collect and update all records, it will avoid context switching b/w SQL & PL/SQL engines and decrease the execution time.Right idea to get rid of FOR loop
But if you can do in a single SQL statement and avoid collections that is best.
How many records in the collection?
Use LIMIT if necessary as already mentioned - 500 to 1000 might be a sensible limit
I believe this is representative of your current error (I'm using insert and new table for simplicity):
SQL> create table t
  2  (col1 number
  3  ,col2 number);
Table created.
SQL>
SQL> declare
  2   cursor c_t
  3   is
  4     select rownum col1, rownum col2
  5     from   dual
  6     connect by rownum <= 10000;
  7   type tt_t is table of t%rowtype index by pls_integer;
  8   v_t  tt_t;
  9  begin
10    open c_t;
11    loop
12        fetch c_t bulk collect into v_t limit 1000;
13        exit when v_t.count = 0;
14        forall i in 1 .. v_t.count
15          insert into t
16          (col1,col2)
17          values
18          (v_t.col1(i), v_t.col2(i));
19    end loop;
20  end;
21  /
        (v_t.col1(i), v_t.col2(i));
ERROR at line 18:
ORA-06550: line 18, column 14:
PLS-00302: component 'COL1' must be declared
ORA-06550: line 18, column 27:
PLS-00302: component 'COL2' must be declared
ORA-06550: line 18, column 27:
PLS-00302: component 'COL2' must be declared
ORA-06550: line 18, column 23:
PL/SQL: ORA-00904: "V_T"."COL2": invalid identifier
ORA-06550: line 15, column 9:
PL/SQL: SQL Statement ignored
SQL> If you change to the following you will run into PLS-00436 - a right PITA.
SQL> declare
  2   cursor c_t
  3   is
  4     select rownum col1, rownum col2
  5     from   dual
  6     connect by rownum <= 10000;
  7   type tt_t is table of t%rowtype index by pls_integer;
  8   v_t  tt_t;
  9  begin
10    open c_t;
11    loop
12        fetch c_t bulk collect into v_t limit 1000;
13        exit when v_t.count = 0;
14        forall i in 1 .. v_t.count
15          insert into t
16          (col1,col2)
17          values
18          (v_t(i).col1, v_t(i).col2);
19    end loop;
20  end;
21  /
        (v_t(i).col1, v_t(i).col2);
ERROR at line 18:
ORA-06550: line 18, column 10:
PLS-00436: implementation restriction: cannot reference fields of BULK In-BIND table of records
ORA-06550: line 18, column 10:
PLS-00382: expression is of wrong type
ORA-06550: line 18, column 23:
PLS-00436: implementation restriction: cannot reference fields of BULK In-BIND table of records
ORA-06550: line 18, column 23:
PLS-00382: expression is of wrong type
ORA-06550: line 18, column 10:
PL/SQL: ORA-22806: not an object or REF
ORA-06550: line 15, column 9:
PL/SQL: SQL Statement ignoredFor workarounds other than using single arrays per column, see Adrian Billington's article here:
http://www.oracle-developer.net/display.php?id=410
Easiest solution is one array per column:
SQL> declare
  2   cursor c_t
  3   is
  4     select rownum col1, rownum col2
  5     from   dual
  6     connect by rownum <= 10000;
  7   type tt_t1 is table of t.col1%type index by pls_integer;
  8   type tt_t2 is table of t.col2%type index by pls_integer;
  9   v_t1  tt_t1;
10   v_t2  tt_t2;
11  begin
12    open c_t;
13    loop
14        fetch c_t bulk collect into v_t1,v_t2 limit 1000;
15        exit when v_t1.count = 0;
16        forall i in 1 .. v_t1.count
17          insert into t
18          (col1,col2)
19          values
20          (v_t1(i), v_t2(i));
21    end loop;
22  end;
23  /
PL/SQL procedure successfully completed.
SQL> Best solution would have been a single piece of SQL:
SQL>    insert into t
  2     (col1,col2)
  3     select rownum col1, rownum col2
  4     from   dual
  5     connect by rownum <= 10000
  6  /
10000 rows created.
SQL>