PROBLUM IN UPDATE WITH CURSOR

Question

Hi All
I have a table a
SQL> select * from a;
A                   B          C          D
vikas               6        100          0
vikas               6        101          0
manoj             500        102          0
manoj               6        103          0
p                 400        104          0
VIKAS               6        105          0and i wrote a cursor to update the column d either by b or c whichever is greater
DECLARE
         ae NUMBER;
         ad number;
         dd number;
         cursor c1 is select b,c from a ;
BEGIN
       open c1;
LOOP
       fetch c1 into ae,ad;
       IF ae>ad THEN
          update A
          set d=ae;
       ELSE
          UPDATE A
          set d=ad;
       END IF;
             exit when c1%notfound;
END LOOP;
        CLOSE c1;
    END;BUT the result is
d become 105 for all rows
Please Guide
Thanks And Regards
vikas

Answer 1

Hi Try this
This this the table data
A     B     C     D
vikas     6     100     0
vike     6     101     0
manoj 500 102     0
mnj     6     103     0
P     6     104     0
VIKAS 400 105     0
This is the block
declare
aa t1.a%type;
bb t1.b%type;
cc t1.c%type;
dd t1.b%type;
v_number number :=0;
cursor c1 is select a,b,c from t1;
begin
open c1;
loop
fetch c1 into aa,bb,cc;
if bb < cc then
update t1 set d=cc where a=aa;
else
update t1 set d=bb where a=aa;
v_number :=V_number+1;
commit;
end if;
exit when c1%notfound;
end loop;
close c1;
commit;
end;
After execution the result is
A     B     C     D
vikas     6     100     100
vike     6     101     101
manoj 500     102     500
mnj     6     103     103
P     6     104     104
VIKAS 400     105     400
Hopes this helps you
thanks & Regards
Srikkanth.M
Edited by: Srikkanth.M on May 11, 2011 4:22 PM