Query for multiple selected vendors

Question

Hi All,
I have 2 tables:
1) TNS SITE 2) Vendors having 2 columns (TNS SITE ID and Vendor Name(ABC, DeF,GHI))
I need a query where I pass the vendor from a select list with values(ABC, Def,GHI) and the records from TNS SITE should come accordingly. I have prepared one:
SELECT
A.ROW_ID ,
A.BCE_CODE,
A.TNS_SITE_ID,
RTRIM(DECODE(ABC.V_TNS_SITE_SK, null, '', 'ABC, ') ||
DECODE(DEF.V_TNS_SITE_SK, null, '', 'DeF, ') ||
DECODE(GHI.V_TNS_SITE_SK, null, '', 'GHI'),', ') VENDORS
FROM
TNS_SITE A
LEFT OUTER JOIN TNS_SITE_VENDORS ABC ON
A.S_ROW_ID=ABC.V_TNS_SITE_SK AND ABC.V_SITE_VENDOR ='ABC'
LEFT OUTER JOIN TNS_SITE_VENDORS DEF ON
A.S_ROW_ID=DEF.V_TNS_SITE_SK AND DEF.V_SITE_VENDOR ='DeF'
LEFT OUTER JOIN TNS_SITE_VENDORS GHI ON
A.S_ROW_ID=GHI.V_TNS_SITE_SK AND GHI.V_SITE_VENDOR ='GHI'
WHERE
(:P4_TNS_VENDORS IS NOT NULL
AND (((INSTR(:P4_TNS_VENDORS,'ABC') > -1) AND (ABC.V_TNS_SITE_SK IS NOT NULL))
OR ((INSTR(:P4_TNS_VENDORS,'DeF') > -1) AND (DEF.V_TNS_SITE_SK IS NOT NULL))
OR ((INSTR(:P4_TNS_VENDORS,'GHI') > -1) AND (GHI.V_TNS_SITE_SK IS NOT NULL))))
OR
(:P4_TNS_VENDORS IS NULL)
order by A.TNS_SITE_ID
But its not working and gives me all the records. Please help.

Answer 1

I think you're saying that the user will choose a vendor name from a Select list, then you want to show the records that match. Or if they haven't selected from the Select list, show all. Right?
In this instance, I think your problem is that your INSTR operators should compare against 0, not -1. That's what Oracle returns if it doesn't find a match.
Trying to put it gently, unless I'm totally misunderstanding your needs, you could greatly simplify the query by learning more about the various operators you can use in your WHERE clause.
For example, I don't understand why you have 3 LEFT OUTER JOINs instead of 1 and use the IN clause.
You also haven't explained enough about your data for us to know if v_tns_site_sk is ever null.
Good luck,
Stew