Reg procedures and cursors

Question

Hello,
I am getting errors when i am trying to run the foll pl/sql pgm in oracle 10g.
the question is
a PL/SQL block wrapper with cursor, exception, and a function or procedure, computing the amount that the customer spent on books, and generating corresponding gift promotion. This function or procedure should accept the gift name as input parameter; output the number of customers who are qualified to get the gift, and the average amount that these customers spend. Note you need to create a table in the program which records the gift distribution condition in advance. The new table’s structure is as below:
giftStatistics (
gift varchar2(15);
numberOfCustomers number;
averageAmount number
Where numberOfCustomers refers to the number of customers who should be given with this gift; averageAmount refers to the amount that the customers spent, who should be given with this gift.
If the gift name is not in the promotion table, the program need to generate exception; if the tuple concerning the gift is not generated yet, the program need to insert a new tuple; otherwise, the program just need to output the tuple.
My program:
create or replace procedure gift(in_name in varchar2,out_noc out number)
AS
cursor check_gift is
select gift,minretail,maxretail from promotion;
cursor gift_noduplicate is
select gift,numberofcustomers,averageamount from giftstatistics;
cursor cursor_gift is
select c.lastname,sum(i.quantity*b.retail) from
     customers c,orders o,orderitems i,books b
     where c.customer# = o.customer#
          and o.order# = i.order#
          and i.isbn = b.isbn
               group by c.lastname;
count_customers number := 0;
count_average number := 0;
gift_name varchar2(20);
min_retail number(5,2);
max_retail number(5,2);
l_name varchar2(20);
gift_value number(5,2);
gift_local varchar2(30);
noc number(5,2);
avg number(5,2);
BEGIN
open check_gift;
loop
FETCH check_gift into gift_name,min_retail,max_retail;
exit when check_gift%NOTFOUND;
loop
open gift_noduplicate;
     fetch gift_noduplicate into gift_local,noc,avg;
          exit when gift_noduplicate%notfound;
if (gift_name=gift_local) then      
loop
open cursor_gift;
     FETCH cursor_gift into l_name,gift_value;
     exit when cursor_gift%NOTFOUND;
loop
if gift_value >= min_retail AND gift_value <= max_retail THEN
count_customers := count_customers + 1;
count_average := count_average +gift_value;
     update giftstatistics
     set numberofcustomer:=count_customers,
     set averageamount:=count_average;
end if;
END LOOP;
end loop;
else
insert into giftstatistics values(gift_local,count_customers,count_average);
end loop;
END LOOP;
close check_gift;
close gift_noduplicate;
close cursor_gift;
EXCEPTION
WHEN OTHERS
THEN
DBMS_OUTPUT.PUT_LINE('Invalid requests');
END gift;
Could you please help me with this?
Thank you
Vinay

Answer 1

Vinay,
update giftstatistics
set numberofcustomer:=count_customers,
set averageamount:=count_average;use = in an update statement not :=
and, do you want a 'where' clause in this update so all rows are not updated?
hope this helps,
Peter