Resource Manager in Cloud Control 12c still available?
Hi ,
is the Resource Manager in Cloud Control 12c still available? The Resource Manager could be found in Grid Control 10g under the tab Database -> Administration.
Rgds
JH
Yes, in EM 12c you can navigate to the "Getting Started with Database Resource Manager" page by selecting Resource Manager from the Administration drop-down list in a database homepage. I believe, in EM 10g the Resource Manager link is in the Server tab.
Regards,
- Loc
Similar Messages
-
Install Cloud Control 12c High Availability
Good day,
I am installing cloud control high availibility, but when i install the Third Party Certificate the services are not available when I check for HTTP.
I followed the following guidelines:
Deploying a Highly Available Enterprise Manager 12c Cloud Control:
http://www.oracle.com/technetwork/oem/framework-infra/wp-em12c-building-ha-level3-1631423.pdf
And configuration Third Party Certificate, note:
NOTE:1399293.1 - EM 12c Cloud Control How to Create a Wallet With Third Party Trusted Certificate that Can Be Imported into the OMS For SSL Comunication?
I have a couple of questions
How i can to change the CA in OMS?
How export the certificate and key?
Can anyone help me, please,
Best Regards,
Alexandra Granadoshi,
Please follow the below procedure..
EM11g / EM12c : Using ORAPKI Utility to Create a Wallet with Third Party Trusted Certificate and Import into OMS [ID 1367988.1] -
How to find out Oracle Enterprise Manager Cloud Control 12c Home page
Hi all,
I have a PROD environment with OEM Cloud Control 12c and I do know its home page, but today I was wondering, what if I do not know the environment where could I get this info.
So I tried to find it out on Oracle docs and on the internet, on my environment but I was not able to find this info.
Could you guys help me?
Thanks in advance.Hi ,
The easiest way is to run emctl status oms -details command from OMS_HOME/bin and check for the value for Console URL
example
$ emctl status oms -details
Oracle Enterprise Manager Cloud Control 12c Release 2
Copyright (c) 1996, 2012 Oracle Corporation. All rights reserved.
Enter Enterprise Manager Root (SYSMAN) Password :
Console Server Host : myomshost.mydomain.com
HTTP Console Port : 7789
HTTPS Console Port : 7801
HTTP Upload Port : 4890
HTTPS Upload Port : 4901
EM Instance Home : /u01/app/oracle/product/Middleware12cR2/gc_inst/em/EMGC_OMS1
OMS Log Directory Location : /u01/app/oracle/product/Middleware12cR2/gc_inst/em/EMGC_OMS1/sysman/log
OMS is not configured with SLB or virtual hostname
Agent Upload is locked.
OMS Console is locked.
Active CA ID: 1
Console URL: https://myomshost.mydomain.com:7801/em
Upload URL: https://myomshost.mydomain.com:4901/empbs/upload
WLS Domain Information
Domain Name : GCDomain
Admin Server Host: myomshost.mydomain.com
Managed Server Information
Managed Server Instance Name: EMGC_OMS1
Managed Server Instance Host: myomshost.mydomain.com
WebTier is Up
Oracle Management Server is Up
Other way is to check in the <OMS_HOME>/install/setupinfo.txt file and check for Enterprise Manager Cloud Control URL
Regards,
Rahul -
Oracle VM and Oracle VM Template for Enterprise Manager Cloud Control 12c M
Hello!
After installation of *"Oracle VM 3.1.1 Media Pack v1 for x86_64 (64 bit)"* to bare hardware
can I install Oracle VM Template for Enterprise Manager Cloud Control 12c Media Pack ?
Is it the wrong plan ?
What to do if I need to set VLAN №1 ? (according note of installer I have to choose number between 2 and 4094 )
Thanks and regards,
Pavel
Edited by: Pavel on Jul 30, 2012 5:01 AMYes, you can install Oracle VM Manager, create a server pool with the one parent Oracle VM server in it, and then deploy the Oracle VM template in the pool. Once EM VM is up and running, you can register the same Oracle VM Manager with EM, to manage the pool.
In general, it is not recommended that you use the OVM server backend directly. But for bootstrapping the EM environment, you can also try the following:
Download the OVM Template on the Oracle VM server. From the OVM server terminal itself you can do "xm create" to spin a new virtual machine using the Oracle VM teamplate. Once the VM comes up, VNC into the VM and configure the EM OMS and agent. -
Oracle VM Template for Enterprise Manager Cloud Control 12c Media Pack v1
Hello
I download Oracle VM Template for Enterprise Manager Cloud Control 12c Media Pack v1
I was checking the structure and I found this
[oracle@em12c bin]$ cd /u01
[oracle@em12c u01]$ ls
app lost+found OracleHomes oracle-template.sh scripts
[oracle@em12c u01]$ cd OracleHomes/
[oracle@em12c OracleHomes]$ ls
checkpoints db11g Middleware
[oracle@em12c OracleHomes]$ pwd
/u01/OracleHomes
[oracle@em12c OracleHomes]$ cd db11g/
[oracle@em12c db11g]$ ls
admin cfgtoollogs checkpoints diag fast_recovery_area oradata product
[oracle@em12c db11g]$ cd ..
[oracle@em12c OracleHomes]$ cd Middleware/
[oracle@em12c Middleware]$ ls
[oracle@em12c Middleware]$
The Database has all binaries but Middleware is empty
Same body knows about this issue.
RegardsYes, you can install Oracle VM Manager, create a server pool with the one parent Oracle VM server in it, and then deploy the Oracle VM template in the pool. Once EM VM is up and running, you can register the same Oracle VM Manager with EM, to manage the pool.
In general, it is not recommended that you use the OVM server backend directly. But for bootstrapping the EM environment, you can also try the following:
Download the OVM Template on the Oracle VM server. From the OVM server terminal itself you can do "xm create" to spin a new virtual machine using the Oracle VM teamplate. Once the VM comes up, VNC into the VM and configure the EM OMS and agent. -
Dbcontrol migrate to enterprise manager cloud control 12c
Currently we are using Oracle 11gR2 database in our enterprise and manage them with EM database control.
We're planning to migrate to centralized management with oracle enterprise manager cloud control 12c.
Is it possible to manage DBs both ways, with db control AND using EMCC agent simultaneously?
Is there a easy way to migrate db control managed DBs to be managed by agent?
I've searched EM documentation but didn't find any topic about this job.Hi P2
Yes You can manage DB from both. But why you are going to use EM instead of Cloud Control 12. You Can do each and every work from it more tan EM. Cloud Control 12c is very good tool.
No. But You can easily setup them using manual agent push or auto discovery method from cloud control 12c. You need to create password less ssh login to both side for oracle user and open the relevant ports from network. It is very easy. After add agent you can add targets from relevant hosts easily.
Thanks
Dilshan
Edited by: user11923797 on Dec 24, 2012 10:39 AM -
Cloud control 12c and management agent 11.1
Hello everyone!
I have installed oracle cloud control 12c (12.1.0.2) on Win platform.
and it does not have an access to the internet yet.
I have database targets only on Linux hosts. In my case CC does not have approriate Agent software for linux hosts.
So the question is :
How can I configure cloud control with datbases hosts on linux ?
Can I use 11.1 agent software ?
Thanks.1- For CC 12c you have to use 12c agents. Lower agent versions will not work.
2- A " how to" on downloading agent software and adding it to your OMS can be found here: http://www.gokhanatil.com/2012/03/how-to-download-new-agent-software-for-oracle-cloud-control-12c-in-offline-mode.html
Push the agent to *UX servers: http://www.gokhanatil.com/2011/10/how-to-deploy-oracle-management-agent.html
If you want to push the agent to the Linux servers you have to install CYGWIN on the (Windows) OMS server.
Eric -
EM Cloud Control 12c has no databases
Hello @ all,
i've installed Enterprise Manager Cloud Control 12.1.0.2.0 on a virtual machine with RedHat Linux 6 and configured the EM by installing it so, that he should connect to my test database server with Oracle 11g 11.2.0.3.0 to watch over that. The installer get a valid connection to that database server.
Now, after install, i want to test the connection. So i started the Overview of EMCC in my browser, connected as SYSMAN, selected the "Database Home" and at the frame "Database Loadmap" there displays the message "no databases available". But the database at the test server is running without any problem:
lsnrctl status
LSNRCTL for Linux: Version 11.2.0.3.0 - Production on 07-JUN-2013 09:39:52
Copyright (c) 1991, 2011, Oracle. All rights reserved.
Connecting to (DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=dbtest2.berl.axway.int)(PORT=1521)))
STATUS of the LISTENER
Alias LISTENER
Version TNSLSNR for Linux: Version 11.2.0.3.0 - Production
Start Date 17-MAY-2013 10:05:48
Uptime 20 days 23 hr. 34 min. 3 sec
Trace Level off
Security ON: Local OS Authentication
SNMP OFF
Listener Parameter File /home/oracle/srv/ora/product/11.2.0/dbtest_2/network/admin/listener.ora
Listener Log File /home/oracle/srv/ora/diag/tnslsnr/dbtest2/listener/alert/log.xml
Listening Endpoints Summary...
(DESCRIPTION=(ADDRESS=(PROTOCOL=tcp)(HOST=dbtest2.berl.axway.int)(PORT=1521)))
(DESCRIPTION=(ADDRESS=(PROTOCOL=ipc)(KEY=EXTPROC1521)))
(DESCRIPTION=(ADDRESS=(PROTOCOL=tcp)(HOST=dbtest2.berl.axway.int)(PORT=8080))(Presentation=HTTP)(Session=RAW))
Services Summary...
Service "<hostname>" has 1 instance(s).
Instance "<hostname>", status READY, has 1 handler(s) for this service...
Service "<hostname>" has 1 instance(s).
Instance "dbtest2", status READY, has 1 handler(s) for this service...
The command completed successfully
SQL> select * from v$instance;
INSTANCE_NUMBER INSTANCE_NAME HOST_NAME VERSION STARTUP_TIME STATUS PAR THREAD# ARCHIVE LOG_SWITCH_WAIT LOGINS SHU DATABASE_STATUS INSTANCE_ROLE ACTIVE_ST BLO
1 dbtest2 dbtest2 11.2.0.3.0 06/06/2013 09:51:08 OPEN NO 1 STARTED ALLOWED NO ACTIVE PRIMARY_INSTANCE NORMAL NOAlso the agent of EMCC is running too:
./emctl status agent
Oracle Enterprise Manager Cloud Control 12c Release 2
Copyright (c) 1996, 2012 Oracle Corporation. All rights reserved.
Agent Version : 12.1.0.2.0
OMS Version : (unknown)
Protocol Version : 12.1.0.1.0
Agent Home : /path/to/agent_inst
Agent Binaries : /path/to/oracle/agent/core/12.1.0.2.0
Agent Process ID : 2814
Parent Process ID : 2768
Agent URL : https://<hostname>:3872/emd/main/
Repository URL : https://<hostname>:4903/empbs/upload
Started at : 2013-06-07 11:18:13
Started by user : oracle
Last Reload : (none)
Last successful upload : (none)
Last attempted upload : 2013-06-07 11:18:36
Total Megabytes of XML files uploaded so far : 0
Number of XML files pending upload : 73
Size of XML files pending upload(MB) : 0,27
Available disk space on upload filesystem : 45,74%
Collection Status : Collections enabled
Heartbeat Status : Agent is blocked
Last attempted heartbeat to OMS : 2013-06-07 11:39:36
Last successful heartbeat to OMS : (none)
Next scheduled heartbeat to OMS : 2013-06-07 11:42:36
Agent is Running and ReadySo what could i do more to find out the problem? Which logs would you need for more information?
Thanks a lot and best regards,
DavidAfter some minutes he was ready with resyncronisation. But now the EM Console told me, that the agent woulnd't be available.
So i looked for it:
emctl status agent
Oracle Enterprise Manager Cloud Control 12c Release 2
Copyright (c) 1996, 2012 Oracle Corporation. All rights reserved.
Agent Version : 12.1.0.2.0
OMS Version : 12.1.0.2.0
Protocol Version : 12.1.0.1.0
Agent Home : /path/to/oracle/agent/agent_inst
Agent Binaries : /path/to/oracle/agent/core/12.1.0.2.0
Agent Process ID : 4529
Parent Process ID : 4483
Agent URL : https://<hostname>:3872/emd/main/
Repository URL : https://<hostname>:4903/empbs/upload
Started at : 2013-06-07 14:32:22
Started by user : oracle
Last Reload : (none)
Last successful upload : 2013-06-07 14:53:07
Last attempted upload : 2013-06-07 14:53:12
Total Megabytes of XML files uploaded so far : 0,09
Number of XML files pending upload : 13
Size of XML files pending upload(MB) : 0,01
Available disk space on upload filesystem : 45,32%
Collection Status : Collections enabled
Heartbeat Status : Ok
Last attempted heartbeat to OMS : 2013-06-07 14:52:28
Last successful heartbeat to OMS : 2013-06-07 14:52:28
Next scheduled heartbeat to OMS : 2013-06-07 14:53:28
Agent is Running and ReadyAlso a ping to OMS is successfully:
emctl pingOMS
Oracle Enterprise Manager Cloud Control 12c Release 2
Copyright (c) 1996, 2012 Oracle Corporation. All rights reserved.
EMD pingOMS completed successfullyEmctl upload says the same:
emctl upload
Oracle Enterprise Manager Cloud Control 12c Release 2
Copyright (c) 1996, 2012 Oracle Corporation. All rights reserved.
EMD upload completed successfullyBut why is the agent now not available?
EDIT: i've restarted the agent and now he is up!!! Yes!
But in home screen he also tels me, that he can't find a database :(
Edited by: David_Pasternak on 07.06.2013 03:59 -
Oracle Cloud Control 12c and licensing
Hey Guys, Can someone please elucidate on the Cloud Control 12c licensing requirements?
Following are all the licenses we currently hold:
1. Oracle Enterprise Edition DB
2. Oracle RAC
3. Oracle Active Data Guard
4. Diagnostic and Tuning Pack
5. Partitioning Option
6. Advanced Security Option
7. GoldenGate
My understanding is that I could install and access Grid/Cloud control as long as I have the Diagnostic and Tuning Pack - and of course to all products we are licensed for.
Questions:
1. Do I need any license for Weblogic server?
2. Can I setup OMS in a clustered architecture?
3. Can I have the RAC database for the repository?
4. Can I access the High Availability options - DG etc?
5. Can I administer RAC and GI services from Cloud Control?
I would've thought that as long as I have access to the underlying DB options, Grid/Cloud control can be used to administer over them.
Could someone please help in clearing this up?
Regards
SridharI highly recommend you to read the Enterprise Manager Licensing Information:
http://docs.oracle.com/cd/E24628_01/doc.121/e24474/toc.htm
Quick answers for your questions:
1) No, as long as you use it only for EM
2) Yes you can.
3) You need to buy licenses for RAC option (for both nodes) and DB licenses for second node.
4) You mean accessing DG pages on EM pages right? Yes you can. They do not need any license pack. Btw you can check if a page requires additional licensing using "setup > management packs > packs for the page" menu.
5) Yes you can.
But as I said, it's better to read the licencing document by yourself, and contact Oracle sales for more information. -
How to integrate OPS 12c with EM cloud control 12c
As title. We checked the documents of OPS 12c and didn't find a way to integrate OPS 12c enterprise controller with EM cloud control 12c.
Is it ready now? Where can we download a separate opar for OMS? Any official documents we can reference?
Regards,
Yu WangThere's a ton of things in OC that you can't do in OEM, at least not that I know of. Such as:
OVM Server for Sparc (LDOM) management
S10/S11 zone management
patching Solaris
updating Solaris 11
provisioning Solaris (9, 10, 11)
ABE management
firmware provisioning
If you are an all-Linux shop then you may have an argument but Solaris wise I don't think OEM scratches the surface of OC.
At an even higher level, OEM is more geared for the App layer while OC is more geared for the OS/system/virtualization layer.
My $.02. -
Performance tab in Cloud Control 12c
Hi guyz,
How can I activate Performance tab in EM Cloud Control 12c? Do I need any license or is there light version?
In Grid Control 11g it was easy to activate.
Thank you beforehand.Could you please confirm the Database Diagnostic Pack and Oracle Tuning Pack is enabled for the database.
From the Setup -> Management Pack -> Management Pack Access
To enable the Management Pack for Oracle Database:
From the Setup menu, select Management Packs, then select Management Pack Access.Enterprise Manager Cloud Control displays the Management Pack Access page.
In the Management Pack Access page, from the Search list, select Database ===> It will lists all the Oracle Database targets being monitored.
From the table, for the select your Oracle Database target and enable the Oracle Diagnostics Pack, Oracle Database Tuning Pack and click Apply.
For licensing information on the Oracle Diagnostics Pack and Oracle Tuning Pack
Ref to:
http://docs.oracle.com/cd/E24628_01/doc.121/e24474/toc.htm
Understanding the Management Packs in Enterprise Manager (dbconsole, grid control and cloud control) (Doc ID 1566956.1) -
Deploying Plug-ins in EM Cloud Control 12c
Hi,
I have post a question in Enterprise Manager forum and below is the link:
Deploying Plug-ins in EM Cloud Control 12c
Appreciate your valueable comments.
Regards
PPrem Kumar wrote:
Hi Sybrand,
This is NOT a multi-post. If you could understand plain english, I said, I have posted a question under "Enterprise Manager" forum and also provided a link to MY post. Requested people to answer there. If not completely, it's in-direct way of posting a cross-connected thread. Why did you think that there was a need to post the thread link, related to a different domain in this forum? You had a question related to EM and you posted it in the very thread that belongs to that question so what was the requirement to again pop up that thread over here which has nothing to do with it? And that too, within a minute of posting the original thread! If you thought your question was very "urgent" , you could always raise it to Oracle Support with Sev 1 .
I think you need to learn how to be patient and how to participate in user forums. Well, learn to get corrected and also to respect the guys who are here from a very long time and are extremely knowledgeable.
Aman.... -
Cloud Control 12c: Configuration Details Error
Hi,
I'm currently in the process of installing the Oracle Enterprise Manager Cloud Control 12c, after typing the configuration details (step 5 of 8), I get an error popup window stating the following:
The following prerequisite check failed because the ORacle Database, where the Management Repository will be configured, does not meet the configuration requirements. Fix the issue manually base on the recommendation offered for this prerequisite, and click OK. For more details check the logs: /oraInventory/logs/emdbprereqs
Prereq Name:
Check the compatible instance prarameter value.
Recommendation:
The compatible instance parameter must be set to the same version value as the database instance of the EM repository.
When I check the repos_perf.log, I see the following fails:
Executing Prereq Action
executing Action: select count(*) from v$log where 300000000 > bytes
output: 3
Prerequisite failed
Running component repos_perf Done
Executing component :repos_perf
Running component repos_perf Done
How can I set parameter?
Thanks,
OlivaresHi Olivares,
Assuming your question is about setting the compatible initialization parameter, you can connect to the repository database (e.g. using sqlplus as user system or sys) to execute the following command, then restart the database:
ALTER SYSTEM SET COMPATIBLE = <value> SCOPE=SPFILE;
EX:
ALTER SYSTEM SET COMPATIBLE = '11.2.0.0.0' SCOPE=SPFILE;
If necessary, see the following doc for guidance on the parameter value:
http://docs.oracle.com/cd/E24628_01/install.121/e22624/appdx_about_emprereqkit.htm#CIHHBGFD
Regards,
- Loc -
Cloud Control 12c monitoring Oracle 11g Standard Edition alert.log
Hi guys.
I just installed Cloud Control 12c3 and added my cluster database, I have readed many papers, tech docs and tech discuss and now i have a huge confussion about packs, licensing and other fruits. Please help...
I have four Oracle 11g databases (differents hosts) Standard Edition, and i want monitoring and notificate alert.log errors. For example, if alert.log says "ORA-01438, blablabla" i want a email notification.
I read about packs, and says that "diagnostic pack" is needed for alert.log monitoring in Cloud Control 12c. But my version database is Standard Edition without packs, so I CAN'T MONITORING ALERT LOG!!!.
Question:
Do I really need Diagnostic Pack for monitoring alert.log with Cloud Control?
If Diagnostinc Pack is not necessary, how can i monitoring alert.log?
ThanksI do not think you require any pack for alert.log content monitoring but you might need to check with Oracle rep. I am saying so because if you go to the "Alert log content" page and click on management pack for this page, Grid will display a message that this page does not require any pack.
Go to the Alert log content by "oracle database -> logs -> alert log contents"
then
go to SETUP -> management packs -> packs for this page
You will see the message will be displayed " this pages does not require any pack"
Can you also provide the doc where it says that this pae needs diagnostic pack? -
Cloud control 12c installation on Fedora 13
Hi,
I'm trying to upgrade/migrate from Database Control to Cloud Control 12c on a Fedora 13 server (Out of date, I know - maybe this is the cause of the problem?). I uninstalled Database Control and was installing Cloud Control when I received the following error:
INFO: gcc -o webcached -L/data/oracle/11gr2/app/oracle/middleware/Oracle_WT/webcache/lib/ -L/data/oracle/11gr2/app/oracle/middleware/Oracle_WT/lib/ -L/data/oracle/11gr2/app/oracle/middleware/Oracle_WT/lib/stubs/ main.o libwebcache.a -Wl,-rpath,/data/oracle/11gr2/app/oracle/middleware/Oracle_WT/lib -liau -lnnz11 -lxml11 -lclntsh -lcore11 -lunls11 -lnls11 /data/oracle/11gr2/app/oracle/middleware/Oracle_WT/lib/liboraz.a -ldmsapp -lons `cat /data/oracle/11gr2/app/oracle/middleware/Oracle_WT/lib/sysliblist` -lrt
INFO: -Wl,-rpath,/data/oracle/11gr2/app/oracle/middleware/Oracle_WT/lib -lm `cat /data/oracle/11gr2/app/oracle/middleware/Oracle_WT/lib/sysliblist` -lrt -ldl -lm -L/data/oracle/11gr2/app/oracle/middleware/Oracle_WT/lib
INFO: /
INFO: usr/bin/ld: libwebcache.a(wxsmdms.o): undefined reference to symbol 'yodSensorInvalidate'
/usr/bin/ld: note: 'yodSensorInvalidate' is defined in DSO /data/oracle/11gr2/app/oracle/middleware/Oracle_WT/lib/libdms2.so so try adding it to the linker command line
/data/oracle/11gr2/app/oracle/middleware/Oracle_WT/lib/libdms2.so: could not read symbols: Invalid operation
collect2:
INFO: ld returned 1 exit status
INFO: make: *** [webcached] Error 1
INFO: End output from spawned process.
INFO: ----------------------------------
INFO: Exception thrown from action: make
Exception Name: MakefileException
Exception String: Error in invoking target 'install' of makefile '/data/oracle/11gr2/app/oracle/middleware/Oracle_WT/webcache/lib/ins_calypso.mk'. See '/oracle/11gr2/app/oraInventory/logs/cloneActions2011-10-17_03-48-14-PM.log' for details.
Exception Severity: 1
INFO: POPUP WARNING:Error in invoking target 'install' of makefile '/data/oracle/11gr2/app/oracle/middleware/Oracle_WT/webcache/lib/ins_calypso.mk'. See '/oracle/11gr2/app/oraInventory/logs/cloneActions2011-10-17_03-48-14-PM.log' for details.
Click "Retry" to try again.
Click "Ignore" to ignore this error and go on.
Click "Cancel" to stop this installation.The message provides a suggestion:
try adding it to the linker command lineBut I'm not sure how to add that file to the linker command line. Anyone have any Ideas?
Thanks,
Dan ScottHmm, I think I've managed to answer my own question:
In:
/oracle/11gr2/app/oracle/middleware/Oracle_WT/lib/sysliblist
Add
-ldms2(Including the leading space).
Maybe you are looking for
-
Not able to install CS6 Design and Web upgrade
I bought an upgrade from CS3 Master Collection (which qualifies for the upgrade) to CS6 Design and Web premium. Upon installation it asks me for the CS3 serial number. I put the CS3 serial number and it gives me an error. Do I need to deactivate it C
-
Webpages do not display correctly, but do when i uninstall certain add-ons
i had the firefox add-ons of shaved beiber and adblocker plus. one day, websites such as blaghag, 100boatsin100days, halolz, and other websites using the design of blog posts or main text with extra links alongside, or websites such as equinox kayaks
-
Accounting Principle role in Foreign Currency Valuation
Dear Frns, Why do we create an Accounting Principle in Foreign Currency Valuation and assign the same to the Ledger Group. Regards, Venkata
-
In v.11, how can I capture video but not audio from a camera?
In v.11, how can I capture video but not audio from a camera?
-
Creating mailing labels from an excel worksheet
I have been following the directions using data merge manager. but I only get the first row name in every label on the page. My excel document is a list of names in 1 column. I want to create 1 label for every name. What am I doing wrong?