Strange behavior in JTable using JFileChooser as custom editor

Question

I have an application that I am working on that uses a JFileChooser (customized to select images) as a custom editor for a JTable. The filechooser correctly comes up when I click (single click) on a cell in the table. I can use the filechooser to select an image. When I click on the OPEN button on the filechooser, the cell then displays the editor class name.
I have added prints to the editor methods and have determined that editing is stopped before the JTable adds the listener. I have looked at the code and have searched doc for examples but have not found what I am doing wrong. Can anyone help?
I configured the table editor as follows:
//Set up the editor for the Image cells.
private void setUpPictureEditor(JTable table) {
table.setDefaultEditor(String.class, new PictureChooser());
Below is the code for the JTable editor that I am using:
package com.board;
import java.io.*;
import java.util.Vector;
import java.util.EventObject;
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import javax.swing.JFileChooser;
import javax.swing.JPanel;
import javax.swing.table.TableCellEditor;
import javax.swing.event.CellEditorListener;
import javax.swing.event.ChangeEvent;
public class PictureChooser extends JLabel implements TableCellEditor
boolean DEBUG = true;
int line=0;
static private String newline = "\n";
protected boolean editing;
protected Vector listeners;
protected File originalFile;
protected JFileChooser fc = new JFileChooser("c:\\java\\jpg");
protected File newFile;
public PictureChooser()
super("PictureChooser");
if (DEBUG)
     System.out.println(++line + "-PictureChooser constructor");
     listeners = new Vector();
     fc.addChoosableFileFilter(new ImageFilter());
     fc.setFileView(new ImageFileView());
     fc.setAccessory(new ImagePreview(fc));
private void setValue(File file)
if (DEBUG)
     System.out.println(++line + "-PictureChooser.setValue method");
     newFile = file;
public Component getTableCellEditorComponent(JTable table,
                              Object value,
                              boolean isSelected,
                              int row,
                              int col)
if (DEBUG)
     System.out.println(line + "-PictureChooser.getTableCellEditorComponent row:" + row + " col:" + col + " method");
     fc.addActionListener(new ActionListener() {
          public void actionPerformed(ActionEvent e) {
               String cmd = e.getActionCommand();
               System.out.println(++line + "-JFileChooser.actionListener cmd:" +
                                   cmd);
               if (JFileChooser.APPROVE_SELECTION.equals(cmd))
                    stopCellEditing();
               else
                    cancelCellEditing();
     //editing = true;
     //fc.setVisible(true);
     //fc.showOpenDialog(this);
     int returnVal = fc.showOpenDialog(this);
     if (returnVal == JFileChooser.APPROVE_OPTION)
     newFile = fc.getSelectedFile();
     table.setRowSelectionInterval(row,row);
     table.setColumnSelectionInterval(col,col);
     return this;
// cell editor methods
public void cancelCellEditing()
if (DEBUG)
     System.out.println(++line + "-PictureChooser.cancelCellEditing method");
     fireEditingCanceled();
     editing = false;
     fc.setVisible(false);
public Object getCellEditorValue()
if (DEBUG)
     System.out.println(++line + "-PictureChooser.getCellEditorValue method");
     return new ImageIcon(newFile.toString());
public boolean isCellEditable(EventObject eo)
if (DEBUG)
     System.out.println(++line + "-PictureChooser.isCellEditable method");
     return true;
public boolean shouldSelectCell(EventObject eo)
if (DEBUG)
     System.out.println(++line + "-PictureChooser.shouldSelectCell method");
     return true;
public boolean stopCellEditing()
if (DEBUG)
     System.out.println(++line + "-PictureChooser.stopCellEditing method");
     fireEditingStopped();
     editing = false;
     fc.setVisible(false);
     return true;
public void addCellEditorListener(CellEditorListener cel)
if (DEBUG)
     System.out.println(++line + "-PictureChooser.addCellEditorListener method");
     listeners.addElement(cel);
public void removeCellEditorListener(CellEditorListener cel)
if (DEBUG)
     System.out.println(++line + "-PictureChooser.removeCellEditorListener method");
     listeners.removeElement(cel);
public void fireEditingCanceled()
if (DEBUG)
     System.out.println(++line + "-PictureChooser.fireEditingCanceled method");
     setValue(originalFile);
     ChangeEvent ce = new ChangeEvent(this);
     for (int i=listeners.size()-1; i>=0; i--)
     ((CellEditorListener)listeners.elementAt(i)).editingCanceled(ce);
public void fireEditingStopped()
if (DEBUG)
     System.out.println(++line + "-PictureChooser.fireEditingStopped method");
     ChangeEvent ce = new ChangeEvent(this);
     for (int i=listeners.size()-1; i>=0; i--)
System.out.println(++line + "-PictureChooser listener " + i);
     ((CellEditorListener)listeners.elementAt(i)).editingStopped(ce);

Answer 1

try this code. it work fine.
regards,
pratap
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import javax.swing.border.*;
import javax.swing.table.*;
import java.io.*;
public class TableDialogEditDemo extends JFrame {
     public TableDialogEditDemo() {
          super("TableDialogEditDemo");
          MyTableModel myModel = new MyTableModel();
          JTable table = new JTable(myModel);
          table.setPreferredScrollableViewportSize(new Dimension(500, 70));
          //Create the scroll pane and add the table to it.
          JScrollPane scrollPane = new JScrollPane(table);
          //Set up renderer and editor for the Favorite Color column.
          setUpColorRenderer(table);
          setUpColorEditor(table);
          //Add the scroll pane to this window.
          getContentPane().add(scrollPane, BorderLayout.CENTER);
          addWindowListener(new WindowAdapter() {
               public void windowClosing(WindowEvent e) {
                    System.exit(0);
     private void setUpColorRenderer(JTable table) {
          table.setDefaultRenderer(File.class, new PictureRenderer(true));
     //Set up the editor for the Color cells.
     private void setUpColorEditor(JTable table) {
          table.setDefaultEditor(File.class, new PictureChooser());
     class PictureRenderer extends JLabel     implements TableCellRenderer {
          Border unselectedBorder = null;
          Border selectedBorder = null;
          boolean isBordered = true;
          public PictureRenderer(boolean isBordered) {
               super();
               this.isBordered = isBordered;
               setOpaque(false);
               setHorizontalAlignment(SwingConstants.CENTER);
          public Component getTableCellRendererComponent(
                                        JTable table, Object value,
                                        boolean isSelected, boolean hasFocus,
                                        int row, int column) {
               File f = (File)value;
               try {
                    setIcon(new ImageIcon(f.toURL()));
               catch (Exception e) {
               e.printStackTrace();
               return this;
     class MyTableModel extends AbstractTableModel {
          final String[] columnNames = {"First Name",
                                             "Favorite Color",
                                             "Sport",
                                             "# of Years",
                                             "Vegetarian"};
          final Object[][] data = {
               {"Mary", new Color(153, 0, 153), "Snowboarding", new Integer(5), new File("D:\\html\\f1.gif")},
               {"Alison", new Color(51, 51, 153), "Rowing", new Integer(3), new File("D:\\html\\f2.gif")},
               {"Philip", Color.pink, "Pool", new Integer(7), new File("D:\\html\\f3.gif")}
          public int getColumnCount() {
               return columnNames.length;
          public int getRowCount() {
               return data.length;
          public String getColumnName(int col) {
               return columnNames[col];
          public Object getValueAt(int row, int col) {
               return data[row][col];
          public Class getColumnClass(int c) {
               return getValueAt(0, c).getClass();
          public boolean isCellEditable(int row, int col) {
               if (col < 1) {
                    return false;
               } else {
                    return true;
          public void setValueAt(Object value, int row, int col) {
               data[row][col] = value;
               fireTableCellUpdated(row, col);
     public static void main(String[] args) {
          TableDialogEditDemo frame = new TableDialogEditDemo();
          frame.pack();
          frame.setVisible(true);
import java.awt.Component;
import java.util.EventObject;
import java.awt.event.*;
import java.awt.*;
import javax.swing.*;
import javax.swing.event.*;
import javax.swing.table.*;
import java.io.*;
public class PictureChooser extends JButton implements TableCellEditor, ActionListener {
     protected EventListenerList listenerList = new EventListenerList();
     protected ChangeEvent changeEvent = new ChangeEvent(this);
     private File file;
     public PictureChooser() {
          super("");
          setBackground(Color.white);
          setBorderPainted(false);
          setMargin(new Insets(0,0,0,0));
          addActionListener(this);
     public Component getTableCellEditorComponent(JTable table, Object value,
                                             boolean isSelected, int row, int column) {
     File f = (File)value;
     try {
          setIcon(new ImageIcon(f.toURL()));
     catch (Exception e) {
          e.printStackTrace();
     return this;
     public void actionPerformed(ActionEvent e)
     JFileChooser chooser = new JFileChooser("d:\\html");
     int returnVal = chooser.showOpenDialog(this);
          if(returnVal == JFileChooser.APPROVE_OPTION) {
               file = chooser.getSelectedFile();
               System.out.println("You chose to open this file: " + chooser.getSelectedFile().getName());
               fireEditingStopped();
          else
               fireEditingCanceled();
     public void addCellEditorListener(CellEditorListener listener) {
     listenerList.add(CellEditorListener.class, listener);
     public void removeCellEditorListener(CellEditorListener listener) {
     listenerList.remove(CellEditorListener.class, listener);
     protected void fireEditingStopped() {
     System.out.println("fireEditingStopped called ");
     CellEditorListener listener;
     Object[] listeners = listenerList.getListenerList();
     for (int i = 0; i < listeners.length; i++) {
          if (listeners[i] == CellEditorListener.class) {
          listener = (CellEditorListener) listeners[i + 1];
          listener.editingStopped(changeEvent);
     protected void fireEditingCanceled() {
     CellEditorListener listener;
     Object[] listeners = listenerList.getListenerList();
     for (int i = 0; i < listeners.length; i++) {
          if (listeners[i] == CellEditorListener.class) {
          listener = (CellEditorListener) listeners[i + 1];
          listener.editingCanceled(changeEvent);
     public void cancelCellEditing() {
     System.out.println("cancelCellEditing called ");
     fireEditingCanceled();
     public boolean stopCellEditing() {
     System.out.println("stopCellEditing called ");
     fireEditingStopped();
     return true;
     public boolean isCellEditable(EventObject event) {
     return true;
     public boolean shouldSelectCell(EventObject event) {
     return true;
     public Object getCellEditorValue() {
          return file;