[svn:fx-trunk] 9117: DropDownList bug fixes

Question

Revision: 9117
Author:   [email protected]
Date:     2009-08-05 14:12:45 -0700 (Wed, 05 Aug 2009)
Log Message:
DropDownList bug fixes
http://bugs.adobe.com/jira/browse/SDK-22536 - Spark DropDownList highlight not working as expected when navigating using keyboard with useVirtualLayout=true
In the keyDownHandler function, the DropDownList was trying to set the selected state on the new itemRenderer. However, in a virtual layout, the renderer might not exist until later.
The fix is to update the renderer in the updateRenderer function. This function calls isItemIndexSelected in order to choose which item to select. I have overridden the behavior to select the proposedSelectedIndex instead of the selectedIndex.
I have also renamed proposedSelectedIndex to userProposedSelectedIndex to avoid a naming conflict in ListBase.
http://bugs.adobe.com/jira/browse/SDK-22406 - Spark DropDownList popup behaves unexpectedly when component is initially disabled
I removed the call in the partAdded function that was setting the openButton to disabled. Spark components handle disabling by blocking user interaction.
QE notes: Add test cases for both bugs
Doc notes: None
Bugs: SDK-22536, SDK-22406
Reviewer: Ryan
Tests run: DropDownList
Is noteworthy for integration: No
Ticket Links:
    http://bugs.adobe.com/jira/browse/SDK-22536
    http://bugs.adobe.com/jira/browse/SDK-22406
    http://bugs.adobe.com/jira/browse/SDK-22536
    http://bugs.adobe.com/jira/browse/SDK-22406
Modified Paths:
    flex/sdk/trunk/frameworks/projects/spark/src/spark/components/DropDownList.as

Answer 1

This bug figures out also when creating a custom spark ComboBox, then trying to programatically update the userProposedSelectedIndex property. The proposed selected index is selected, but does not apply the same skin as when mouse is on rollover or item is selected due to up and down keys.
The issue seems like updating the status of the item renderer to rollover or selected to get the same skin applied.
Please could you attach DropDow nList.as that you edited ?
Thank you so much.