Swtiched computers and my script broke please help

Question

Ok, so I have this script running on my Mail.app from a rule action. It worked perfectly. Then I switch to a different computer and it's not working on the new one. Can anyone spot anything in the script that might be causing it -- or have any other ideas?
[applescript]
add a mail message to todo.txt
using terms from application "Mail"
on perform mail action with messages selectedMsgs
tell application "Mail"
repeat with msg in selectedMsgs
set theSubject to subject of msg
set theSender to extract name from sender of msg
set theDate to date received of msg
set newDate to my new_date(theDate)
set toText to "@mail @takeaction " & " @" & theSubject & " @date " & newDate
do shell script "/Volumes/JUMP/todo/todo.sh add " & toText
end repeat
end tell
end perform mail action with messages
end using terms from
on new_date(theDate)
set cDate to theDate
set shortDate to short date string of cDate
set theMonth to word 1 of shortDate
if length of theMonth is 1 then set theMonth to "0" & theMonth
set theDay to word 2 of shortDate
if length of theDay is 1 then set theDay to "0" & theDay
set theYear to (year of cDate) - 2000
set YYear to "0" & theYear
set DateString to theMonth & theDay & YYear
end new_date
[/applescript]
PowerBook G4   Mac OS X (10.4)  

Answer 1

Hi Dara
As far as I can see the variable selectedMsgs isn't defined anywhere in the script you've posted, but I suspect the error is not being returned by the "on perform mail action" handler, or that selectedMsgs is being silently coerced into an empty list.
Try this from Script Editor
using terms from application "Mail"
on perform mail action with messages selectedMsgs
tell application "Mail"
return selectedMsgs
repeat with msg in selectedMsgs
-- rest of you script goes here
The script will stop after the "return" statement in line 4 and should show the value of selectedMsgs as its result. If this is an empty list, there's your problem.
If not, you may have to temporarily add a few "display dialog" commands to see if the text variables match what you expect. For example
set newDate to my new_date(theDate)
display dialog newDate
etc etc etc.
Incidentally, your new_date handler will break in 2010. The year will be returned as "010", not "10". Try this instead:
set YYear to text -2 thru of -1 of (year of cDate as string)
Hope some of this helps.
H