Update statement

Question

I have an update statement within a sproc as follows
UPDATE temp t
           SET t.AFTER = 'william st',
               t.updated = SYSDATE,
               t.submitted = SYSDATE
         WHERE t.session= '100'
           AND t.hip= '1234'
           and t.tax= '123456789'
           AND t.location_id = NVL(p_in_loc, t.hip_location_id)
          and t.tax_id= NVL(p_in_tax, t.tax_id)
             AND t.attribute_id = '67';the update statement is not working as expected(1 row updated), when p_in_tax is NULL where p_in_hip and p_in_tax are input parameters
Any clues.
Thanks
Hena

Answer 1

Hi, Hena,
How many rows were you expecting to be updated? Post some same data (that is, what's in table temp before the UPDATE) and the results you want (what should be in temp after the UPDATE).
What are the values of the parameters?
I notice that one of the conditions is:
and t.tax_id= NVL(p_in_tax, t.tax_id)meaning (I suppose) that if the parameter p_in_tax was not supplied, and t.tax_id is not NULL, then the row should be updated. That kind of thing is pretty common.
The condition right before that looks odd:
AND t.location_id = NVL(p_in_loc, t.hip_location_id)Here the column on the left of the = sign is not the same as the 2nd argument to NVL. That's not necessarily an error, but did you really mean to do something unlike the other condition?