Update Table with xml data

Question

Hi,
I have to update Table by reading Xml data.
I have written a procedure which is given below.
PROCEDURE Sp_Set_File_Permission
p_i_v_xml_data  IN VARCHAR2,
Cur_Out_Col_Nm    OUT Typ_Icon_Out
IS 
XmlDataset   XMLTYPE;
  BEGIN
/* This is my xml
<xmldata>
<newdataset>
<fileid>99</fileid>
<add>TRUE</add>
<edit>TRUE</edit>
<del>FALSE</del>
<ex>FALSE</ex>
<im>TRUE</im>
</newdataset>
<newdataset>
<fileid>100</fileid>
<add>FALSE</add>
<edit>TRUE</edit>
<del>FALSE</del>
<ex>FALSE</ex>
<im>TRUE</im>
</newdataset>
</xmldata>*/
xmldataset := Xmltype.Createxml(p_i_v_Xml_Data);
--error occured on this line while executing procedure
FOR i IN (SELECT
               Dt.Extract('//newdataset/fileid/text()').Getstringval() AS Fileid,
               Dt.Extract('//newdataset/add/text()').Getstringval() AS Add,
               Dt.Extract('//newdataset/edit/text()').Getstringval() AS Edit,
               Dt.Extract('//newdataset/del/text()').Getstringval() AS d,
               Dt.Extract('//newdataset/ex/text()').Getstringval() AS e,
               Dt.Extract('//newdataset/im/text()').Getstringval() AS I
                FROM TABLE(Xmlsequence( xmldataset.Extract('//xmldata/newdataset'))) Dt)
    LOOP
    UPDATE t_object_master
  SET add_view=i.Add
  ,edit_view=i.Edit,
  delete_view=i.D,
  export_view=i.E,
  import_view=i.I
  WHERE objct_id=i.Fileid;
  COMMIT;
  END LOOP;
  END Sp_Set_File_Permission;
When I am trying to exceute this procedure with the above mentioned xml ,getting error ORA-00923 ,FROM keyword not found where expected.
Please help me out in this.
Thanks,

Answer 1

Something like this (no commit inside loop, no row per row)
create table t_object_master as
with myxml as (
select xmltype(
'<xmldata>
<newdataset>
<fileid>99</fileid>
<add>TRUE</add>
<edit>TRUE</edit>
<del>FALSE</del>
<ex>FALSE</ex>
<im>TRUE</im>
</newdataset>
<newdataset>
<fileid>100</fileid>
<add>FALSE</add>
<edit>TRUE</edit>
<del>FALSE</del>
<ex>FALSE</ex>
<im>TRUE</im>
</newdataset>
</xmldata>') doc from dual
select
fileid
,add_view
from
myxml
,xmltable('//newdataset'
passing myxml.doc
columns
Fileid number      path 'fileid'
,add_view varchar2(5) path 'add'
table created
select
from t_object_master
FILEID
ADD_VIEW
99
TRUE
100
FALSE
update t_object_master t
set add_view = (
with myxml as (
select xmltype(
'<xmldata>
<newdataset>
<fileid>99</fileid>
<add>FALSE</add>
<edit>TRUE</edit>
<del>FALSE</del>
<ex>FALSE</ex>
<im>TRUE</im>
</newdataset>
<newdataset>
<fileid>100</fileid>
<add>TRUE</add>
<edit>TRUE</edit>
<del>FALSE</del>
<ex>FALSE</ex>
<im>TRUE</im>
</newdataset>
</xmldata>') doc from dual
, myextract as (
select
fileid
,add_view
from
myxml
,xmltable('//newdataset'
passing myxml.doc
columns
Fileid number      path 'fileid'
,add_view varchar2(5) path 'add'
select
add_view
from myextract
where
fileid = t.fileid
select *
from  t_object_master
FILEID
ADD_VIEW
99
FALSE
100
TRUE